From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 13/73] sata_dwc_460ex: use generic tracepoints
Date: Thu, 09 Dec 2021 19:57:31 +0800 [thread overview]
Message-ID: <202112091923.b2cQMxCn-lkp@intel.com> (raw)
In-Reply-To: <20211208163255.114660-14-hare@suse.de>
[-- Attachment #1: Type: text/plain, Size: 6785 bytes --]
Hi Hannes,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rostedt-trace/for-next]
[also build test WARNING on axboe-block/for-next linus/master v5.16-rc4 next-20211208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/libata-rework-logging-take-II/20211209-003634
base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20211209/202112091923.b2cQMxCn-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/b3bb5eac4170da8a3e9c477ad4c1c8f97164abc5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hannes-Reinecke/libata-rework-logging-take-II/20211209-003634
git checkout b3bb5eac4170da8a3e9c477ad4c1c8f97164abc5
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/ata/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from drivers/ata/sata_dwc_460ex.c:28:
drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_dma_xfer_complete':
drivers/ata/sata_dwc_460ex.c:744:5: error: implicit declaration of function 'get_dma_dir_descript'; did you mean 'get_prot_descript'? [-Werror=implicit-function-declaration]
744 | get_dma_dir_descript(qc->dma_dir),
| ^~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/ata/sata_dwc_460ex.c:741:3: note: in expansion of macro 'dev_info'
741 | dev_info(ap->dev,
| ^~~~~~~~
>> drivers/ata/sata_dwc_460ex.c:742:5: warning: format '%s' expects argument of type 'char *', but argument 6 has type 'int' [-Wformat=]
742 | "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:150:51: note: in expansion of macro 'dev_fmt'
150 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/ata/sata_dwc_460ex.c:741:3: note: in expansion of macro 'dev_info'
741 | dev_info(ap->dev,
| ^~~~~~~~
drivers/ata/sata_dwc_460ex.c:742:36: note: format string is defined here
742 | "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
| ~^
| |
| char *
| %d
cc1: some warnings being treated as errors
vim +742 drivers/ata/sata_dwc_460ex.c
62936009f35a66 Rupjyoti Sarmah 2010-07-06 724
62936009f35a66 Rupjyoti Sarmah 2010-07-06 725 static void sata_dwc_dma_xfer_complete(struct ata_port *ap, u32 check_status)
62936009f35a66 Rupjyoti Sarmah 2010-07-06 726 {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 727 struct ata_queued_cmd *qc;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 728 struct sata_dwc_device_port *hsdevp = HSDEVP_FROM_AP(ap);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 729 struct sata_dwc_device *hsdev = HSDEV_FROM_AP(ap);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 730 u8 tag = 0;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 731
62936009f35a66 Rupjyoti Sarmah 2010-07-06 732 tag = ap->link.active_tag;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 733 qc = ata_qc_from_tag(ap, tag);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 734 if (!qc) {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 735 dev_err(ap->dev, "failed to get qc");
62936009f35a66 Rupjyoti Sarmah 2010-07-06 736 return;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 737 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 738
62936009f35a66 Rupjyoti Sarmah 2010-07-06 739 #ifdef DEBUG_NCQ
62936009f35a66 Rupjyoti Sarmah 2010-07-06 740 if (tag > 0) {
d578514b271e7c Andy Shevchenko 2015-03-03 741 dev_info(ap->dev,
d578514b271e7c Andy Shevchenko 2015-03-03 @742 "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
4e5b6260cc9ba8 Jens Axboe 2018-05-11 743 __func__, qc->hw_tag, qc->tf.command,
84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 @744 get_dma_dir_descript(qc->dma_dir),
84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 745 get_prot_descript(qc->tf.protocol),
ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 746 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a66 Rupjyoti Sarmah 2010-07-06 747 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 748 #endif
62936009f35a66 Rupjyoti Sarmah 2010-07-06 749
62936009f35a66 Rupjyoti Sarmah 2010-07-06 750 if (ata_is_dma(qc->tf.protocol)) {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 751 if (hsdevp->dma_pending[tag] == SATA_DWC_DMA_PENDING_NONE) {
d578514b271e7c Andy Shevchenko 2015-03-03 752 dev_err(ap->dev,
d578514b271e7c Andy Shevchenko 2015-03-03 753 "%s DMA protocol RX and TX DMA not pending dmacr: 0x%08x\n",
d578514b271e7c Andy Shevchenko 2015-03-03 754 __func__,
ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 755 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a66 Rupjyoti Sarmah 2010-07-06 756 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 757
62936009f35a66 Rupjyoti Sarmah 2010-07-06 758 hsdevp->dma_pending[tag] = SATA_DWC_DMA_PENDING_NONE;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 759 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 760 ap->link.active_tag = ATA_TAG_POISON;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 761 } else {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 762 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 763 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 764 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 765
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-09 11:57 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 16:31 [PATCH 00/73] libata: rework logging, take II Hannes Reinecke
2021-12-08 16:31 ` [PATCH 01/73] libata: remove pointless debugging messages Hannes Reinecke
2021-12-08 16:31 ` [PATCH 02/73] libata: Add ata_port_classify() helper Hannes Reinecke
2021-12-08 22:21 ` kernel test robot
2021-12-08 22:21 ` kernel test robot
2021-12-09 0:34 ` Damien Le Moal
2021-12-09 7:16 ` Hannes Reinecke
2021-12-09 4:20 ` kernel test robot
2021-12-08 16:31 ` [PATCH 03/73] libata: move ata_dump_id() to dynamic debugging Hannes Reinecke
2021-12-08 16:31 ` [PATCH 04/73] libata: sanitize ATA_HORKAGE_DUMP_ID Hannes Reinecke
2021-12-08 16:31 ` [PATCH 05/73] sata_mv: replace DPRINTK with 'pci_dump' module parameter Hannes Reinecke
2021-12-09 0:38 ` Damien Le Moal
2021-12-09 7:17 ` Hannes Reinecke
2021-12-09 8:10 ` Damien Le Moal
2021-12-08 16:31 ` [PATCH 06/73] sata_mv: kill 'port' argument in mv_dump_all_regs() Hannes Reinecke
2021-12-09 0:40 ` Damien Le Moal
2021-12-09 8:19 ` Hannes Reinecke
2021-12-08 16:31 ` [PATCH 07/73] libata: add reset tracepoints Hannes Reinecke
2021-12-08 16:31 ` [PATCH 08/73] libata: drop DPRINTK() calls in reset Hannes Reinecke
2021-12-09 0:47 ` Damien Le Moal
2021-12-08 16:31 ` [PATCH 09/73] libata: tracepoints for bus-master DMA Hannes Reinecke
2021-12-08 16:31 ` [PATCH 10/73] libata: drop debugging statements " Hannes Reinecke
2021-12-09 0:46 ` Damien Le Moal
2021-12-09 8:20 ` Hannes Reinecke
2021-12-08 16:31 ` [PATCH 11/73] pata_octeon_cf: add bmdma tracepoints and drop DPRINTK() calls Hannes Reinecke
2021-12-08 16:31 ` [PATCH 12/73] pata_arasan_cf: use generic tracepoints Hannes Reinecke
2021-12-08 16:31 ` [PATCH 13/73] sata_dwc_460ex: " Hannes Reinecke
2021-12-09 11:57 ` kernel test robot [this message]
2021-12-09 12:28 ` kernel test robot
2021-12-09 12:28 ` kernel test robot
2021-12-09 19:52 ` kernel test robot
2021-12-09 19:52 ` kernel test robot
2021-12-08 16:31 ` [PATCH 14/73] sata_nv: " Hannes Reinecke
2021-12-08 16:31 ` [PATCH 15/73] libata-sff: tracepoints for HSM state machine Hannes Reinecke
2021-12-08 16:31 ` [PATCH 16/73] libata-sff: add tracepoints for ata_sff_flush_pio_task() Hannes Reinecke
2021-12-08 16:31 ` [PATCH 17/73] libata-scsi: drop DPRINTK calls for cdb translation Hannes Reinecke
2021-12-08 16:32 ` [PATCH 18/73] libata: add tracepoints for ATA error handling Hannes Reinecke
2021-12-08 16:32 ` [PATCH 19/73] libata: drop DPRINTK() calls during " Hannes Reinecke
2021-12-09 0:50 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 20/73] libata-eh: remove DPRINTK() calls for request sense Hannes Reinecke
2021-12-09 0:51 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 21/73] libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros Hannes Reinecke
2021-12-09 0:57 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 22/73] libata: add qc_prep tracepoint Hannes Reinecke
2021-12-09 8:42 ` Sergei Shtylyov
2021-12-09 11:14 ` Hannes Reinecke
2021-12-09 12:47 ` Sergei Shtylyov
2021-12-08 16:32 ` [PATCH 23/73] libata: move DPRINTK to ata debugging Hannes Reinecke
2021-12-08 16:32 ` [PATCH 24/73] pata_octeon_cf: remove DPRINTK() macro in interrupt context Hannes Reinecke
2021-12-09 0:58 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 25/73] pdc_adma: Remove DPRINTK call Hannes Reinecke
2021-12-08 16:32 ` [PATCH 26/73] sata_fsl: move DPRINTK to ata debugging Hannes Reinecke
2021-12-08 16:32 ` [PATCH 27/73] sata_rcar: replace DPRINTK() with ata_port_dbg() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 28/73] sata_qstor: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 29/73] pata_pdc2027x: Replace PDPRINTK() with standard ata logging Hannes Reinecke
2021-12-08 16:32 ` [PATCH 30/73] libata: remove pointless VPRINTK() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 31/73] ahci: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-08 16:32 ` [PATCH 32/73] pdc_adma: " Hannes Reinecke
2021-12-09 1:01 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 33/73] pata_octeon_cf: " Hannes Reinecke
2021-12-09 8:39 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 34/73] pata_via: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 35/73] sata_promise: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-09 6:13 ` Mikael Pettersson
2021-12-08 16:32 ` [PATCH 36/73] sata_qstor: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 37/73] sata_rcar: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 38/73] sata_inic162x: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 39/73] sata_mv: Drop pointless VPRINTK() call and convert the remaining one Hannes Reinecke
2021-12-08 16:32 ` [PATCH 40/73] sata_nv: drop pointless VPRINTK() calls and convert remaining ones Hannes Reinecke
2021-12-08 16:32 ` [PATCH 41/73] sata_fsl: convert VPRINTK() calls to ata_port_dbg() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 42/73] sata_sil: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 43/73] sata_sx4: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-08 16:32 ` [PATCH 44/73] sata_sx4: add module parameter 'dimm_test' Hannes Reinecke
2021-12-08 16:32 ` [PATCH 45/73] libata: drop ata_msg_error() and ata_msg_intr() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 46/73] libata: drop ata_msg_ctl() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 47/73] libata: drop ata_msg_malloc() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 48/73] libata: drop ata_msg_warn() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 49/73] libata: drop ata_msg_probe() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 50/73] libata: drop ata_msg_info() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 51/73] libata: drop ata_msg_drv() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 52/73] libata: remove 'new' ata message handling Hannes Reinecke
2021-12-08 16:32 ` [PATCH 53/73] libata: remove debug compilation switches Hannes Reinecke
2021-12-08 16:32 ` [PATCH 54/73] pata_atp867x: convert blank printk() calls Hannes Reinecke
2021-12-08 22:21 ` kernel test robot
2021-12-09 1:08 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 55/73] pata_cmd640: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 56/73] pata_cmd64x: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 57/73] pata_cs5520: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 58/73] pata_cs5536: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 59/73] pata_cypressx: " Hannes Reinecke
2021-12-09 8:25 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 60/73] pata_it821x: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 61/73] pata_marvell: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 62/73] pata_rz1000: " Hannes Reinecke
2021-12-09 1:10 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 63/73] pata_serverworks: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 64/73] pata_sil680: " Hannes Reinecke
2021-12-09 8:24 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 65/73] pdc_adma: remove disabled debugging messages Hannes Reinecke
2021-12-08 16:32 ` [PATCH 66/73] sata_sx4: convert blank printk() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 67/73] sata_mv: convert remaining printk() to structured logging Hannes Reinecke
2021-12-08 16:32 ` [PATCH 68/73] pata_hpt37x: convert pr_XXX() calls Hannes Reinecke
2021-12-09 1:13 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 69/73] pata_octeon_cf: Replace pr_XXX() calls with structured logging Hannes Reinecke
2021-12-09 8:08 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 70/73] pata_hpt3x2n: convert pr_XXX() calls Hannes Reinecke
2021-12-09 1:13 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 71/73] pata_hpt3x2n: convert pr_err() calls Hannes Reinecke
2021-12-09 1:14 ` Damien Le Moal
2021-12-09 8:09 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 72/73] pata_hpt366: convert pr_warn() calls Hannes Reinecke
2021-12-09 1:14 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 73/73] libata-scsi: rework ata_dump_status to avoid using pr_cont() Hannes Reinecke
2021-12-09 1:17 ` [PATCH 00/73] libata: rework logging, take II Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112091923.b2cQMxCn-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.