All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Pelletier <plr.vincent@gmail.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	Paul Walmsley <paul.walmsley@sifive.com>,
	aou@eecs.berkeley.edu,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
Date: Tue, 14 Dec 2021 11:16:59 +0000	[thread overview]
Message-ID: <20211214111659.29bf5ea4@gmail.com> (raw)
In-Reply-To: <YbhqNY/w36XT5zx0@aurel32.net>

On Tue, 14 Dec 2021 10:56:05 +0100, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On 2021-12-13 18:13, Palmer Dabbelt wrote:
> > On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:  
> > > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> > > RTC, a watchdog and the power button input.
> > > 
> > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > > ---
> > >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > > 
> > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > index 2e4ea84f27e7..c357b48582f7 100644
> > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > @@ -70,6 +70,10 @@ pmic@58 {
> > >  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> > >  		interrupt-controller;
> > > 
> > > +		onkey {
> > > +			compatible = "dlg,da9063-onkey";
> > > +		};
> > > +
> > >  		regulators {
> > >  			vdd_bcore1: bcore1 {
> > >  				regulator-min-microvolt = <900000>;
> > > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
> > >  				regulator-always-on;
> > >  			};
> > >  		};
> > > +
> > > +		rtc {
> > > +			compatible = "dlg,da9063-rtc";
> > > +		};
> > > +
> > > +		wdt {
> > > +			compatible = "dlg,da9063-watchdog";
> > > +		};
> > >  	};
> > >  };  
> 
> Thanks. However, wouldn't be better to merged this patch and the whole
> series instead:
> 
> http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html

My apologies about this, by the way: I had prepared that patch stack
last summer and was witholding it until the IRQ-fires-only-once
situation was resolved (it does affect at least the onkey subfunction,
although in a non-obvious way when the event triggers a shutdown or a
reboot). I did not think of checking recent submissions until it was
too late.
-- 
Vincent Pelletier
GPG fingerprint 983A E8B7 3B91 1598 7A92 3845 CAC9 3691 4257 B0C1

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Vincent Pelletier <plr.vincent@gmail.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	Paul Walmsley <paul.walmsley@sifive.com>,
	aou@eecs.berkeley.edu,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
Date: Tue, 14 Dec 2021 11:16:59 +0000	[thread overview]
Message-ID: <20211214111659.29bf5ea4@gmail.com> (raw)
In-Reply-To: <YbhqNY/w36XT5zx0@aurel32.net>

On Tue, 14 Dec 2021 10:56:05 +0100, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On 2021-12-13 18:13, Palmer Dabbelt wrote:
> > On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:  
> > > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> > > RTC, a watchdog and the power button input.
> > > 
> > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > > ---
> > >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > > 
> > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > index 2e4ea84f27e7..c357b48582f7 100644
> > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > @@ -70,6 +70,10 @@ pmic@58 {
> > >  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> > >  		interrupt-controller;
> > > 
> > > +		onkey {
> > > +			compatible = "dlg,da9063-onkey";
> > > +		};
> > > +
> > >  		regulators {
> > >  			vdd_bcore1: bcore1 {
> > >  				regulator-min-microvolt = <900000>;
> > > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
> > >  				regulator-always-on;
> > >  			};
> > >  		};
> > > +
> > > +		rtc {
> > > +			compatible = "dlg,da9063-rtc";
> > > +		};
> > > +
> > > +		wdt {
> > > +			compatible = "dlg,da9063-watchdog";
> > > +		};
> > >  	};
> > >  };  
> 
> Thanks. However, wouldn't be better to merged this patch and the whole
> series instead:
> 
> http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html

My apologies about this, by the way: I had prepared that patch stack
last summer and was witholding it until the IRQ-fires-only-once
situation was resolved (it does affect at least the onkey subfunction,
although in a non-obvious way when the event triggers a shutdown or a
reboot). I did not think of checking recent submissions until it was
too late.
-- 
Vincent Pelletier
GPG fingerprint 983A E8B7 3B91 1598 7A92 3845 CAC9 3691 4257 B0C1

  reply	other threads:[~2021-12-14 11:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 21:46 [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched Aurelien Jarno
2021-11-08 21:46 ` Aurelien Jarno
2021-12-14  2:13 ` Palmer Dabbelt
2021-12-14  2:13   ` Palmer Dabbelt
2021-12-14  9:56   ` Aurelien Jarno
2021-12-14  9:56     ` Aurelien Jarno
2021-12-14 11:16     ` Vincent Pelletier [this message]
2021-12-14 11:16       ` Vincent Pelletier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211214111659.29bf5ea4@gmail.com \
    --to=plr.vincent@gmail.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=aurelien@aurel32.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.