[PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
@ 2021-11-08 21:46 ` Aurelien Jarno
  0 siblings, 0 replies; 8+ messages in thread
From: Aurelien Jarno @ 2021-11-08 21:46 UTC (permalink / raw)
  To: linux-kernel
  Cc: Aurelien Jarno, Rob Herring, Paul Walmsley, Palmer Dabbelt,
	Albert Ou,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:RISC-V ARCHITECTURE

The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
RTC, a watchdog and the power button input.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 2e4ea84f27e7..c357b48582f7 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -70,6 +70,10 @@ pmic@58 {
 		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
 		interrupt-controller;
 
+		onkey {
+			compatible = "dlg,da9063-onkey";
+		};
+
 		regulators {
 			vdd_bcore1: bcore1 {
 				regulator-min-microvolt = <900000>;
@@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
 				regulator-always-on;
 			};
 		};
+
+		rtc {
+			compatible = "dlg,da9063-rtc";
+		};
+
+		wdt {
+			compatible = "dlg,da9063-watchdog";
+		};
 	};
 };
 
-- 
2.30.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
@ 2021-11-08 21:46 ` Aurelien Jarno
  0 siblings, 0 replies; 8+ messages in thread
From: Aurelien Jarno @ 2021-11-08 21:46 UTC (permalink / raw)
  To: linux-kernel
  Cc: Aurelien Jarno, Rob Herring, Paul Walmsley, Palmer Dabbelt,
	Albert Ou,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:RISC-V ARCHITECTURE

The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
RTC, a watchdog and the power button input.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 2e4ea84f27e7..c357b48582f7 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -70,6 +70,10 @@ pmic@58 {
 		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
 		interrupt-controller;
 
+		onkey {
+			compatible = "dlg,da9063-onkey";
+		};
+
 		regulators {
 			vdd_bcore1: bcore1 {
 				regulator-min-microvolt = <900000>;
@@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
 				regulator-always-on;
 			};
 		};
+
+		rtc {
+			compatible = "dlg,da9063-rtc";
+		};
+
+		wdt {
+			compatible = "dlg,da9063-watchdog";
+		};
 	};
 };
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
  2021-11-08 21:46 ` Aurelien Jarno
@ 2021-12-14  2:13   ` Palmer Dabbelt
  -1 siblings, 0 replies; 8+ messages in thread
From: Palmer Dabbelt @ 2021-12-14  2:13 UTC (permalink / raw)
  To: aurelien
  Cc: linux-kernel, aurelien, robh+dt, Paul Walmsley, aou,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:RISC-V ARCHITECTURE

On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:
> The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> RTC, a watchdog and the power button input.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 2e4ea84f27e7..c357b48582f7 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -70,6 +70,10 @@ pmic@58 {
>  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
>  		interrupt-controller;
>
> +		onkey {
> +			compatible = "dlg,da9063-onkey";
> +		};
> +
>  		regulators {
>  			vdd_bcore1: bcore1 {
>  				regulator-min-microvolt = <900000>;
> @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
>  				regulator-always-on;
>  			};
>  		};
> +
> +		rtc {
> +			compatible = "dlg,da9063-rtc";
> +		};
> +
> +		wdt {
> +			compatible = "dlg,da9063-watchdog";
> +		};
>  	};
>  };

Thanks, this is on for-next.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
@ 2021-12-14  2:13   ` Palmer Dabbelt
  0 siblings, 0 replies; 8+ messages in thread
From: Palmer Dabbelt @ 2021-12-14  2:13 UTC (permalink / raw)
  To: aurelien
  Cc: linux-kernel, aurelien, robh+dt, Paul Walmsley, aou,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:RISC-V ARCHITECTURE

On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:
> The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> RTC, a watchdog and the power button input.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 2e4ea84f27e7..c357b48582f7 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -70,6 +70,10 @@ pmic@58 {
>  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
>  		interrupt-controller;
>
> +		onkey {
> +			compatible = "dlg,da9063-onkey";
> +		};
> +
>  		regulators {
>  			vdd_bcore1: bcore1 {
>  				regulator-min-microvolt = <900000>;
> @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
>  				regulator-always-on;
>  			};
>  		};
> +
> +		rtc {
> +			compatible = "dlg,da9063-rtc";
> +		};
> +
> +		wdt {
> +			compatible = "dlg,da9063-watchdog";
> +		};
>  	};
>  };

Thanks, this is on for-next.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
  2021-12-14  2:13   ` Palmer Dabbelt
@ 2021-12-14  9:56     ` Aurelien Jarno
  -1 siblings, 0 replies; 8+ messages in thread
From: Aurelien Jarno @ 2021-12-14  9:56 UTC (permalink / raw)
  To: Palmer Dabbelt, Vincent Pelletier
  Cc: linux-kernel, robh+dt, Paul Walmsley, aou,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:RISC-V ARCHITECTURE

On 2021-12-13 18:13, Palmer Dabbelt wrote:
> On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:
> > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> > RTC, a watchdog and the power button input.
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 2e4ea84f27e7..c357b48582f7 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -70,6 +70,10 @@ pmic@58 {
> >  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> >  		interrupt-controller;
> > 
> > +		onkey {
> > +			compatible = "dlg,da9063-onkey";
> > +		};
> > +
> >  		regulators {
> >  			vdd_bcore1: bcore1 {
> >  				regulator-min-microvolt = <900000>;
> > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
> >  				regulator-always-on;
> >  			};
> >  		};
> > +
> > +		rtc {
> > +			compatible = "dlg,da9063-rtc";
> > +		};
> > +
> > +		wdt {
> > +			compatible = "dlg,da9063-watchdog";
> > +		};
> >  	};
> >  };

Thanks. However, wouldn't be better to merged this patch and the whole
series instead:

http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html

Regards,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
@ 2021-12-14  9:56     ` Aurelien Jarno
  0 siblings, 0 replies; 8+ messages in thread
From: Aurelien Jarno @ 2021-12-14  9:56 UTC (permalink / raw)
  To: Palmer Dabbelt, Vincent Pelletier
  Cc: linux-kernel, robh+dt, Paul Walmsley, aou,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:RISC-V ARCHITECTURE

On 2021-12-13 18:13, Palmer Dabbelt wrote:
> On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:
> > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> > RTC, a watchdog and the power button input.
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 2e4ea84f27e7..c357b48582f7 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -70,6 +70,10 @@ pmic@58 {
> >  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> >  		interrupt-controller;
> > 
> > +		onkey {
> > +			compatible = "dlg,da9063-onkey";
> > +		};
> > +
> >  		regulators {
> >  			vdd_bcore1: bcore1 {
> >  				regulator-min-microvolt = <900000>;
> > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
> >  				regulator-always-on;
> >  			};
> >  		};
> > +
> > +		rtc {
> > +			compatible = "dlg,da9063-rtc";
> > +		};
> > +
> > +		wdt {
> > +			compatible = "dlg,da9063-watchdog";
> > +		};
> >  	};
> >  };

Thanks. However, wouldn't be better to merged this patch and the whole
series instead:

http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html

Regards,
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
  2021-12-14  9:56     ` Aurelien Jarno
@ 2021-12-14 11:16       ` Vincent Pelletier
  -1 siblings, 0 replies; 8+ messages in thread
From: Vincent Pelletier @ 2021-12-14 11:16 UTC (permalink / raw)
  To: Aurelien Jarno
  Cc: Palmer Dabbelt, linux-kernel, robh+dt, Paul Walmsley, aou,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:RISC-V ARCHITECTURE

On Tue, 14 Dec 2021 10:56:05 +0100, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On 2021-12-13 18:13, Palmer Dabbelt wrote:
> > On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:  
> > > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> > > RTC, a watchdog and the power button input.
> > > 
> > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > > ---
> > >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > > 
> > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > index 2e4ea84f27e7..c357b48582f7 100644
> > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > @@ -70,6 +70,10 @@ pmic@58 {
> > >  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> > >  		interrupt-controller;
> > > 
> > > +		onkey {
> > > +			compatible = "dlg,da9063-onkey";
> > > +		};
> > > +
> > >  		regulators {
> > >  			vdd_bcore1: bcore1 {
> > >  				regulator-min-microvolt = <900000>;
> > > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
> > >  				regulator-always-on;
> > >  			};
> > >  		};
> > > +
> > > +		rtc {
> > > +			compatible = "dlg,da9063-rtc";
> > > +		};
> > > +
> > > +		wdt {
> > > +			compatible = "dlg,da9063-watchdog";
> > > +		};
> > >  	};
> > >  };  
> 
> Thanks. However, wouldn't be better to merged this patch and the whole
> series instead:
> 
> http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html

My apologies about this, by the way: I had prepared that patch stack
last summer and was witholding it until the IRQ-fires-only-once
situation was resolved (it does affect at least the onkey subfunction,
although in a non-obvious way when the event triggers a shutdown or a
reboot). I did not think of checking recent submissions until it was
too late.
-- 
Vincent Pelletier
GPG fingerprint 983A E8B7 3B91 1598 7A92 3845 CAC9 3691 4257 B0C1

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched
@ 2021-12-14 11:16       ` Vincent Pelletier
  0 siblings, 0 replies; 8+ messages in thread
From: Vincent Pelletier @ 2021-12-14 11:16 UTC (permalink / raw)
  To: Aurelien Jarno
  Cc: Palmer Dabbelt, linux-kernel, robh+dt, Paul Walmsley, aou,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:RISC-V ARCHITECTURE

On Tue, 14 Dec 2021 10:56:05 +0100, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On 2021-12-13 18:13, Palmer Dabbelt wrote:
> > On Mon, 08 Nov 2021 13:46:29 PST (-0800), aurelien@aurel32.net wrote:  
> > > The DA9063 PMIC found on the SiFive HiFive Unmatched also provides an
> > > RTC, a watchdog and the power button input.
> > > 
> > > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > > ---
> > >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > > 
> > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > index 2e4ea84f27e7..c357b48582f7 100644
> > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > > @@ -70,6 +70,10 @@ pmic@58 {
> > >  		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> > >  		interrupt-controller;
> > > 
> > > +		onkey {
> > > +			compatible = "dlg,da9063-onkey";
> > > +		};
> > > +
> > >  		regulators {
> > >  			vdd_bcore1: bcore1 {
> > >  				regulator-min-microvolt = <900000>;
> > > @@ -205,6 +209,14 @@ vdd_ldo11: ldo11 {
> > >  				regulator-always-on;
> > >  			};
> > >  		};
> > > +
> > > +		rtc {
> > > +			compatible = "dlg,da9063-rtc";
> > > +		};
> > > +
> > > +		wdt {
> > > +			compatible = "dlg,da9063-watchdog";
> > > +		};
> > >  	};
> > >  };  
> 
> Thanks. However, wouldn't be better to merged this patch and the whole
> series instead:
> 
> http://lists.infradead.org/pipermail/linux-riscv/2021-November/010234.html

My apologies about this, by the way: I had prepared that patch stack
last summer and was witholding it until the IRQ-fires-only-once
situation was resolved (it does affect at least the onkey subfunction,
although in a non-obvious way when the event triggers a shutdown or a
reboot). I did not think of checking recent submissions until it was
too late.
-- 
Vincent Pelletier
GPG fingerprint 983A E8B7 3B91 1598 7A92 3845 CAC9 3691 4257 B0C1

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-12-14 11:17 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-08 21:46 [PATCH] riscv: dts: enable more DA9063 functions for the SiFive HiFive Unmatched Aurelien Jarno
2021-11-08 21:46 ` Aurelien Jarno
2021-12-14  2:13 ` Palmer Dabbelt
2021-12-14  2:13   ` Palmer Dabbelt
2021-12-14  9:56   ` Aurelien Jarno
2021-12-14  9:56     ` Aurelien Jarno
2021-12-14 11:16     ` Vincent Pelletier
2021-12-14 11:16       ` Vincent Pelletier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.