* [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
@ 2021-12-11 8:53 ` Lisa Hill
0 siblings, 0 replies; 11+ messages in thread
From: Lisa Hill @ 2021-12-11 8:53 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli, Hauke Mehrtens
Cc: Rafał Miłecki, Rob Herring, linux-arm-kernel,
devicetree, bcm-kernel-feedback-list
Set GPIO controlling power for both USB ports properly, add missing WAN LEDs and specify USB ports for the USB LED on Netgear R6300v2.
Signed-off-by: Lisa Hill <f11o1iomh3dmt141n@icloud.com>
---
.../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 26 ++++++++++++++++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
index 4c60eda296d973..46e77973b12df0 100644
--- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
+++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
@@ -34,20 +34,32 @@
linux,default-trigger = "default-on";
};
- power0 {
+ power-green {
label = "bcm53xx:green:power";
gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
};
- power1 {
+ power-amber {
label = "bcm53xx:amber:power";
gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
- linux,default-trigger = "default-on";
};
usb {
label = "bcm53xx:blue:usb";
gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+ trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>;
+ linux,default-trigger = "usbport";
+ };
+
+ wan-green {
+ label = "bcm53xx:green:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>;
+ };
+
+ wan-amber {
+ label = "bcm53xx:amber:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
};
wireless {
@@ -79,6 +91,14 @@
};
};
+&usb2 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
+&usb3 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
&spi_nor {
status = "okay";
};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
@ 2021-12-11 8:53 ` Lisa Hill
0 siblings, 0 replies; 11+ messages in thread
From: Lisa Hill @ 2021-12-11 8:53 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli, Hauke Mehrtens
Cc: Rafał Miłecki, Rob Herring, linux-arm-kernel,
devicetree, bcm-kernel-feedback-list
Set GPIO controlling power for both USB ports properly, add missing WAN LEDs and specify USB ports for the USB LED on Netgear R6300v2.
Signed-off-by: Lisa Hill <f11o1iomh3dmt141n@icloud.com>
---
.../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 26 ++++++++++++++++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
index 4c60eda296d973..46e77973b12df0 100644
--- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
+++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
@@ -34,20 +34,32 @@
linux,default-trigger = "default-on";
};
- power0 {
+ power-green {
label = "bcm53xx:green:power";
gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
};
- power1 {
+ power-amber {
label = "bcm53xx:amber:power";
gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
- linux,default-trigger = "default-on";
};
usb {
label = "bcm53xx:blue:usb";
gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+ trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>;
+ linux,default-trigger = "usbport";
+ };
+
+ wan-green {
+ label = "bcm53xx:green:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>;
+ };
+
+ wan-amber {
+ label = "bcm53xx:amber:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
};
wireless {
@@ -79,6 +91,14 @@
};
};
+&usb2 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
+&usb3 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
&spi_nor {
status = "okay";
};
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
2021-12-11 8:53 ` Lisa Hill
(?)
@ 2021-12-16 21:56 ` kernel test robot
-1 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2021-12-16 21:56 UTC (permalink / raw)
To: Lisa Hill, Rafał Miłecki, Florian Fainelli,
Hauke Mehrtens
Cc: kbuild-all, Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list
Hi Lisa,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on v5.16-rc5 next-20211215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lisa-Hill/ARM-dts-BCM5301X-Add-USB-GPIO-and-missing-LEDs-on-Netgear-R6300v2/20211211-165513
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce: make ARCH=arm dtbs_check
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
dtcheck warnings: (new ones prefixed by >>)
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb@22000: '#address-cells', '#size-cells', '#usb-cells', 'port@1', 'port@2' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/usb/generic-ohci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb@23000: port@1: 'compatible' is a required property
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb@23000: Unevaluated properties are not allowed ('#usb-cells', 'phys', 'phy-names', '#address-cells', '#size-cells', 'port@1' were unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: cru@100: $nodename:0: 'cru@100' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
From schema: /usr/local/lib/python3.9/dist-packages/dtschema/schemas/simple-bus.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml:0:0: /nand-controller@18028000/nand@0/partitions: failed to match any schema with compatible: ['brcm,bcm947xx-cfe-partitions']
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml:0:0: /spi@18029200/flash@0/partitions: failed to match any schema with compatible: ['brcm,bcm947xx-cfe-partitions']
>> arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: leds: 'logo', 'power-amber', 'power-green', 'usb', 'wan-amber', 'wan-green', 'wireless' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
@ 2021-12-16 21:56 ` kernel test robot
0 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2021-12-16 21:56 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2585 bytes --]
Hi Lisa,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on v5.16-rc5 next-20211215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lisa-Hill/ARM-dts-BCM5301X-Add-USB-GPIO-and-missing-LEDs-on-Netgear-R6300v2/20211211-165513
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce: make ARCH=arm dtbs_check
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
dtcheck warnings: (new ones prefixed by >>)
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb(a)22000: '#address-cells', '#size-cells', '#usb-cells', 'port(a)1', 'port(a)2' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/usb/generic-ohci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb(a)23000: port(a)1: 'compatible' is a required property
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb(a)23000: Unevaluated properties are not allowed ('#usb-cells', 'phys', 'phy-names', '#address-cells', '#size-cells', 'port(a)1' were unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: cru(a)100: $nodename:0: 'cru(a)100' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
From schema: /usr/local/lib/python3.9/dist-packages/dtschema/schemas/simple-bus.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml:0:0: /nand-controller(a)18028000/nand(a)0/partitions: failed to match any schema with compatible: ['brcm,bcm947xx-cfe-partitions']
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml:0:0: /spi(a)18029200/flash(a)0/partitions: failed to match any schema with compatible: ['brcm,bcm947xx-cfe-partitions']
>> arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: leds: 'logo', 'power-amber', 'power-green', 'usb', 'wan-amber', 'wan-green', 'wireless' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
@ 2021-12-16 21:56 ` kernel test robot
0 siblings, 0 replies; 11+ messages in thread
From: kernel test robot @ 2021-12-16 21:56 UTC (permalink / raw)
To: Lisa Hill, Rafał Miłecki, Florian Fainelli,
Hauke Mehrtens
Cc: kbuild-all, Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list
Hi Lisa,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on v5.16-rc5 next-20211215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lisa-Hill/ARM-dts-BCM5301X-Add-USB-GPIO-and-missing-LEDs-on-Netgear-R6300v2/20211211-165513
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce: make ARCH=arm dtbs_check
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
dtcheck warnings: (new ones prefixed by >>)
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb@22000: '#address-cells', '#size-cells', '#usb-cells', 'port@1', 'port@2' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/usb/generic-ohci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb@23000: port@1: 'compatible' is a required property
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: usb@23000: Unevaluated properties are not allowed ('#usb-cells', 'phys', 'phy-names', '#address-cells', '#size-cells', 'port@1' were unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: cru@100: $nodename:0: 'cru@100' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
From schema: /usr/local/lib/python3.9/dist-packages/dtschema/schemas/simple-bus.yaml
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml:0:0: /nand-controller@18028000/nand@0/partitions: failed to match any schema with compatible: ['brcm,bcm947xx-cfe-partitions']
arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml:0:0: /spi@18029200/flash@0/partitions: failed to match any schema with compatible: ['brcm,bcm947xx-cfe-partitions']
>> arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dt.yaml: leds: 'logo', 'power-amber', 'power-green', 'usb', 'wan-amber', 'wan-green', 'wireless' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
@ 2021-12-10 6:53 ` Lisa Hill
0 siblings, 0 replies; 11+ messages in thread
From: Lisa Hill @ 2021-12-10 6:53 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli, Hauke Mehrtens
Cc: Rafał Miłecki, Rob Herring, linux-arm-kernel,
devicetree, bcm-kernel-feedback-list
Set GPIO controlling power for both USB ports properly and add two WAN LEDs and a USB LED missing for the Netgear R6300v2.
Signed-off-by: Lisa Hill <f11o1iomh3dmt141n@icloud.com>
---
.../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 27 ++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
index 4c60eda296d973..5810c95ab239ae 100644
--- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
+++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
@@ -34,20 +34,33 @@
linux,default-trigger = "default-on";
};
- power0 {
+ power-green {
label = "bcm53xx:green:power";
gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
};
- power1 {
+ power-amber {
label = "bcm53xx:amber:power";
gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
- linux,default-trigger = "default-on";
};
usb {
label = "bcm53xx:blue:usb";
gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+ trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>;
+ linux,default-trigger = "usbport";
+ };
+
+ wan-green {
+ label = "bcm53xx:green:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
+ };
+
+ wan-amber {
+ label = "bcm53xx:amber:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
};
wireless {
@@ -79,6 +92,14 @@
};
};
+&usb2 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
+&usb3 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
&spi_nor {
status = "okay";
};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
@ 2021-12-10 6:53 ` Lisa Hill
0 siblings, 0 replies; 11+ messages in thread
From: Lisa Hill @ 2021-12-10 6:53 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli, Hauke Mehrtens
Cc: Rafał Miłecki, Rob Herring, linux-arm-kernel,
devicetree, bcm-kernel-feedback-list
Set GPIO controlling power for both USB ports properly and add two WAN LEDs and a USB LED missing for the Netgear R6300v2.
Signed-off-by: Lisa Hill <f11o1iomh3dmt141n@icloud.com>
---
.../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 27 ++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
index 4c60eda296d973..5810c95ab239ae 100644
--- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
+++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
@@ -34,20 +34,33 @@
linux,default-trigger = "default-on";
};
- power0 {
+ power-green {
label = "bcm53xx:green:power";
gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
};
- power1 {
+ power-amber {
label = "bcm53xx:amber:power";
gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
- linux,default-trigger = "default-on";
};
usb {
label = "bcm53xx:blue:usb";
gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+ trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>;
+ linux,default-trigger = "usbport";
+ };
+
+ wan-green {
+ label = "bcm53xx:green:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
+ };
+
+ wan-amber {
+ label = "bcm53xx:amber:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
};
wireless {
@@ -79,6 +92,14 @@
};
};
+&usb2 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
+&usb3 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
&spi_nor {
status = "okay";
};
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
2021-12-10 6:53 ` Lisa Hill
@ 2021-12-10 7:39 ` Rafał Miłecki
-1 siblings, 0 replies; 11+ messages in thread
From: Rafał Miłecki @ 2021-12-10 7:39 UTC (permalink / raw)
To: Lisa Hill, Rafał Miłecki, Florian Fainelli,
Hauke Mehrtens
Cc: Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list
On 10.12.2021 07:53, Lisa Hill wrote:
> Set GPIO controlling power for both USB ports properly and add two WAN LEDs and a USB LED missing for the Netgear R6300v2.
>
> Signed-off-by: Lisa Hill <f11o1iomh3dmt141n@icloud.com>
Nice work!
One more comment on sending patches: please configure your e-mail client
to send text only (text/plain) without extra HTML version (text/html).
If you can't configure your e-mail easily you can also try
"git send-email" command line tool.
See:
https://www.kernel.org/doc/html/v5.15/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
https://www.kernel.org/doc/html/v5.15/process/email-clients.html
Also see comments below.
> ---
> .../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 27 ++++++++++++++++---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
> index 4c60eda296d973..5810c95ab239ae 100644
> --- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
> +++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
> @@ -34,20 +34,33 @@
> linux,default-trigger = "default-on";
> };
>
> - power0 {
> + power-green {
> label = "bcm53xx:green:power";
> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
> };
>
> - power1 {
> + power-amber {
> label = "bcm53xx:amber:power";
> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
> - linux,default-trigger = "default-on";
> };
>
> usb {
> label = "bcm53xx:blue:usb";
> gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
> + trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>;
> + linux,default-trigger = "usbport";
> + };
> +
No tabs in empty separator line please.
> + wan-green {
> + label = "bcm53xx:green:wan";
> + gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
I think it's a rather bad idea to blindly set WAN LED on. It should be
up to operating system to decide under what conditions turn it on.
I think you should drop that linux,default-trigger.
> + };
> +
No tabs in empty separator line please.
> + wan-amber {
> + label = "bcm53xx:amber:wan";
> + gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
> };
It's unlikely both WAN LEDs (green & amber) are controlled by the same
GPIO (10). Please verify that.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
@ 2021-12-10 7:39 ` Rafał Miłecki
0 siblings, 0 replies; 11+ messages in thread
From: Rafał Miłecki @ 2021-12-10 7:39 UTC (permalink / raw)
To: Lisa Hill, Rafał Miłecki, Florian Fainelli,
Hauke Mehrtens
Cc: Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list
On 10.12.2021 07:53, Lisa Hill wrote:
> Set GPIO controlling power for both USB ports properly and add two WAN LEDs and a USB LED missing for the Netgear R6300v2.
>
> Signed-off-by: Lisa Hill <f11o1iomh3dmt141n@icloud.com>
Nice work!
One more comment on sending patches: please configure your e-mail client
to send text only (text/plain) without extra HTML version (text/html).
If you can't configure your e-mail easily you can also try
"git send-email" command line tool.
See:
https://www.kernel.org/doc/html/v5.15/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
https://www.kernel.org/doc/html/v5.15/process/email-clients.html
Also see comments below.
> ---
> .../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 27 ++++++++++++++++---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
> index 4c60eda296d973..5810c95ab239ae 100644
> --- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
> +++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
> @@ -34,20 +34,33 @@
> linux,default-trigger = "default-on";
> };
>
> - power0 {
> + power-green {
> label = "bcm53xx:green:power";
> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
> };
>
> - power1 {
> + power-amber {
> label = "bcm53xx:amber:power";
> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
> - linux,default-trigger = "default-on";
> };
>
> usb {
> label = "bcm53xx:blue:usb";
> gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
> + trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>;
> + linux,default-trigger = "usbport";
> + };
> +
No tabs in empty separator line please.
> + wan-green {
> + label = "bcm53xx:green:wan";
> + gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
I think it's a rather bad idea to blindly set WAN LED on. It should be
up to operating system to decide under what conditions turn it on.
I think you should drop that linux,default-trigger.
> + };
> +
No tabs in empty separator line please.
> + wan-amber {
> + label = "bcm53xx:amber:wan";
> + gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
> };
It's unlikely both WAN LEDs (green & amber) are controlled by the same
GPIO (10). Please verify that.
^ permalink raw reply [flat|nested] 11+ messages in thread[parent not found: <C624909D-1513-4256-BCC1-50C7B43402CC@icloud.com>]
* Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
[not found] ` <C624909D-1513-4256-BCC1-50C7B43402CC@icloud.com>
@ 2021-12-10 9:31 ` Rafał Miłecki
0 siblings, 0 replies; 11+ messages in thread
From: Rafał Miłecki @ 2021-12-10 9:31 UTC (permalink / raw)
To: Lisa Hill
Cc: Rafał Miłecki, Florian Fainelli, Hauke Mehrtens,
Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list
On 10.12.2021 10:18, Lisa Hill wrote:
> On Dec 10, 2021, at 15:39, Rafał Miłecki <zajec5@gmail.com> wrote:
>
>> One more comment on sending patches: please configure your e-mail client
>> to send text only (text/plain) without extra HTML version (text/html).
>>
>> If you can't configure your e-mail easily you can also try
>> "git send-email" command line tool.
>>
>> See:
>> https://www.kernel.org/doc/html/v5.15/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
>> https://www.kernel.org/doc/html/v5.15/process/email-clients.html
>>
>> Also see comments below.
>>
>
> Thanks for your help. I have noticed the #no-mime-no-links-no-compression-no-attachments-just-plain-text warning from The Linux Kernel documentation. However I sent a Safari-copied html mail by accident which was rejected by linux-arm-kernel@lists.infradead.org. Now I have configured my e-mail client to send plain text by default. Can you verify that on my reply?
It's perfect.
> Should I cc to Florian Fainelli <f.fainelli@gmail.com> and Hauke Mehrtens <hauke@hauke-m.de> any more? I have noticed your two e-mail clients from commits: rafal@milecki.pl and zajec5@gmail.com. Which one should I use to contact you? Should I cc to another?
Yes, please include Florian & Hauke.
Either of my addresses is fine.
>>> + };
>>> +
>>
>> No tabs in empty separator line please.
>>
>
> I forgot to remove tabs when I made this commit on Github. Sorry for that.
>
> The linux repo is too big for me to clone. I have to use the fork feature in Github if I want to use git diff to create the patch. That’s why I can’t use "git send-email” which is recommended by The Linux Kernel documentation. Do you have any idea how I can send you the patch directly from Github instead of a 3rd e-mail client?
You can limit amount of cloned data by using --depth. Maybe that will
help.
git clone -–depth 10 git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
I'm not familiar with GitHub, I don't know if it supports sending
patches.
> Since I can’t reply to your comment and provide a clean modified patch at the same time, I will send you a modified patch later.
>
>>> + wan-amber {
>>> + label = "bcm53xx:amber:wan";
>>> + gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
>>> };
>>
>> It's unlikely both WAN LEDs (green & amber) are controlled by the same
>> GPIO (10). Please verify that.
>
> I did verify that following the "Adding new device support” guide from OpenWrt. It bothered me too since I have never noticed this thing on any other device. I think you can verify that on your Netgear R6250 since they are very similar. I will remove the wan-amber LED later to respond to your concern.
Well, please just double check what *really* happens when you set GPIO
10 to 0/1 value. Which LED does really turn on/off? Please don't just
randomly add/remove info from DT. Please verify it instead and provide
accurate changes.
> However, I haven't verified the vcc-gpio configuration for USB port and I just ported this feature from the dts file of Netgear R6250.
Then please kindly verify that. Please check if USB devices get detected
without this change. Please don't send random / untested changes.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2
@ 2021-12-10 9:31 ` Rafał Miłecki
0 siblings, 0 replies; 11+ messages in thread
From: Rafał Miłecki @ 2021-12-10 9:31 UTC (permalink / raw)
To: Lisa Hill
Cc: Rafał Miłecki, Florian Fainelli, Hauke Mehrtens,
Rob Herring, linux-arm-kernel, devicetree,
bcm-kernel-feedback-list
On 10.12.2021 10:18, Lisa Hill wrote:
> On Dec 10, 2021, at 15:39, Rafał Miłecki <zajec5@gmail.com> wrote:
>
>> One more comment on sending patches: please configure your e-mail client
>> to send text only (text/plain) without extra HTML version (text/html).
>>
>> If you can't configure your e-mail easily you can also try
>> "git send-email" command line tool.
>>
>> See:
>> https://www.kernel.org/doc/html/v5.15/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
>> https://www.kernel.org/doc/html/v5.15/process/email-clients.html
>>
>> Also see comments below.
>>
>
> Thanks for your help. I have noticed the #no-mime-no-links-no-compression-no-attachments-just-plain-text warning from The Linux Kernel documentation. However I sent a Safari-copied html mail by accident which was rejected by linux-arm-kernel@lists.infradead.org. Now I have configured my e-mail client to send plain text by default. Can you verify that on my reply?
It's perfect.
> Should I cc to Florian Fainelli <f.fainelli@gmail.com> and Hauke Mehrtens <hauke@hauke-m.de> any more? I have noticed your two e-mail clients from commits: rafal@milecki.pl and zajec5@gmail.com. Which one should I use to contact you? Should I cc to another?
Yes, please include Florian & Hauke.
Either of my addresses is fine.
>>> + };
>>> +
>>
>> No tabs in empty separator line please.
>>
>
> I forgot to remove tabs when I made this commit on Github. Sorry for that.
>
> The linux repo is too big for me to clone. I have to use the fork feature in Github if I want to use git diff to create the patch. That’s why I can’t use "git send-email” which is recommended by The Linux Kernel documentation. Do you have any idea how I can send you the patch directly from Github instead of a 3rd e-mail client?
You can limit amount of cloned data by using --depth. Maybe that will
help.
git clone -–depth 10 git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
I'm not familiar with GitHub, I don't know if it supports sending
patches.
> Since I can’t reply to your comment and provide a clean modified patch at the same time, I will send you a modified patch later.
>
>>> + wan-amber {
>>> + label = "bcm53xx:amber:wan";
>>> + gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
>>> };
>>
>> It's unlikely both WAN LEDs (green & amber) are controlled by the same
>> GPIO (10). Please verify that.
>
> I did verify that following the "Adding new device support” guide from OpenWrt. It bothered me too since I have never noticed this thing on any other device. I think you can verify that on your Netgear R6250 since they are very similar. I will remove the wan-amber LED later to respond to your concern.
Well, please just double check what *really* happens when you set GPIO
10 to 0/1 value. Which LED does really turn on/off? Please don't just
randomly add/remove info from DT. Please verify it instead and provide
accurate changes.
> However, I haven't verified the vcc-gpio configuration for USB port and I just ported this feature from the dts file of Netgear R6250.
Then please kindly verify that. Please check if USB devices get detected
without this change. Please don't send random / untested changes.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-12-16 21:58 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-11 8:53 [PATCH] ARM: dts: BCM5301X: Add USB GPIO and missing LEDs on Netgear R6300v2 Lisa Hill
2021-12-11 8:53 ` Lisa Hill
2021-12-16 21:56 ` kernel test robot
2021-12-16 21:56 ` kernel test robot
2021-12-16 21:56 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-12-10 6:53 Lisa Hill
2021-12-10 6:53 ` Lisa Hill
2021-12-10 7:39 ` Rafał Miłecki
2021-12-10 7:39 ` Rafał Miłecki
[not found] ` <C624909D-1513-4256-BCC1-50C7B43402CC@icloud.com>
2021-12-10 9:31 ` Rafał Miłecki
2021-12-10 9:31 ` Rafał Miłecki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.