* [PATCH] mmc: dw_mmc: clean up a debug message
@ 2021-12-17 15:03 Dan Carpenter
2021-12-20 10:40 ` Marten Lindahl
2021-12-21 13:03 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-12-17 15:03 UTC (permalink / raw)
To: Jaehoon Chung, Mårten Lindahl
Cc: Ulf Hansson, linux-mmc, kernel-janitors
The "0x" prefix is redundant when # flag is used. It prints "0x0x".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/mmc/host/dw_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index f2a14a434bef..bec4796283fe 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host,
tmout |= (tmp & 0xFFFFFF) << 8;
mci_writel(host, TMOUT, tmout);
- dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x",
+ dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x",
timeout_ns, tmout >> 8);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: clean up a debug message
2021-12-17 15:03 [PATCH] mmc: dw_mmc: clean up a debug message Dan Carpenter
@ 2021-12-20 10:40 ` Marten Lindahl
2021-12-21 13:03 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Marten Lindahl @ 2021-12-20 10:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jaehoon Chung, Mårten Lindahl, Ulf Hansson,
linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org
On Fri, Dec 17, 2021 at 04:03:48PM +0100, Dan Carpenter wrote:
> The "0x" prefix is redundant when # flag is used. It prints "0x0x".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index f2a14a434bef..bec4796283fe 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host,
> tmout |= (tmp & 0xFFFFFF) << 8;
>
> mci_writel(host, TMOUT, tmout);
> - dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x",
> + dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x",
> timeout_ns, tmout >> 8);
> }
>
> --
> 2.20.1
>
Reviewed-by: Mårten Lindahl <marten.lindahl@axis.com>
Kind regards
Mårten
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: clean up a debug message
2021-12-17 15:03 [PATCH] mmc: dw_mmc: clean up a debug message Dan Carpenter
2021-12-20 10:40 ` Marten Lindahl
@ 2021-12-21 13:03 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2021-12-21 13:03 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jaehoon Chung, Mårten Lindahl, linux-mmc, kernel-janitors
On Fri, 17 Dec 2021 at 16:04, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The "0x" prefix is redundant when # flag is used. It prints "0x0x".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index f2a14a434bef..bec4796283fe 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1307,7 +1307,7 @@ static void dw_mci_set_data_timeout(struct dw_mci *host,
> tmout |= (tmp & 0xFFFFFF) << 8;
>
> mci_writel(host, TMOUT, tmout);
> - dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: 0x%#08x",
> + dev_dbg(host->dev, "timeout_ns: %u => TMOUT[31:8]: %#08x",
> timeout_ns, tmout >> 8);
> }
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-21 13:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-17 15:03 [PATCH] mmc: dw_mmc: clean up a debug message Dan Carpenter
2021-12-20 10:40 ` Marten Lindahl
2021-12-21 13:03 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.