All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Andrej Picej <andrej.picej@norik.com>
Cc: support.opensource@diasemi.com, linux-watchdog@vger.kernel.org,
	wim@linux-watchdog.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	linux-arm-kernel@lists.infradead.org,
	cniedermaier@dh-electronics.com
Subject: Re: [PATCH v5 4/5] dt-bindings: watchdog: da9062: add watchdog timeout mode
Date: Mon, 20 Dec 2021 08:06:09 -0800	[thread overview]
Message-ID: <20211220160609.GA1379130@roeck-us.net> (raw)
In-Reply-To: <20211206064732.280375-4-andrej.picej@norik.com>

On Mon, Dec 06, 2021 at 07:47:31AM +0100, Andrej Picej wrote:
> Document the watchdog timeout mode property. If this property is used
> the user can select what happens on watchdog timeout. Set this property
> to 1 to enable SHUTDOWN (the device resets), set it to 0 and the device
> will go to POWERDOWN on watchdog timeout.
> 
> If this property is not set, don't touch the WATCHDOG_SD bit and leave
> the configuration to OTP. This way backward compatibility is not broken.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> Changes in v5:
>  - no changes
> 
> Changes in v4:
>  - no changes
> 
> Changes in v3:
>  - add note about using the default OTP setting if this DT binding is
>    not specified
> 
> Changes in v2:
>  - new patch, document new DT binding
> ---
>  Documentation/devicetree/bindings/watchdog/da9062-wdt.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt b/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt
> index 950e4fba8dbc..354314d854ef 100644
> --- a/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt
> @@ -10,6 +10,12 @@ Optional properties:
>  - dlg,use-sw-pm: Add this property to disable the watchdog during suspend.
>  	Only use this option if you can't use the watchdog automatic suspend
>  	function during a suspend (see register CONTROL_B).
> +- dlg,wdt-sd: Set what happens on watchdog timeout. If this bit is set the
> +	watchdog timeout triggers SHUTDOWN, if cleared the watchdog triggers
> +	POWERDOWN. Can be 0 or 1. Only use this option if you want to change the
> +	default chip's OTP setting for WATCHDOG_SD bit. If this property is NOT
> +	set the WATCHDOG_SD bit and on timeout watchdog behavior will match the
> +	chip's OTP settings.
>  
>  Example: DA9062
>  

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Andrej Picej <andrej.picej@norik.com>
Cc: support.opensource@diasemi.com, linux-watchdog@vger.kernel.org,
	wim@linux-watchdog.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	linux-arm-kernel@lists.infradead.org,
	cniedermaier@dh-electronics.com
Subject: Re: [PATCH v5 4/5] dt-bindings: watchdog: da9062: add watchdog timeout mode
Date: Mon, 20 Dec 2021 08:06:09 -0800	[thread overview]
Message-ID: <20211220160609.GA1379130@roeck-us.net> (raw)
In-Reply-To: <20211206064732.280375-4-andrej.picej@norik.com>

On Mon, Dec 06, 2021 at 07:47:31AM +0100, Andrej Picej wrote:
> Document the watchdog timeout mode property. If this property is used
> the user can select what happens on watchdog timeout. Set this property
> to 1 to enable SHUTDOWN (the device resets), set it to 0 and the device
> will go to POWERDOWN on watchdog timeout.
> 
> If this property is not set, don't touch the WATCHDOG_SD bit and leave
> the configuration to OTP. This way backward compatibility is not broken.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> Changes in v5:
>  - no changes
> 
> Changes in v4:
>  - no changes
> 
> Changes in v3:
>  - add note about using the default OTP setting if this DT binding is
>    not specified
> 
> Changes in v2:
>  - new patch, document new DT binding
> ---
>  Documentation/devicetree/bindings/watchdog/da9062-wdt.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt b/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt
> index 950e4fba8dbc..354314d854ef 100644
> --- a/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/da9062-wdt.txt
> @@ -10,6 +10,12 @@ Optional properties:
>  - dlg,use-sw-pm: Add this property to disable the watchdog during suspend.
>  	Only use this option if you can't use the watchdog automatic suspend
>  	function during a suspend (see register CONTROL_B).
> +- dlg,wdt-sd: Set what happens on watchdog timeout. If this bit is set the
> +	watchdog timeout triggers SHUTDOWN, if cleared the watchdog triggers
> +	POWERDOWN. Can be 0 or 1. Only use this option if you want to change the
> +	default chip's OTP setting for WATCHDOG_SD bit. If this property is NOT
> +	set the WATCHDOG_SD bit and on timeout watchdog behavior will match the
> +	chip's OTP settings.
>  
>  Example: DA9062
>  

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-12-20 16:06 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06  6:47 [PATCH v5 1/5] mfd: da9062: make register CONFIG_I writable Andrej Picej
2021-12-06  6:47 ` Andrej Picej
2021-12-06  6:47 ` [PATCH v5 2/5] mfd: da9061: " Andrej Picej
2021-12-06  6:47   ` Andrej Picej
2021-12-06  8:46   ` Christoph Niedermaier
2021-12-06  8:46     ` Christoph Niedermaier
2021-12-06 20:15   ` Adam Thomson
2021-12-06 20:15     ` Adam Thomson
2021-12-06  6:47 ` [PATCH v5 3/5] watchdog: da9062: reset board on watchdog timeout Andrej Picej
2021-12-06  6:47   ` Andrej Picej
2021-12-06  8:49   ` Christoph Niedermaier
2021-12-06 20:16   ` Adam Thomson
2021-12-06 20:16     ` Adam Thomson
2022-09-25 17:16   ` Guenter Roeck
2022-09-25 17:16     ` Guenter Roeck
2021-12-06  6:47 ` [PATCH v5 4/5] dt-bindings: watchdog: da9062: add watchdog timeout mode Andrej Picej
2021-12-06  6:47   ` Andrej Picej
2021-12-06 20:16   ` Adam Thomson
2021-12-06 20:16     ` Adam Thomson
2021-12-10 21:12   ` Rob Herring
2021-12-10 21:12     ` Rob Herring
2021-12-20 16:06   ` Guenter Roeck [this message]
2021-12-20 16:06     ` Guenter Roeck
2021-12-06  6:47 ` [PATCH v5 5/5] ARM: dts: imx6: phycore-som: set watchdog timeout mode to shutdown Andrej Picej
2021-12-06  6:47   ` Andrej Picej
2021-12-06 20:17   ` Adam Thomson
2021-12-06 20:17     ` Adam Thomson
2021-12-06 16:46 ` [PATCH v5 1/5] mfd: da9062: make register CONFIG_I writable Adam Thomson
2021-12-06 16:46   ` Adam Thomson
2021-12-06 17:11   ` Guenter Roeck
2021-12-06 17:11     ` Guenter Roeck
2021-12-06 20:13     ` Adam Thomson
2021-12-06 20:13       ` Adam Thomson
2022-04-11  9:06     ` Christoph Niedermaier
2022-04-11  9:06       ` Christoph Niedermaier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211220160609.GA1379130@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andrej.picej@norik.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.