All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Andrej Picej <andrej.picej@norik.com>,
	"support.opensource@diasemi.com" <support.opensource@diasemi.com>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v5 2/5] mfd: da9061: make register CONFIG_I writable
Date: Mon, 6 Dec 2021 08:46:52 +0000	[thread overview]
Message-ID: <9d9032c5e1da4a0f83b0d8eba9156d4c@dh-electronics.com> (raw)
In-Reply-To: <20211206064732.280375-2-andrej.picej@norik.com>

From: Andrej Picej
Sent: Monday, December 6, 2021 7:47 AM
> 
> Make the config register CONFIG_I writable to change the watchdog mode.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
> Chnages in v5:
>  - new patch, make CONFIG_I writable also for da9061 version
> ---
>  drivers/mfd/da9062-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index 7041ba53efb4..20e5ce2a2354 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -453,6 +453,7 @@ static const struct regmap_range
> da9061_aa_writeable_ranges[] = {
>         regmap_reg_range(DA9062AA_VBUCK1_B, DA9062AA_VBUCK4_B),
>         regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B),
>         regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B),
> +       regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I),
>         regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19),
>  };

Tested it on my DA9061:
- If I don't add anything to my device tree, the system freezes.
- With "dlg,wdt-sd = <1>;" in my devicetree the system restarts.
Thus it works on my system!

Tested-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>


Thanks and regards
Christoph

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Andrej Picej <andrej.picej@norik.com>,
	"support.opensource@diasemi.com" <support.opensource@diasemi.com>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Cc: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v5 2/5] mfd: da9061: make register CONFIG_I writable
Date: Mon, 6 Dec 2021 08:46:52 +0000	[thread overview]
Message-ID: <9d9032c5e1da4a0f83b0d8eba9156d4c@dh-electronics.com> (raw)
In-Reply-To: <20211206064732.280375-2-andrej.picej@norik.com>

From: Andrej Picej
Sent: Monday, December 6, 2021 7:47 AM
> 
> Make the config register CONFIG_I writable to change the watchdog mode.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
> Chnages in v5:
>  - new patch, make CONFIG_I writable also for da9061 version
> ---
>  drivers/mfd/da9062-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index 7041ba53efb4..20e5ce2a2354 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -453,6 +453,7 @@ static const struct regmap_range
> da9061_aa_writeable_ranges[] = {
>         regmap_reg_range(DA9062AA_VBUCK1_B, DA9062AA_VBUCK4_B),
>         regmap_reg_range(DA9062AA_VBUCK3_B, DA9062AA_VBUCK3_B),
>         regmap_reg_range(DA9062AA_VLDO1_B, DA9062AA_VLDO4_B),
> +       regmap_reg_range(DA9062AA_CONFIG_I, DA9062AA_CONFIG_I),
>         regmap_reg_range(DA9062AA_GP_ID_0, DA9062AA_GP_ID_19),
>  };

Tested it on my DA9061:
- If I don't add anything to my device tree, the system freezes.
- With "dlg,wdt-sd = <1>;" in my devicetree the system restarts.
Thus it works on my system!

Tested-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>


Thanks and regards
Christoph
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-06  8:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06  6:47 [PATCH v5 1/5] mfd: da9062: make register CONFIG_I writable Andrej Picej
2021-12-06  6:47 ` Andrej Picej
2021-12-06  6:47 ` [PATCH v5 2/5] mfd: da9061: " Andrej Picej
2021-12-06  6:47   ` Andrej Picej
2021-12-06  8:46   ` Christoph Niedermaier [this message]
2021-12-06  8:46     ` Christoph Niedermaier
2021-12-06 20:15   ` Adam Thomson
2021-12-06 20:15     ` Adam Thomson
2021-12-06  6:47 ` [PATCH v5 3/5] watchdog: da9062: reset board on watchdog timeout Andrej Picej
2021-12-06  6:47   ` Andrej Picej
2021-12-06  8:49   ` Christoph Niedermaier
2021-12-06 20:16   ` Adam Thomson
2021-12-06 20:16     ` Adam Thomson
2022-09-25 17:16   ` Guenter Roeck
2022-09-25 17:16     ` Guenter Roeck
2021-12-06  6:47 ` [PATCH v5 4/5] dt-bindings: watchdog: da9062: add watchdog timeout mode Andrej Picej
2021-12-06  6:47   ` Andrej Picej
2021-12-06 20:16   ` Adam Thomson
2021-12-06 20:16     ` Adam Thomson
2021-12-10 21:12   ` Rob Herring
2021-12-10 21:12     ` Rob Herring
2021-12-20 16:06   ` Guenter Roeck
2021-12-20 16:06     ` Guenter Roeck
2021-12-06  6:47 ` [PATCH v5 5/5] ARM: dts: imx6: phycore-som: set watchdog timeout mode to shutdown Andrej Picej
2021-12-06  6:47   ` Andrej Picej
2021-12-06 20:17   ` Adam Thomson
2021-12-06 20:17     ` Adam Thomson
2021-12-06 16:46 ` [PATCH v5 1/5] mfd: da9062: make register CONFIG_I writable Adam Thomson
2021-12-06 16:46   ` Adam Thomson
2021-12-06 17:11   ` Guenter Roeck
2021-12-06 17:11     ` Guenter Roeck
2021-12-06 20:13     ` Adam Thomson
2021-12-06 20:13       ` Adam Thomson
2022-04-11  9:06     ` Christoph Niedermaier
2022-04-11  9:06       ` Christoph Niedermaier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d9032c5e1da4a0f83b0d8eba9156d4c@dh-electronics.com \
    --to=cniedermaier@dh-electronics.com \
    --cc=andrej.picej@norik.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.