From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 16/23] wilc1000: switch tx queue to normal sk_buff entries
Date: Mon, 20 Dec 2021 21:20:30 +0800 [thread overview]
Message-ID: <202112202132.4ZJla6Ch-lkp@intel.com> (raw)
In-Reply-To: <20211218235404.3963475-17-davidm@egauge.net>
[-- Attachment #1: Type: text/plain, Size: 6180 bytes --]
Hi David,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kvalo-wireless-drivers-next/master]
[also build test WARNING on kvalo-wireless-drivers/master v5.16-rc6 next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-Mosberger-Tang/wilc1000-rework-tx-path-to-use-sk_buffs-throughout/20211219-075737
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20211220/202112202132.4ZJla6Ch-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e545dfdbd5420a8342c3a3bda03b6c9e7e108b7c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-Mosberger-Tang/wilc1000-rework-tx-path-to-use-sk_buffs-throughout/20211219-075737
git checkout e545dfdbd5420a8342c3a3bda03b6c9e7e108b7c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/net/wireless/microchip/wilc1000/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/wireless/microchip/wilc1000/wlan.c: In function 'wilc_wlan_cfg_apply_wid':
>> drivers/net/wireless/microchip/wilc1000/wlan.c:1243:63: warning: passing argument 1 of 'wilc_wlan_cfg_set_wid' makes pointer from integer without a cast [-Wint-conversion]
1243 | ret_size = wilc_wlan_cfg_set_wid(wilc->cfg_skb->tail, 0,
| ~~~~~~~~~~~~~^~~~~~
| |
| sk_buff_data_t {aka unsigned int}
In file included from drivers/net/wireless/microchip/wilc1000/netdev.h:19,
from drivers/net/wireless/microchip/wilc1000/cfg80211.h:9,
from drivers/net/wireless/microchip/wilc1000/wlan.c:10:
drivers/net/wireless/microchip/wilc1000/wlan_cfg.h:45:31: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'sk_buff_data_t' {aka 'unsigned int'}
45 | int wilc_wlan_cfg_set_wid(u8 *frame, u32 offset, u16 id, u8 *buf, int size);
| ~~~~^~~~~
>> drivers/net/wireless/microchip/wilc1000/wlan.c:1246:63: warning: passing argument 1 of 'wilc_wlan_cfg_get_wid' makes pointer from integer without a cast [-Wint-conversion]
1246 | ret_size = wilc_wlan_cfg_get_wid(wilc->cfg_skb->tail, 0, wid);
| ~~~~~~~~~~~~~^~~~~~
| |
| sk_buff_data_t {aka unsigned int}
In file included from drivers/net/wireless/microchip/wilc1000/netdev.h:19,
from drivers/net/wireless/microchip/wilc1000/cfg80211.h:9,
from drivers/net/wireless/microchip/wilc1000/wlan.c:10:
drivers/net/wireless/microchip/wilc1000/wlan_cfg.h:46:31: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'sk_buff_data_t' {aka 'unsigned int'}
46 | int wilc_wlan_cfg_get_wid(u8 *frame, u32 offset, u16 id);
| ~~~~^~~~~
vim +/wilc_wlan_cfg_set_wid +1243 drivers/net/wireless/microchip/wilc1000/wlan.c
1217
1218 /**
1219 * Add a WID set/query to the current config packet and optionally
1220 * submit the resulting packet to the chip and wait for its reply.
1221 * Returns 0 on failure, positive number on success.
1222 */
1223 static int wilc_wlan_cfg_apply_wid(struct wilc_vif *vif, int start, u16 wid,
1224 u8 *buffer, u32 buffer_size, int commit,
1225 u32 drv_handler, bool set)
1226 {
1227 int ret_size;
1228 struct wilc *wilc = vif->wilc;
1229
1230 mutex_lock(&wilc->cfg_cmd_lock);
1231
1232 if (start) {
1233 WARN_ON(wilc->cfg_skb);
1234 wilc->cfg_skb = alloc_cfg_skb(vif);
1235 if (!wilc->cfg_skb) {
1236 netdev_dbg(vif->ndev, "Failed to alloc cfg_skb");
1237 mutex_unlock(&wilc->cfg_cmd_lock);
1238 return 0;
1239 }
1240 }
1241
1242 if (set)
> 1243 ret_size = wilc_wlan_cfg_set_wid(wilc->cfg_skb->tail, 0,
1244 wid, buffer, buffer_size);
1245 else
> 1246 ret_size = wilc_wlan_cfg_get_wid(wilc->cfg_skb->tail, 0, wid);
1247 if (ret_size == 0)
1248 netdev_dbg(vif->ndev,
1249 "Failed to add WID 0x%x to %s cfg packet\n",
1250 wid, set ? "set" : "query");
1251
1252 skb_put(wilc->cfg_skb, ret_size);
1253
1254 if (!commit) {
1255 mutex_unlock(&wilc->cfg_cmd_lock);
1256 return ret_size;
1257 }
1258
1259 netdev_dbg(vif->ndev, "%s: %s seqno[%d]\n",
1260 __func__, set ? "set" : "get", wilc->cfg_seq_no);
1261
1262 if (wilc_wlan_cfg_commit(vif, set ? WILC_CFG_SET : WILC_CFG_QUERY,
1263 drv_handler))
1264 ret_size = 0;
1265
1266 if (!wait_for_completion_timeout(&wilc->cfg_event,
1267 WILC_CFG_PKTS_TIMEOUT)) {
1268 netdev_dbg(vif->ndev, "%s: Timed Out\n", __func__);
1269 ret_size = 0;
1270 }
1271
1272 wilc->cfg_seq_no = (wilc->cfg_seq_no + 1) % 256;
1273 mutex_unlock(&wilc->cfg_cmd_lock);
1274
1275 return ret_size;
1276 }
1277
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
prev parent reply other threads:[~2021-12-20 13:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 23:54 [PATCH 00/23] wilc1000: rework tx path to use sk_buffs throughout David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 07/23] wilc1000: increment tx_dropped stat counter on tx packet drop David Mosberger-Tang
2021-12-18 23:54 ` David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 04/23] wilc1000: factor common code in wilc_wlan_cfg_set() and wilc_wlan_cfg_get() David Mosberger-Tang
2021-12-21 1:42 ` kernel test robot
2021-12-18 23:54 ` [PATCH 01/23] wilc1000: don't hold txq_spinlock while initializing AC queue limits David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 06/23] wilc1000: move tx packet drop code into its own function David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 03/23] wilc1000: move receive-queue stats from txq to wilc structure David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 05/23] wilc1000: add wilc_wlan_tx_packet_done() function David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 02/23] wilc1000: switch txq_event from completion to waitqueue David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 21/23] wilc1000: declare read-only ac_preserve_ratio as static and const David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 19/23] wilc1000: don't tell the chip to go to sleep while copying tx packets David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 17/23] wilc1000: remove no longer used "vif" argument from init_txq_entry() David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 10/23] wilc1000: factor initialization of tx queue-specific packet fields David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 23/23] wilc1000: introduce symbolic names for two tx-related control bits David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 13/23] wilc1000: sanitize config packet sequence number management a bit David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 12/23] wilc1000: refactor wilc_wlan_cfg_commit() " David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 15/23] wilc1000: Add struct wilc_skb_tx_cb as an alias of struct txq_entry_t David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 20/23] wilc1000: eliminate "max_size_over" variable in fill_vmm_table David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 22/23] wilc1000: minor syntax cleanup David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 11/23] wilc1000: convert tqx_entries from "int" to "atomic_t" David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 14/23] wilc1000: if there is no tx packet, don't increment packets-sent counter David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 09/23] wilc1000: prepare wilc_wlan_tx_packet_done() for sk_buff changes David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 18/23] wilc1000: split huge tx handler into subfunctions David Mosberger-Tang
2021-12-20 14:38 ` kernel test robot
2021-12-18 23:54 ` [PATCH 08/23] wilc1000: fix management packet type inconsistency David Mosberger-Tang
2021-12-18 23:54 ` [PATCH 16/23] wilc1000: switch tx queue to normal sk_buff entries David Mosberger-Tang
2021-12-20 13:20 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112202132.4ZJla6Ch-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.