Re: [PATCH 04/23] wilc1000: factor common code in wilc_wlan_cfg_set() and wilc_wlan_cfg_get()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3916 bytes --]

Hi David,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kvalo-wireless-drivers-next/master]
[also build test WARNING on kvalo-wireless-drivers/master v5.16-rc6 next-20211220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/David-Mosberger-Tang/wilc1000-rework-tx-path-to-use-sk_buffs-throughout/20211219-075737
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20211221/202112210957.PA9D5JSi-lkp(a)intel.com/config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ce89fccdb132d59dcaa93ba855c5644a5e3b6df9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review David-Mosberger-Tang/wilc1000-rework-tx-path-to-use-sk_buffs-throughout/20211219-075737
        git checkout ce89fccdb132d59dcaa93ba855c5644a5e3b6df9
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/wireless/microchip/wilc1000/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/microchip/wilc1000/wlan.c:1280: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Add a WID set/query to the current config packet and optionally


vim +1280 drivers/net/wireless/microchip/wilc1000/wlan.c

  1278	
  1279	/**
> 1280	 * Add a WID set/query to the current config packet and optionally
  1281	 * submit the resulting packet to the chip and wait for its reply.
  1282	 * Returns 0 on failure, positive number on success.
  1283	 */
  1284	static int wilc_wlan_cfg_apply_wid(struct wilc_vif *vif, int start, u16 wid,
  1285					   u8 *buffer, u32 buffer_size, int commit,
  1286					   u32 drv_handler, bool set)
  1287	{
  1288		u32 offset;
  1289		int ret_size;
  1290		struct wilc *wilc = vif->wilc;
  1291	
  1292		mutex_lock(&wilc->cfg_cmd_lock);
  1293	
  1294		if (start)
  1295			wilc->cfg_frame_offset = 0;
  1296	
  1297		offset = wilc->cfg_frame_offset;
  1298		if (set)
  1299			ret_size = wilc_wlan_cfg_set_wid(wilc->cfg_frame.frame, offset,
  1300							 wid, buffer, buffer_size);
  1301		else
  1302			ret_size = wilc_wlan_cfg_get_wid(wilc->cfg_frame.frame, offset,
  1303							 wid);
  1304		offset += ret_size;
  1305		wilc->cfg_frame_offset = offset;
  1306	
  1307		if (!commit) {
  1308			mutex_unlock(&wilc->cfg_cmd_lock);
  1309			return ret_size;
  1310		}
  1311	
  1312		netdev_dbg(vif->ndev, "%s: %s seqno[%d]\n",
  1313			   __func__, set ? "set" : "get", wilc->cfg_seq_no);
  1314	
  1315		if (wilc_wlan_cfg_commit(vif, set ? WILC_CFG_SET : WILC_CFG_QUERY,
  1316					 drv_handler))
  1317			ret_size = 0;
  1318	
  1319		if (!wait_for_completion_timeout(&wilc->cfg_event,
  1320						 WILC_CFG_PKTS_TIMEOUT)) {
  1321			netdev_dbg(vif->ndev, "%s: Timed Out\n", __func__);
  1322			ret_size = 0;
  1323		}
  1324	
  1325		wilc->cfg_frame_offset = 0;
  1326		wilc->cfg_seq_no += 1;
  1327		mutex_unlock(&wilc->cfg_cmd_lock);
  1328	
  1329		return ret_size;
  1330	}
  1331	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org