All of lore.kernel.org
 help / color / mirror / Atom feed
From: <miles.chen@mediatek.com>
To: <matthias.bgg@gmail.com>
Cc: <airlied@linux.ie>, <chunkuang.hu@kernel.org>, <daniel@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <miles.chen@mediatek.com>,
	<p.zabel@pengutronix.de>
Subject: Re: [PATCH] drm/mediatek: Fix unused-but-set variable warning
Date: Thu, 30 Dec 2021 14:56:16 +0800	[thread overview]
Message-ID: <20211230065616.32308-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <fcaccc97-e920-08eb-ec3f-4c4b11ea8925@gmail.com>

>You are right, in both cases the bit is set, but the funciton does not do what 
>it is supposed to do.
>Will just clear all bits of the mask.
>
>Without your patch, we will just write the val to the register and don't care 
>what the register value was before that.
>
>We should somehow mention that in the commit message, as it's not only about a 
>not used variable, it actually has an influence on the value we write(-back) to 
>the register.

thanks for the comment. I understand that it's not only about a not used
variable. I talked to our hdmi experts and they think mtk_cec_mask() should
write tmp instead of write val to the register.

I will mention this in the commit message and submit next patch.

Happy new year!

Miles

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: <miles.chen@mediatek.com>
To: <matthias.bgg@gmail.com>
Cc: <airlied@linux.ie>, <chunkuang.hu@kernel.org>, <daniel@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <miles.chen@mediatek.com>,
	<p.zabel@pengutronix.de>
Subject: Re: [PATCH] drm/mediatek: Fix unused-but-set variable warning
Date: Thu, 30 Dec 2021 14:56:16 +0800	[thread overview]
Message-ID: <20211230065616.32308-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <fcaccc97-e920-08eb-ec3f-4c4b11ea8925@gmail.com>

>You are right, in both cases the bit is set, but the funciton does not do what 
>it is supposed to do.
>Will just clear all bits of the mask.
>
>Without your patch, we will just write the val to the register and don't care 
>what the register value was before that.
>
>We should somehow mention that in the commit message, as it's not only about a 
>not used variable, it actually has an influence on the value we write(-back) to 
>the register.

thanks for the comment. I understand that it's not only about a not used
variable. I talked to our hdmi experts and they think mtk_cec_mask() should
write tmp instead of write val to the register.

I will mention this in the commit message and submit next patch.

Happy new year!

Miles

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: <miles.chen@mediatek.com>
To: <matthias.bgg@gmail.com>
Cc: chunkuang.hu@kernel.org, airlied@linux.ie,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	miles.chen@mediatek.com, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/mediatek: Fix unused-but-set variable warning
Date: Thu, 30 Dec 2021 14:56:16 +0800	[thread overview]
Message-ID: <20211230065616.32308-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <fcaccc97-e920-08eb-ec3f-4c4b11ea8925@gmail.com>

>You are right, in both cases the bit is set, but the funciton does not do what 
>it is supposed to do.
>Will just clear all bits of the mask.
>
>Without your patch, we will just write the val to the register and don't care 
>what the register value was before that.
>
>We should somehow mention that in the commit message, as it's not only about a 
>not used variable, it actually has an influence on the value we write(-back) to 
>the register.

thanks for the comment. I understand that it's not only about a not used
variable. I talked to our hdmi experts and they think mtk_cec_mask() should
write tmp instead of write val to the register.

I will mention this in the commit message and submit next patch.

Happy new year!

Miles

WARNING: multiple messages have this Message-ID (diff)
From: <miles.chen@mediatek.com>
To: <matthias.bgg@gmail.com>
Cc: <airlied@linux.ie>, <chunkuang.hu@kernel.org>, <daniel@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <miles.chen@mediatek.com>,
	<p.zabel@pengutronix.de>
Subject: Re: [PATCH] drm/mediatek: Fix unused-but-set variable warning
Date: Thu, 30 Dec 2021 14:56:16 +0800	[thread overview]
Message-ID: <20211230065616.32308-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <fcaccc97-e920-08eb-ec3f-4c4b11ea8925@gmail.com>

>You are right, in both cases the bit is set, but the funciton does not do what 
>it is supposed to do.
>Will just clear all bits of the mask.
>
>Without your patch, we will just write the val to the register and don't care 
>what the register value was before that.
>
>We should somehow mention that in the commit message, as it's not only about a 
>not used variable, it actually has an influence on the value we write(-back) to 
>the register.

thanks for the comment. I understand that it's not only about a not used
variable. I talked to our hdmi experts and they think mtk_cec_mask() should
write tmp instead of write val to the register.

I will mention this in the commit message and submit next patch.

Happy new year!

Miles

  parent reply	other threads:[~2021-12-30  6:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-28  9:25 [PATCH] drm/mediatek: Fix unused-but-set variable warning Miles Chen
2021-12-28  9:25 ` Miles Chen
2021-12-28  9:25 ` Miles Chen
2021-12-28  9:25 ` Miles Chen
2021-12-28 14:53 ` Matthias Brugger
2021-12-28 14:53   ` Matthias Brugger
2021-12-28 14:53   ` Matthias Brugger
2021-12-28 14:53   ` Matthias Brugger
2021-12-29  3:04   ` miles.chen
2021-12-29  3:04     ` miles.chen
2021-12-29  3:04     ` miles.chen
2021-12-29  3:04     ` miles.chen
2021-12-29 14:25     ` Matthias Brugger
2021-12-29 14:25       ` Matthias Brugger
2021-12-29 14:25       ` Matthias Brugger
2021-12-29 14:25       ` Matthias Brugger
2021-12-30  6:56   ` miles.chen [this message]
2021-12-30  6:56     ` miles.chen
2021-12-30  6:56     ` miles.chen
2021-12-30  6:56     ` miles.chen
2022-01-02 23:46   ` [PATCH v3] " miles.chen
2022-01-02 23:46     ` miles.chen
2022-01-02 23:46     ` miles.chen
2022-01-02 23:46     ` miles.chen
2022-01-07  1:40     ` Miles Chen
2022-01-07  1:40       ` Miles Chen
2022-01-07  1:40       ` Miles Chen
2022-01-07  1:40       ` Miles Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211230065616.32308-1-miles.chen@mediatek.com \
    --to=miles.chen@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.