From: Miles Chen <miles.chen@mediatek.com>
To: <matthias.bgg@gmail.com>
Cc: <airlied@linux.ie>, <chunkuang.hu@kernel.org>, <daniel@ffwll.ch>,
<dri-devel@lists.freedesktop.org>, <jie.qiu@mediatek.com>,
<junzhi.zhao@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <llvm@lists.linux.dev>,
<p.zabel@pengutronix.de>
Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning
Date: Fri, 7 Jan 2022 09:40:46 +0800 [thread overview]
Message-ID: <20220107014046.30492-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220102234633.31709-1-miles.chen@mediatek.com>
Hi Matthias,
>> I'm still not happy with the commit subject, I think it is misleading. Clang
>> only helped to find the bug, but the we are fixing something else, that's not
>> just a clang warning. But I don't want to nit-pick too much so:
>>
>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> thanks. I think you are right.
> I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the
> clang part and submit patch v4.
I posted patch v4 https://lore.kernel.org/linux-mediatek/20220103054706.8072-1-miles.chen@mediatek.com/
without your reviewed-by tag.
Would you mind taking a look at the patch?
Miles
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <matthias.bgg@gmail.com>
Cc: <airlied@linux.ie>, <chunkuang.hu@kernel.org>, <daniel@ffwll.ch>,
<dri-devel@lists.freedesktop.org>, <jie.qiu@mediatek.com>,
<junzhi.zhao@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <llvm@lists.linux.dev>,
<p.zabel@pengutronix.de>
Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning
Date: Fri, 7 Jan 2022 09:40:46 +0800 [thread overview]
Message-ID: <20220107014046.30492-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220102234633.31709-1-miles.chen@mediatek.com>
Hi Matthias,
>> I'm still not happy with the commit subject, I think it is misleading. Clang
>> only helped to find the bug, but the we are fixing something else, that's not
>> just a clang warning. But I don't want to nit-pick too much so:
>>
>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> thanks. I think you are right.
> I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the
> clang part and submit patch v4.
I posted patch v4 https://lore.kernel.org/linux-mediatek/20220103054706.8072-1-miles.chen@mediatek.com/
without your reviewed-by tag.
Would you mind taking a look at the patch?
Miles
WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <matthias.bgg@gmail.com>
Cc: <airlied@linux.ie>, <chunkuang.hu@kernel.org>, <daniel@ffwll.ch>,
<dri-devel@lists.freedesktop.org>, <jie.qiu@mediatek.com>,
<junzhi.zhao@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <llvm@lists.linux.dev>,
<p.zabel@pengutronix.de>
Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning
Date: Fri, 7 Jan 2022 09:40:46 +0800 [thread overview]
Message-ID: <20220107014046.30492-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220102234633.31709-1-miles.chen@mediatek.com>
Hi Matthias,
>> I'm still not happy with the commit subject, I think it is misleading. Clang
>> only helped to find the bug, but the we are fixing something else, that's not
>> just a clang warning. But I don't want to nit-pick too much so:
>>
>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> thanks. I think you are right.
> I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the
> clang part and submit patch v4.
I posted patch v4 https://lore.kernel.org/linux-mediatek/20220103054706.8072-1-miles.chen@mediatek.com/
without your reviewed-by tag.
Would you mind taking a look at the patch?
Miles
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <matthias.bgg@gmail.com>
Cc: chunkuang.hu@kernel.org, junzhi.zhao@mediatek.com,
jie.qiu@mediatek.com, airlied@linux.ie, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning
Date: Fri, 7 Jan 2022 09:40:46 +0800 [thread overview]
Message-ID: <20220107014046.30492-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220102234633.31709-1-miles.chen@mediatek.com>
Hi Matthias,
>> I'm still not happy with the commit subject, I think it is misleading. Clang
>> only helped to find the bug, but the we are fixing something else, that's not
>> just a clang warning. But I don't want to nit-pick too much so:
>>
>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> thanks. I think you are right.
> I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the
> clang part and submit patch v4.
I posted patch v4 https://lore.kernel.org/linux-mediatek/20220103054706.8072-1-miles.chen@mediatek.com/
without your reviewed-by tag.
Would you mind taking a look at the patch?
Miles
next prev parent reply other threads:[~2022-01-07 1:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 9:25 [PATCH] drm/mediatek: Fix unused-but-set variable warning Miles Chen
2021-12-28 9:25 ` Miles Chen
2021-12-28 9:25 ` Miles Chen
2021-12-28 9:25 ` Miles Chen
2021-12-28 14:53 ` Matthias Brugger
2021-12-28 14:53 ` Matthias Brugger
2021-12-28 14:53 ` Matthias Brugger
2021-12-28 14:53 ` Matthias Brugger
2021-12-29 3:04 ` miles.chen
2021-12-29 3:04 ` miles.chen
2021-12-29 3:04 ` miles.chen
2021-12-29 3:04 ` miles.chen
2021-12-29 14:25 ` Matthias Brugger
2021-12-29 14:25 ` Matthias Brugger
2021-12-29 14:25 ` Matthias Brugger
2021-12-29 14:25 ` Matthias Brugger
2021-12-30 6:56 ` miles.chen
2021-12-30 6:56 ` miles.chen
2021-12-30 6:56 ` miles.chen
2021-12-30 6:56 ` miles.chen
2022-01-02 23:46 ` [PATCH v3] " miles.chen
2022-01-02 23:46 ` miles.chen
2022-01-02 23:46 ` miles.chen
2022-01-02 23:46 ` miles.chen
2022-01-07 1:40 ` Miles Chen [this message]
2022-01-07 1:40 ` Miles Chen
2022-01-07 1:40 ` Miles Chen
2022-01-07 1:40 ` Miles Chen
-- strict thread matches above, loose matches on Subject: below --
2021-12-30 9:36 Miles Chen
2021-12-30 9:36 ` Miles Chen
2021-12-30 9:36 ` Miles Chen
2021-12-30 9:36 ` Miles Chen
2021-12-30 12:29 ` Matthias Brugger
2021-12-30 12:29 ` Matthias Brugger
2021-12-30 12:29 ` Matthias Brugger
2021-12-30 12:29 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107014046.30492-1-miles.chen@mediatek.com \
--to=miles.chen@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jie.qiu@mediatek.com \
--cc=junzhi.zhao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.