From: kernel test robot <lkp@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, Jessica Yu <jeyu@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Miroslav Benes <mbenes@suse.cz>
Subject: kernel/module.c:4478:14: warning: variable 'exit' set but not used
Date: Sun, 2 Jan 2022 06:58:00 +0800 [thread overview]
Message-ID: <202201020600.rl5oKvlD-lkp@intel.com> (raw)
Hi Arnd,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 278218f6778bc7d6f8b67199446c56cec7ebb841
commit: 0d67e332e6df72f43eaa21228daa3a79e23093f3 module: fix clang CFI with MODULE_UNLOAD=n
date: 3 months ago
config: arm64-randconfig-r022-20220101 (https://download.01.org/0day-ci/archive/20220102/202201020600.rl5oKvlD-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7cd109b92c72855937273a6c8ab19016fbe27d33)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0d67e332e6df72f43eaa21228daa3a79e23093f3
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 0d67e332e6df72f43eaa21228daa3a79e23093f3
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/module.c:4478:14: warning: variable 'exit' set but not used [-Wunused-but-set-variable]
exitcall_t *exit;
^
1 warning generated.
vim +/exit +4478 kernel/module.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 4473
cf68fffb66d60d Sami Tolvanen 2021-04-08 4474 static void cfi_init(struct module *mod)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4475 {
cf68fffb66d60d Sami Tolvanen 2021-04-08 4476 #ifdef CONFIG_CFI_CLANG
cf68fffb66d60d Sami Tolvanen 2021-04-08 4477 initcall_t *init;
cf68fffb66d60d Sami Tolvanen 2021-04-08 @4478 exitcall_t *exit;
cf68fffb66d60d Sami Tolvanen 2021-04-08 4479
cf68fffb66d60d Sami Tolvanen 2021-04-08 4480 rcu_read_lock_sched();
cf68fffb66d60d Sami Tolvanen 2021-04-08 4481 mod->cfi_check = (cfi_check_fn)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4482 find_kallsyms_symbol_value(mod, "__cfi_check");
cf68fffb66d60d Sami Tolvanen 2021-04-08 4483 init = (initcall_t *)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4484 find_kallsyms_symbol_value(mod, "__cfi_jt_init_module");
cf68fffb66d60d Sami Tolvanen 2021-04-08 4485 exit = (exitcall_t *)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4486 find_kallsyms_symbol_value(mod, "__cfi_jt_cleanup_module");
cf68fffb66d60d Sami Tolvanen 2021-04-08 4487 rcu_read_unlock_sched();
cf68fffb66d60d Sami Tolvanen 2021-04-08 4488
cf68fffb66d60d Sami Tolvanen 2021-04-08 4489 /* Fix init/exit functions to point to the CFI jump table */
cf68fffb66d60d Sami Tolvanen 2021-04-08 4490 if (init)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4491 mod->init = *init;
0d67e332e6df72 Arnd Bergmann 2021-09-27 4492 #ifdef CONFIG_MODULE_UNLOAD
cf68fffb66d60d Sami Tolvanen 2021-04-08 4493 if (exit)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4494 mod->exit = *exit;
0d67e332e6df72 Arnd Bergmann 2021-09-27 4495 #endif
cf68fffb66d60d Sami Tolvanen 2021-04-08 4496
cf68fffb66d60d Sami Tolvanen 2021-04-08 4497 cfi_module_add(mod, module_addr_min);
cf68fffb66d60d Sami Tolvanen 2021-04-08 4498 #endif
cf68fffb66d60d Sami Tolvanen 2021-04-08 4499 }
cf68fffb66d60d Sami Tolvanen 2021-04-08 4500
:::::: The code at line 4478 was first introduced by commit
:::::: cf68fffb66d60d96209446bfc4a15291dc5a5d41 add support for Clang CFI
:::::: TO: Sami Tolvanen <samitolvanen@google.com>
:::::: CC: Kees Cook <keescook@chromium.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: kernel/module.c:4478:14: warning: variable 'exit' set but not used
Date: Sun, 02 Jan 2022 06:58:00 +0800 [thread overview]
Message-ID: <202201020600.rl5oKvlD-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4086 bytes --]
Hi Arnd,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 278218f6778bc7d6f8b67199446c56cec7ebb841
commit: 0d67e332e6df72f43eaa21228daa3a79e23093f3 module: fix clang CFI with MODULE_UNLOAD=n
date: 3 months ago
config: arm64-randconfig-r022-20220101 (https://download.01.org/0day-ci/archive/20220102/202201020600.rl5oKvlD-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7cd109b92c72855937273a6c8ab19016fbe27d33)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0d67e332e6df72f43eaa21228daa3a79e23093f3
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 0d67e332e6df72f43eaa21228daa3a79e23093f3
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/module.c:4478:14: warning: variable 'exit' set but not used [-Wunused-but-set-variable]
exitcall_t *exit;
^
1 warning generated.
vim +/exit +4478 kernel/module.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 4473
cf68fffb66d60d Sami Tolvanen 2021-04-08 4474 static void cfi_init(struct module *mod)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4475 {
cf68fffb66d60d Sami Tolvanen 2021-04-08 4476 #ifdef CONFIG_CFI_CLANG
cf68fffb66d60d Sami Tolvanen 2021-04-08 4477 initcall_t *init;
cf68fffb66d60d Sami Tolvanen 2021-04-08 @4478 exitcall_t *exit;
cf68fffb66d60d Sami Tolvanen 2021-04-08 4479
cf68fffb66d60d Sami Tolvanen 2021-04-08 4480 rcu_read_lock_sched();
cf68fffb66d60d Sami Tolvanen 2021-04-08 4481 mod->cfi_check = (cfi_check_fn)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4482 find_kallsyms_symbol_value(mod, "__cfi_check");
cf68fffb66d60d Sami Tolvanen 2021-04-08 4483 init = (initcall_t *)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4484 find_kallsyms_symbol_value(mod, "__cfi_jt_init_module");
cf68fffb66d60d Sami Tolvanen 2021-04-08 4485 exit = (exitcall_t *)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4486 find_kallsyms_symbol_value(mod, "__cfi_jt_cleanup_module");
cf68fffb66d60d Sami Tolvanen 2021-04-08 4487 rcu_read_unlock_sched();
cf68fffb66d60d Sami Tolvanen 2021-04-08 4488
cf68fffb66d60d Sami Tolvanen 2021-04-08 4489 /* Fix init/exit functions to point to the CFI jump table */
cf68fffb66d60d Sami Tolvanen 2021-04-08 4490 if (init)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4491 mod->init = *init;
0d67e332e6df72 Arnd Bergmann 2021-09-27 4492 #ifdef CONFIG_MODULE_UNLOAD
cf68fffb66d60d Sami Tolvanen 2021-04-08 4493 if (exit)
cf68fffb66d60d Sami Tolvanen 2021-04-08 4494 mod->exit = *exit;
0d67e332e6df72 Arnd Bergmann 2021-09-27 4495 #endif
cf68fffb66d60d Sami Tolvanen 2021-04-08 4496
cf68fffb66d60d Sami Tolvanen 2021-04-08 4497 cfi_module_add(mod, module_addr_min);
cf68fffb66d60d Sami Tolvanen 2021-04-08 4498 #endif
cf68fffb66d60d Sami Tolvanen 2021-04-08 4499 }
cf68fffb66d60d Sami Tolvanen 2021-04-08 4500
:::::: The code at line 4478 was first introduced by commit
:::::: cf68fffb66d60d96209446bfc4a15291dc5a5d41 add support for Clang CFI
:::::: TO: Sami Tolvanen <samitolvanen@google.com>
:::::: CC: Kees Cook <keescook@chromium.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2022-01-01 22:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 22:58 kernel test robot [this message]
2022-01-01 22:58 ` kernel/module.c:4478:14: warning: variable 'exit' set but not used kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-02-28 6:09 kernel test robot
2022-01-04 20:09 kernel test robot
2022-01-04 20:09 ` kernel test robot
2021-11-26 1:55 kernel test robot
2021-11-26 1:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201020600.rl5oKvlD-lkp@intel.com \
--to=lkp@intel.com \
--cc=arnd@arndb.de \
--cc=jeyu@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mbenes@suse.cz \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.