From: Stephen Boyd <sboyd@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Vladimir Vid" <vladimir.vid@sartura.hr>,
"Marek Behún" <kabel@kernel.org>,
linux-clk@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock
Date: Sat, 15 Jan 2022 00:02:11 -0800 [thread overview]
Message-ID: <20220115080213.0CCAFC36AE3@smtp.kernel.org> (raw)
In-Reply-To: <20211016064210.7ahqfqcvf66wtt66@pali>
Quoting Pali Rohár (2021-10-15 23:42:10)
>
> If I was designing this driver and DTS bindings I would have choose
> something like this:
>
> uart@0x12000 {
Drop the 0x
> reg = <0x12000 0x18>, <0x12200 0x30>;
> clock-controller {
> ...
> };
Drop this node and put whatever properties are inside into the parent
node.
> serial1 {
> ...
> status = "disabled";
> };
> serial2 {
> ...
> status = "disabled";
> };
> };
>
> Meaning that 0x12000 node would be 3 subnodes and all registers would be
> defined in top level nodes and would be handled by one driver.
>
> This is really how hardware block looks like. But it is not backward
> compatible...
Sounds good to me. I presume we need the serial child nodes so we can
reference them from the stdout-path?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Vladimir Vid" <vladimir.vid@sartura.hr>,
"Marek Behún" <kabel@kernel.org>,
linux-clk@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock
Date: Sat, 15 Jan 2022 00:02:11 -0800 [thread overview]
Message-ID: <20220115080213.0CCAFC36AE3@smtp.kernel.org> (raw)
In-Reply-To: <20211016064210.7ahqfqcvf66wtt66@pali>
Quoting Pali Rohár (2021-10-15 23:42:10)
>
> If I was designing this driver and DTS bindings I would have choose
> something like this:
>
> uart@0x12000 {
Drop the 0x
> reg = <0x12000 0x18>, <0x12200 0x30>;
> clock-controller {
> ...
> };
Drop this node and put whatever properties are inside into the parent
node.
> serial1 {
> ...
> status = "disabled";
> };
> serial2 {
> ...
> status = "disabled";
> };
> };
>
> Meaning that 0x12000 node would be 3 subnodes and all registers would be
> defined in top level nodes and would be handled by one driver.
>
> This is really how hardware block looks like. But it is not backward
> compatible...
Sounds good to me. I presume we need the serial child nodes so we can
reference them from the stdout-path?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-15 8:02 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 9:58 [PATCH v7 0/6] serial: mvebu-uart: Support for higher baudrates Pali Rohár
2021-09-30 9:58 ` Pali Rohár
2021-09-30 9:58 ` [PATCH v7 1/6] math64: New DIV_U64_ROUND_CLOSEST helper Pali Rohár
2021-09-30 9:58 ` Pali Rohár
2021-09-30 9:58 ` [PATCH v7 2/6] serial: mvebu-uart: implement UART clock driver for configuring UART base clock Pali Rohár
2021-09-30 9:58 ` Pali Rohár
2021-10-13 14:16 ` Gregory CLEMENT
2021-10-13 14:16 ` Gregory CLEMENT
2021-10-13 14:21 ` Pali Rohár
2021-10-13 14:21 ` Pali Rohár
2021-09-30 9:58 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Pali Rohár
2021-09-30 9:58 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Pali Rohár
2021-10-06 21:07 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Rob Herring
2021-10-06 21:07 ` Rob Herring
2021-10-15 0:13 ` Stephen Boyd
2021-10-15 0:13 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Stephen Boyd
2021-10-15 9:09 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Pali Rohár
2021-10-15 9:09 ` Pali Rohár
2021-10-15 9:37 ` Pali Rohár
2021-10-15 9:37 ` Pali Rohár
2021-10-15 21:55 ` Stephen Boyd
2021-10-15 21:55 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Stephen Boyd
2021-10-15 22:08 ` Mark Kettenis
2021-10-15 22:08 ` Mark Kettenis
2021-10-16 6:42 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Pali Rohár
2021-10-16 6:42 ` Pali Rohár
2022-01-15 8:02 ` Stephen Boyd [this message]
2022-01-15 8:02 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Stephen Boyd
2022-01-15 11:50 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Pali Rohár
2022-01-15 11:50 ` Pali Rohár
2022-01-15 12:05 ` Marek Behún
2022-01-15 12:05 ` Marek Behún
2022-01-15 12:26 ` Pali Rohár
2022-01-15 12:26 ` Pali Rohár
2022-01-19 23:16 ` Stephen Boyd
2022-01-19 23:16 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Stephen Boyd
2022-01-20 0:06 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Pali Rohár
2022-01-20 0:06 ` Pali Rohár
2022-01-20 6:01 ` Stephen Boyd
2022-01-20 6:01 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Stephen Boyd
2022-01-20 9:26 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock Pali Rohár
2022-01-20 9:26 ` Pali Rohár
2022-01-25 20:40 ` Stephen Boyd
2022-01-25 20:40 ` [PATCH v7 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell, armada-3700-uart-clock Stephen Boyd
2021-09-30 9:58 ` [PATCH v7 4/6] dt-bindings: mvebu-uart: update information about UART clock Pali Rohár
2021-09-30 9:58 ` Pali Rohár
2021-10-06 21:11 ` Rob Herring
2021-10-06 21:11 ` Rob Herring
2021-09-30 9:58 ` [PATCH v7 5/6] arm64: dts: marvell: armada-37xx: add device node for UART clock and use it Pali Rohár
2021-09-30 9:58 ` Pali Rohár
2021-10-13 14:13 ` Gregory CLEMENT
2021-10-13 14:13 ` Gregory CLEMENT
2021-10-13 14:19 ` Pali Rohár
2021-10-13 14:19 ` Pali Rohár
2021-09-30 9:58 ` [PATCH v7 6/6] serial: mvebu-uart: implement support for baudrates higher than 230400 Pali Rohár
2021-09-30 9:58 ` Pali Rohár
2021-10-01 12:11 ` [PATCH v7 0/6] serial: mvebu-uart: Support for higher baudrates Pali Rohár
2021-10-01 12:11 ` Pali Rohár
2021-11-03 21:42 ` Pali Rohár
2021-11-03 21:42 ` Pali Rohár
2021-12-17 17:23 ` Gregory CLEMENT
2021-12-17 17:23 ` Gregory CLEMENT
2022-01-14 10:51 ` Pali Rohár
2022-01-14 10:51 ` Pali Rohár
2022-01-14 22:56 ` Stephen Boyd
2022-01-14 22:56 ` Stephen Boyd
2022-01-14 23:05 ` Pali Rohár
2022-01-14 23:05 ` Pali Rohár
2022-01-14 23:16 ` Stephen Boyd
2022-01-14 23:16 ` Stephen Boyd
2022-01-14 23:20 ` Pali Rohár
2022-01-14 23:20 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220115080213.0CCAFC36AE3@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=kabel@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=vladimir.vid@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.