From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kbuild@lists.01.org, Jiri Slaby <jirislaby@kernel.org>,
lkp@intel.com, kbuild-all@lists.01.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Mike Skoog <mskoog@endruntechnologies.com>,
Mike Korreng <mkorreng@endruntechnologies.com>,
info@endruntechnologies.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] serial: 8250: Add proper clock handling for OxSemi PCIe devices
Date: Thu, 17 Feb 2022 16:23:52 +0300 [thread overview]
Message-ID: <20220217132352.GC2467@kadam> (raw)
In-Reply-To: <alpine.DEB.2.21.2202171009440.34636@angie.orcam.me.uk>
On Thu, Feb 17, 2022 at 12:05:58PM +0000, Maciej W. Rozycki wrote:
> On Thu, 17 Feb 2022, Dan Carpenter wrote:
>
> > url: https://github.com/0day-ci/linux/commits/Maciej-W-Rozycki/serial-8250-Fixes-for-Oxford-Semiconductor-950-UARTs/20220212-164255
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> > config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220213/202202130027.ZKBCgtm5-lkp@intel.com/config )
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > New smatch warnings:
> > drivers/tty/serial/8250/8250_pci.c:1171 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'tcr'.
> > drivers/tty/serial/8250/8250_pci.c:1172 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'quot'.
> > drivers/tty/serial/8250/8250_pci.c:1180 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'cpr'.
>
> These variables do get assigned to in the first iteration of the loop,
> because the deviation calculated (`srem') is normalised to the range of
> [0,spre/2] and that divided by the original divisor (`spre') always works
> out at within [0,0.5], so `squot' will be within [0,32768]. I guess the
> static analyser is too dumb to figure it out, so I'll see how to paper it
> over unless someone has a better proposal.
These emails are a one time email so it's okay to ignore them if you
want.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v3 2/2] serial: 8250: Add proper clock handling for OxSemi PCIe devices
Date: Thu, 17 Feb 2022 16:23:52 +0300 [thread overview]
Message-ID: <20220217132352.GC2467@kadam> (raw)
In-Reply-To: <alpine.DEB.2.21.2202171009440.34636@angie.orcam.me.uk>
[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]
On Thu, Feb 17, 2022 at 12:05:58PM +0000, Maciej W. Rozycki wrote:
> On Thu, 17 Feb 2022, Dan Carpenter wrote:
>
> > url: https://github.com/0day-ci/linux/commits/Maciej-W-Rozycki/serial-8250-Fixes-for-Oxford-Semiconductor-950-UARTs/20220212-164255
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> > config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220213/202202130027.ZKBCgtm5-lkp(a)intel.com/config )
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > New smatch warnings:
> > drivers/tty/serial/8250/8250_pci.c:1171 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'tcr'.
> > drivers/tty/serial/8250/8250_pci.c:1172 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'quot'.
> > drivers/tty/serial/8250/8250_pci.c:1180 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'cpr'.
>
> These variables do get assigned to in the first iteration of the loop,
> because the deviation calculated (`srem') is normalised to the range of
> [0,spre/2] and that divided by the original divisor (`spre') always works
> out at within [0,0.5], so `squot' will be within [0,32768]. I guess the
> static analyser is too dumb to figure it out, so I'll see how to paper it
> over unless someone has a better proposal.
These emails are a one time email so it's okay to ignore them if you
want.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 2/2] serial: 8250: Add proper clock handling for OxSemi PCIe devices
Date: Thu, 17 Feb 2022 16:23:52 +0300 [thread overview]
Message-ID: <20220217132352.GC2467@kadam> (raw)
In-Reply-To: <alpine.DEB.2.21.2202171009440.34636@angie.orcam.me.uk>
[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]
On Thu, Feb 17, 2022 at 12:05:58PM +0000, Maciej W. Rozycki wrote:
> On Thu, 17 Feb 2022, Dan Carpenter wrote:
>
> > url: https://github.com/0day-ci/linux/commits/Maciej-W-Rozycki/serial-8250-Fixes-for-Oxford-Semiconductor-950-UARTs/20220212-164255
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> > config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220213/202202130027.ZKBCgtm5-lkp(a)intel.com/config )
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > New smatch warnings:
> > drivers/tty/serial/8250/8250_pci.c:1171 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'tcr'.
> > drivers/tty/serial/8250/8250_pci.c:1172 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'quot'.
> > drivers/tty/serial/8250/8250_pci.c:1180 pci_oxsemi_tornado_get_divisor() error: uninitialized symbol 'cpr'.
>
> These variables do get assigned to in the first iteration of the loop,
> because the deviation calculated (`srem') is normalised to the range of
> [0,spre/2] and that divided by the original divisor (`spre') always works
> out at within [0,0.5], so `squot' will be within [0,32768]. I guess the
> static analyser is too dumb to figure it out, so I'll see how to paper it
> over unless someone has a better proposal.
These emails are a one time email so it's okay to ignore them if you
want.
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-17 13:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 18:17 [PATCH v3 2/2] serial: 8250: Add proper clock handling for OxSemi PCIe devices kernel test robot
2022-02-17 9:23 ` Dan Carpenter
2022-02-17 9:23 ` Dan Carpenter
2022-02-17 12:05 ` Maciej W. Rozycki
2022-02-17 12:05 ` Maciej W. Rozycki
2022-02-17 13:23 ` Dan Carpenter [this message]
2022-02-17 13:23 ` Dan Carpenter
2022-02-17 13:23 ` Dan Carpenter
2022-02-21 15:56 ` Maciej W. Rozycki
2022-02-21 15:56 ` Maciej W. Rozycki
-- strict thread matches above, loose matches on Subject: below --
2022-02-12 8:41 [PATCH v3 0/2] serial: 8250: Fixes for Oxford Semiconductor 950 UARTs Maciej W. Rozycki
2022-02-12 8:41 ` [PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code Maciej W. Rozycki
2022-02-12 8:41 ` [PATCH v3 2/2] serial: 8250: Add proper clock handling for OxSemi PCIe devices Maciej W. Rozycki
2022-02-12 14:36 ` Andy Shevchenko
2022-03-01 20:52 ` [PING][PATCH v3 0/2] serial: 8250: Fixes for Oxford Semiconductor 950 UARTs Maciej W. Rozycki
2022-03-18 12:10 ` Greg Kroah-Hartman
2022-03-31 7:12 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217132352.GC2467@kadam \
--to=dan.carpenter@oracle.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@endruntechnologies.com \
--cc=jirislaby@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=macro@orcam.me.uk \
--cc=mkorreng@endruntechnologies.com \
--cc=mskoog@endruntechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.