All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Andrea Merello <andrea.merello@gmail.com>,
	jic23@kernel.org, mchehab+huawei@kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org, lars@metafoo.de, robh+dt@kernel.org,
	andy.shevchenko@gmail.com, matt.ranostay@konsulko.com,
	ardeleanalex@gmail.com, jacopo@jmondi.org,
	Andrea Merello <andrea.merello@gmail.com>
Subject: Re: [v3 11/13] iio: imu: add BNO055 serdev driver
Date: Fri, 18 Feb 2022 13:20:27 +0800	[thread overview]
Message-ID: <202202181307.Lb4f99qg-lkp@intel.com> (raw)
In-Reply-To: <20220217162710.33615-12-andrea.merello@gmail.com>

Hi Andrea,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linux/master linus/master v5.17-rc4 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andrea-Merello/Add-support-for-Bosch-BNO055-IMU/20220218-002932
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220218/202202181307.Lb4f99qg-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/98d7db4486f0404718da9e85ae13da54d757104b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andrea-Merello/Add-support-for-Bosch-BNO055-IMU/20220218-002932
        git checkout 98d7db4486f0404718da9e85ae13da54d757104b
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/iio/imu/bno055/bno055.c:285:5: warning: no previous prototype for 'bno055_calibration_load' [-Wmissing-prototypes]
     285 | int bno055_calibration_load(struct bno055_priv *priv, const u8 *data, int len)
         |     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/imu/bno055/bno055.c:748:5: warning: no previous prototype for 'bno055_sysfs_attr_avail' [-Wmissing-prototypes]
     748 | int bno055_sysfs_attr_avail(struct bno055_priv *priv, struct bno055_sysfs_attr *attr,
         |     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/imu/bno055/bno055.c:1203:5: warning: no previous prototype for 'bno055_debugfs_reg_access' [-Wmissing-prototypes]
    1203 | int bno055_debugfs_reg_access(struct iio_dev *iio_dev, unsigned int reg,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/imu/bno055/bno055.c: In function 'bno055_show_fw_version':
>> drivers/iio/imu/bno055/bno055.c:1235:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
    1235 |  kfree(buf);
         |  ^~~~~
         |  vfree
   cc1: some warnings being treated as errors


vim +1235 drivers/iio/imu/bno055/bno055.c

16cbcd24402827b Andrea Merello 2022-02-17  1213  
16cbcd24402827b Andrea Merello 2022-02-17  1214  static ssize_t bno055_show_fw_version(struct file *file, char __user *userbuf,
16cbcd24402827b Andrea Merello 2022-02-17  1215  				      size_t count, loff_t *ppos)
16cbcd24402827b Andrea Merello 2022-02-17  1216  {
16cbcd24402827b Andrea Merello 2022-02-17  1217  	struct bno055_priv *priv = file->private_data;
16cbcd24402827b Andrea Merello 2022-02-17  1218  	int rev, ver;
16cbcd24402827b Andrea Merello 2022-02-17  1219  	char *buf;
16cbcd24402827b Andrea Merello 2022-02-17  1220  	int ret;
16cbcd24402827b Andrea Merello 2022-02-17  1221  
16cbcd24402827b Andrea Merello 2022-02-17  1222  	ret = regmap_read(priv->regmap, BNO055_SW_REV_LSB_REG, &rev);
16cbcd24402827b Andrea Merello 2022-02-17  1223  	if (ret)
16cbcd24402827b Andrea Merello 2022-02-17  1224  		return ret;
16cbcd24402827b Andrea Merello 2022-02-17  1225  
16cbcd24402827b Andrea Merello 2022-02-17  1226  	ret = regmap_read(priv->regmap, BNO055_SW_REV_MSB_REG, &ver);
16cbcd24402827b Andrea Merello 2022-02-17  1227  	if (ret)
16cbcd24402827b Andrea Merello 2022-02-17  1228  		return ret;
16cbcd24402827b Andrea Merello 2022-02-17  1229  
16cbcd24402827b Andrea Merello 2022-02-17  1230  	buf = kasprintf(GFP_KERNEL, "ver: 0x%x, rev: 0x%x\n", ver, rev);
16cbcd24402827b Andrea Merello 2022-02-17  1231  	if (!buf)
16cbcd24402827b Andrea Merello 2022-02-17  1232  		return -ENOMEM;
16cbcd24402827b Andrea Merello 2022-02-17  1233  
16cbcd24402827b Andrea Merello 2022-02-17  1234  	ret = simple_read_from_buffer(userbuf, count, ppos, buf, strlen(buf));
16cbcd24402827b Andrea Merello 2022-02-17 @1235  	kfree(buf);
16cbcd24402827b Andrea Merello 2022-02-17  1236  
16cbcd24402827b Andrea Merello 2022-02-17  1237  	return ret;
16cbcd24402827b Andrea Merello 2022-02-17  1238  }
16cbcd24402827b Andrea Merello 2022-02-17  1239  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [v3 11/13] iio: imu: add BNO055 serdev driver
Date: Fri, 18 Feb 2022 13:20:27 +0800	[thread overview]
Message-ID: <202202181307.Lb4f99qg-lkp@intel.com> (raw)
In-Reply-To: <20220217162710.33615-12-andrea.merello@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4609 bytes --]

Hi Andrea,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linux/master linus/master v5.17-rc4 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andrea-Merello/Add-support-for-Bosch-BNO055-IMU/20220218-002932
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220218/202202181307.Lb4f99qg-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/98d7db4486f0404718da9e85ae13da54d757104b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andrea-Merello/Add-support-for-Bosch-BNO055-IMU/20220218-002932
        git checkout 98d7db4486f0404718da9e85ae13da54d757104b
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/iio/imu/bno055/bno055.c:285:5: warning: no previous prototype for 'bno055_calibration_load' [-Wmissing-prototypes]
     285 | int bno055_calibration_load(struct bno055_priv *priv, const u8 *data, int len)
         |     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/imu/bno055/bno055.c:748:5: warning: no previous prototype for 'bno055_sysfs_attr_avail' [-Wmissing-prototypes]
     748 | int bno055_sysfs_attr_avail(struct bno055_priv *priv, struct bno055_sysfs_attr *attr,
         |     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/imu/bno055/bno055.c:1203:5: warning: no previous prototype for 'bno055_debugfs_reg_access' [-Wmissing-prototypes]
    1203 | int bno055_debugfs_reg_access(struct iio_dev *iio_dev, unsigned int reg,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/imu/bno055/bno055.c: In function 'bno055_show_fw_version':
>> drivers/iio/imu/bno055/bno055.c:1235:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
    1235 |  kfree(buf);
         |  ^~~~~
         |  vfree
   cc1: some warnings being treated as errors


vim +1235 drivers/iio/imu/bno055/bno055.c

16cbcd24402827b Andrea Merello 2022-02-17  1213  
16cbcd24402827b Andrea Merello 2022-02-17  1214  static ssize_t bno055_show_fw_version(struct file *file, char __user *userbuf,
16cbcd24402827b Andrea Merello 2022-02-17  1215  				      size_t count, loff_t *ppos)
16cbcd24402827b Andrea Merello 2022-02-17  1216  {
16cbcd24402827b Andrea Merello 2022-02-17  1217  	struct bno055_priv *priv = file->private_data;
16cbcd24402827b Andrea Merello 2022-02-17  1218  	int rev, ver;
16cbcd24402827b Andrea Merello 2022-02-17  1219  	char *buf;
16cbcd24402827b Andrea Merello 2022-02-17  1220  	int ret;
16cbcd24402827b Andrea Merello 2022-02-17  1221  
16cbcd24402827b Andrea Merello 2022-02-17  1222  	ret = regmap_read(priv->regmap, BNO055_SW_REV_LSB_REG, &rev);
16cbcd24402827b Andrea Merello 2022-02-17  1223  	if (ret)
16cbcd24402827b Andrea Merello 2022-02-17  1224  		return ret;
16cbcd24402827b Andrea Merello 2022-02-17  1225  
16cbcd24402827b Andrea Merello 2022-02-17  1226  	ret = regmap_read(priv->regmap, BNO055_SW_REV_MSB_REG, &ver);
16cbcd24402827b Andrea Merello 2022-02-17  1227  	if (ret)
16cbcd24402827b Andrea Merello 2022-02-17  1228  		return ret;
16cbcd24402827b Andrea Merello 2022-02-17  1229  
16cbcd24402827b Andrea Merello 2022-02-17  1230  	buf = kasprintf(GFP_KERNEL, "ver: 0x%x, rev: 0x%x\n", ver, rev);
16cbcd24402827b Andrea Merello 2022-02-17  1231  	if (!buf)
16cbcd24402827b Andrea Merello 2022-02-17  1232  		return -ENOMEM;
16cbcd24402827b Andrea Merello 2022-02-17  1233  
16cbcd24402827b Andrea Merello 2022-02-17  1234  	ret = simple_read_from_buffer(userbuf, count, ppos, buf, strlen(buf));
16cbcd24402827b Andrea Merello 2022-02-17 @1235  	kfree(buf);
16cbcd24402827b Andrea Merello 2022-02-17  1236  
16cbcd24402827b Andrea Merello 2022-02-17  1237  	return ret;
16cbcd24402827b Andrea Merello 2022-02-17  1238  }
16cbcd24402827b Andrea Merello 2022-02-17  1239  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

  parent reply	other threads:[~2022-02-18  5:21 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17 16:26 [v3 00/13] Add support for Bosch BNO055 IMU Andrea Merello
2022-02-17 16:26 ` [v3 01/13] iio: add modifiers for linear acceleration Andrea Merello
2022-02-17 16:26 ` [v3 02/13] iio: document linear acceleration modifiers Andrea Merello
2022-02-19 16:08   ` Jonathan Cameron
2022-02-17 16:27 ` [v3 03/13] iio: event_monitor: add " Andrea Merello
2022-02-17 16:27 ` [v3 04/13] iio: add modifers for pitch, yaw, roll Andrea Merello
2022-02-17 16:27 ` [v3 05/13] iio: document pitch, yaw, roll modifiers Andrea Merello
2022-02-19 16:31   ` Jonathan Cameron
2022-02-17 16:27 ` [v3 06/13] iio: event_monitor: add pitch, yaw and " Andrea Merello
2022-02-17 16:27 ` [v3 07/13] iio: imu: add Bosch Sensortec BNO055 core driver Andrea Merello
2022-02-17 21:58   ` Peter Meerwald-Stadler
2022-02-19 17:41     ` Jonathan Cameron
2022-03-22 10:27       ` Andrea Merello
2022-03-27 16:11         ` Jonathan Cameron
2022-03-28 13:02           ` Greg Kroah-Hartman
2022-04-04  6:30             ` Andrea Merello
2022-04-04  7:54               ` Greg Kroah-Hartman
2022-03-22 10:14     ` Andrea Merello
2022-02-17 16:27 ` [v3 08/13] iio: document bno055 private sysfs attributes Andrea Merello
2022-02-19 16:50   ` Jonathan Cameron
2022-02-17 16:27 ` [v3 09/13] iio: document "serial_number" sysfs attribute Andrea Merello
2022-02-19 16:52   ` Jonathan Cameron
2022-02-17 16:27 ` [v3 10/13] dt-bindings: iio: imu: add documentation for Bosch BNO055 bindings Andrea Merello
2022-02-24 19:54   ` Rob Herring
2022-02-17 16:27 ` [v3 11/13] iio: imu: add BNO055 serdev driver Andrea Merello
2022-02-17 19:47   ` kernel test robot
2022-02-17 19:47     ` kernel test robot
2022-02-18  5:20   ` kernel test robot [this message]
2022-02-18  5:20     ` kernel test robot
2022-02-21 20:27   ` Andy Shevchenko
2022-03-22 10:37     ` Andrea Merello
2022-02-17 16:27 ` [v3 12/13] iio: imu: add BNO055 I2C driver Andrea Merello
2022-02-19 17:03   ` Jonathan Cameron
2022-02-21 20:32   ` Andy Shevchenko
2022-02-17 16:27 ` [v3 13/13] docs: iio: add documentation for BNO055 driver Andrea Merello
2022-02-19 17:06   ` Jonathan Cameron
2022-03-22 10:30     ` Andrea Merello
2022-03-22 20:32       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202202181307.Lb4f99qg-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrea.merello@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=ardeleanalex@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacopo@jmondi.org \
    --cc=jic23@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.ranostay@konsulko.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.