All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
	agross@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, vkoul@kernel.org,
	linux-phy@lists.infradead.org, robh+dt@kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 6/8] arm64: dts: qcom: ipq6018: Fix qmp usb3 phy node
Date: Tue, 1 Mar 2022 12:11:47 +0800	[thread overview]
Message-ID: <20220301041147.GI269879@dragon> (raw)
In-Reply-To: <20220228123019.382037-7-bhupesh.sharma@linaro.org>

On Mon, Feb 28, 2022 at 06:00:17PM +0530, Bhupesh Sharma wrote:
> Fix the following 'make dtbs_check' warning(s) by
> using phy@ instead of lanes@ and by moving '#clock-names' to

s/clock-names/clock-cells

> sub-node:
> 
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml: ssphy@78000:
>  'lane@78200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>

Other than that:

Reviewed-by: Shawn Guo <shawn.guo@linaro.org>

> ---
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 66ec5615651d..ad7914e49532 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -674,7 +674,6 @@ ssphy_0: ssphy@78000 {
>  			reg = <0x0 0x78000 0x0 0x1C4>;
>  			#address-cells = <2>;
>  			#size-cells = <2>;
> -			#clock-cells = <1>;
>  			ranges;
>  
>  			clocks = <&gcc GCC_USB0_AUX_CLK>,
> @@ -686,12 +685,13 @@ ssphy_0: ssphy@78000 {
>  			reset-names = "phy","common";
>  			status = "disabled";
>  
> -			usb0_ssphy: lane@78200 {
> +			usb0_ssphy: phy@78200 {
>  				reg = <0x0 0x00078200 0x0 0x130>, /* Tx */
>  				      <0x0 0x00078400 0x0 0x200>, /* Rx */
>  				      <0x0 0x00078800 0x0 0x1F8>, /* PCS */
>  				      <0x0 0x00078600 0x0 0x044>; /* PCS misc */
>  				#phy-cells = <0>;
> +				#clock-cells = <1>;
>  				clocks = <&gcc GCC_USB0_PIPE_CLK>;
>  				clock-names = "pipe0";
>  				clock-output-names = "gcc_usb0_pipe_clk_src";
> -- 
> 2.35.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
	agross@kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, vkoul@kernel.org,
	linux-phy@lists.infradead.org, robh+dt@kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 6/8] arm64: dts: qcom: ipq6018: Fix qmp usb3 phy node
Date: Tue, 1 Mar 2022 12:11:47 +0800	[thread overview]
Message-ID: <20220301041147.GI269879@dragon> (raw)
In-Reply-To: <20220228123019.382037-7-bhupesh.sharma@linaro.org>

On Mon, Feb 28, 2022 at 06:00:17PM +0530, Bhupesh Sharma wrote:
> Fix the following 'make dtbs_check' warning(s) by
> using phy@ instead of lanes@ and by moving '#clock-names' to

s/clock-names/clock-cells

> sub-node:
> 
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml: ssphy@78000:
>  'lane@78200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>

Other than that:

Reviewed-by: Shawn Guo <shawn.guo@linaro.org>

> ---
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 66ec5615651d..ad7914e49532 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -674,7 +674,6 @@ ssphy_0: ssphy@78000 {
>  			reg = <0x0 0x78000 0x0 0x1C4>;
>  			#address-cells = <2>;
>  			#size-cells = <2>;
> -			#clock-cells = <1>;
>  			ranges;
>  
>  			clocks = <&gcc GCC_USB0_AUX_CLK>,
> @@ -686,12 +685,13 @@ ssphy_0: ssphy@78000 {
>  			reset-names = "phy","common";
>  			status = "disabled";
>  
> -			usb0_ssphy: lane@78200 {
> +			usb0_ssphy: phy@78200 {
>  				reg = <0x0 0x00078200 0x0 0x130>, /* Tx */
>  				      <0x0 0x00078400 0x0 0x200>, /* Rx */
>  				      <0x0 0x00078800 0x0 0x1F8>, /* PCS */
>  				      <0x0 0x00078600 0x0 0x044>; /* PCS misc */
>  				#phy-cells = <0>;
> +				#clock-cells = <1>;
>  				clocks = <&gcc GCC_USB0_PIPE_CLK>;
>  				clock-names = "pipe0";
>  				clock-output-names = "gcc_usb0_pipe_clk_src";
> -- 
> 2.35.1
> 

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2022-03-01  4:11 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 12:30 [PATCH v2 0/8] Fix dtbs_check warning(s) for Qualcomm QMP PHY Bhupesh Sharma
2022-02-28 12:30 ` Bhupesh Sharma
2022-02-28 12:30 ` [PATCH v2 1/8] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property Bhupesh Sharma
2022-02-28 12:30   ` [PATCH v2 1/8] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-03-01  3:55   ` [PATCH v2 1/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-01  3:55     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 2/8] dt-bindings: phy: qcom,qmp: Describe 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Bhupesh Sharma
2022-02-28 12:30   ` [PATCH v2 2/8] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-03-01  4:15   ` [PATCH v2 2/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-01  4:15     ` Shawn Guo
2022-03-04 23:58   ` Rob Herring
2022-03-04 23:58     ` Rob Herring
2022-02-28 12:30 ` [PATCH v2 3/8] arm64: dts: qcom: msm8996-xiaomi: Drop max-microamp and vddp-ref-clk properties from QMP PHY Bhupesh Sharma
2022-02-28 12:30   ` Bhupesh Sharma
2022-03-01  4:22   ` Shawn Guo
2022-03-01  4:22     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 4/8] arm64: dts: qcom: sc7280: Fix qmp phy node (use phy@ instead of lanes@) Bhupesh Sharma
2022-02-28 12:30   ` Bhupesh Sharma
2022-03-01  4:09   ` Shawn Guo
2022-03-01  4:09     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 5/8] arm64: dts: qcom: sm8450: Fix qmp ufs " Bhupesh Sharma
2022-02-28 12:30   ` Bhupesh Sharma
2022-03-01  4:10   ` Shawn Guo
2022-03-01  4:10     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 6/8] arm64: dts: qcom: ipq6018: Fix qmp usb3 phy node Bhupesh Sharma
2022-02-28 12:30   ` Bhupesh Sharma
2022-03-01  4:11   ` Shawn Guo [this message]
2022-03-01  4:11     ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 7/8] dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly Bhupesh Sharma
2022-02-28 12:30   ` [PATCH v2 7/8] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-03-01  4:07   ` [PATCH v2 7/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-01  4:07     ` [PATCH v2 7/8] dt-bindings: phy: qcom, qmp: " Shawn Guo
2022-03-04 23:58   ` [PATCH v2 7/8] dt-bindings: phy: qcom,qmp: " Rob Herring
2022-03-04 23:58     ` [PATCH v2 7/8] dt-bindings: phy: qcom, qmp: " Rob Herring
2022-02-28 12:30 ` [PATCH v2 8/8] dt-bindings: phy: qcom,qmp: Mark 'vdda-pll-supply' & 'vdda-phy-supply' as optional Bhupesh Sharma
2022-02-28 12:30   ` [PATCH v2 8/8] dt-bindings: phy: qcom, qmp: " Bhupesh Sharma
2022-03-01  3:39   ` [PATCH v2 8/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-01  3:39     ` Shawn Guo
2022-03-01  3:47   ` Bjorn Andersson
2022-03-01  3:47     ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301041147.GI269879@dragon \
    --to=shawn.guo@linaro.org \
    --cc=agross@kernel.org \
    --cc=bhupesh.linux@gmail.com \
    --cc=bhupesh.sharma@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.