Re: [PATCH 10/19] dma: imx-sdma: Add multi fifo support

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Mar 17, 2022 at 08:20:22PM +0800, Shengjiu Wang wrote:
>    Hi
>    On Thu, Mar 17, 2022 at 6:19 PM Sascha Hauer <[1]s.hauer@pengutronix.de>
>    wrote:
> 
>      On Thu, Mar 17, 2022 at 05:08:55PM +0800, Shengjiu Wang wrote:
>      >    On Thu, Mar 17, 2022 at 4:28 PM Sascha Hauer
>      <[1][2]s.hauer@pengutronix.de>
>      >    wrote:
>      >
>      >      +struct sdma_peripheral_config {
>      >      +       int n_fifos_src;
>      >      +       int n_fifos_dst;
>      >      +       bool sw_done;
>      >      +};
>      >      +
>      >       #endif
>      >
>      >    Hi Sascha
>      >    This is our internal definition for this sdma_peripheral_config.
>      >    Could you please adopt this?
> 
>      This structure is completely internal to the kernel and can be adjusted
>      when we need it. I don't see a reason to add unused fields to it just to
>      be compatible with a downstream kernel.
> 
>    Yes, it is not used by micfil. But the fifo_offset and words_per_fifo
>    is part the multi fifo script support scope, if only add fifo_num,  it
>    looks
>    like this feature is not complete.

No, it's not. I only added the parts that I am interested in and that I
can test. I have some multichannel audio stuff in my pipeline, I might add
more pieces later.

>    By the way,  which multi fifo script version are you using? seems it is
>    not the latest compared with our release, right?

I am using the latest firmware from linux-firmware.git.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |