All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Clément Léger" <clement.leger@bootlin.com>
To: <Eugen.Hristev@microchip.com>
Cc: <Ludovic.Desroches@microchip.com>, <u-boot@lists.denx.de>,
	<Nicolas.Ferre@microchip.com>, <thomas.petazzoni@bootlin.com>,
	<Claudiu.Beznea@microchip.com>
Subject: Re: [PATCH v7 4/4] configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMER
Date: Tue, 22 Mar 2022 13:35:08 +0100	[thread overview]
Message-ID: <20220322133508.31630f38@fixe.home> (raw)
In-Reply-To: <c5fef41b-51b2-ead4-96c2-eb8f23a3f459@microchip.com>

Le Tue, 22 Mar 2022 11:18:39 +0000,
<Eugen.Hristev@microchip.com> a écrit :

> On 3/11/22 11:35 AM, Clément Léger wrote:
> > Enable CONFIG_ATMEL_TCB_TIMER and disable CONFIG_ATMEL_PIT_TIMER.
> > This will allow using the TCB timer instead of the PIT one when running
> > under OP-TEE.  
> 
> Hello Clement,
> 
> We have to make sure that the PIT_TIMER was not mandatory for SPL 
> operations, and if it was, the TCB_TIMER successfully replaces it.
> 
> If we have the PIT_TIMER with the u-boot property
> u-boot,dm-pre-reloc;
> then the PIT_TIMER is available in the SPL and the SPL works :
> 
> RomBOOT
> ;4▒ls▒K{▒KOp▒C▒▒
> <debug_uart>
> 
> U-Boot SPL 2022.04-rc4-00204-g5f7086d8a8-dirty (Mar 22 2022 - 13:10:58 
> +0200)
> SPL: Unsupported Boot Device!
> SPL: failed to boot from all boot devices
> 
> 
> (well, it fails to boot because I removed the MMC drivers to have it 
> smaller than 64k, but it boots)
> 
> 
> However, with your patches, even if I add the pre-reloc property to the 
> tcb nodes, it fails to boot:
> 
> RomBOOT
> ;4▒Ls▒k{▒kOp▒C▒▒
> <debug_uart>
> Could not initialize timer (err -22)
> 
> Could not initialize timer (err -22)
> 
> Could not initialize timer (err -22)
> 
> Could not initialize timer (err -22)
> 
> ...
> 
> 
> 
> Could you investigate this please ?

Hi Eugen,

Ok, I'll try to debug that !

> 
> Otherwise we cannot switch to using the TCB if it does not fully replace 
> the PIT_TIMER in all the use cases.

Yes, that is completely understandable.

> 
> 
> Thanks,
> 
> Eugen


-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com

  reply	other threads:[~2022-03-22 12:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  9:35 [PATCH v7 0/4] add TCB driver for sama5d2 Clément Léger
2022-03-11  9:35 ` [PATCH v7 1/4] timer: atmel_tcb_timer: add atmel_tcb driver Clément Léger
2022-03-11  9:35 ` [PATCH v7 2/4] ARM: dts: at91: sama5d2: add AIC node Clément Léger
2022-03-11  9:35 ` [PATCH v7 3/4] ARM: dts: at91: sama5d2: add TCB node Clément Léger
2022-03-11  9:35 ` [PATCH v7 4/4] configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMER Clément Léger
2022-03-22 11:18   ` Eugen.Hristev
2022-03-22 12:35     ` Clément Léger [this message]
2022-03-30 15:49       ` Clément Léger
2022-03-31  5:59         ` Eugen.Hristev
2022-03-31  7:40           ` Clément Léger
2022-03-31  7:53             ` Eugen.Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220322133508.31630f38@fixe.home \
    --to=clement.leger@bootlin.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.