[linux-next:master 14515/15002] drivers/gpu/drm/drm_of.c:297:2-13: ERROR: probable double put.

[linux-next:master 14515/15002] drivers/gpu/drm/drm_of.c:297:2-13: ERROR: probable double put.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
CC: Maxime Ripard <maxime@cerno.tech>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e5071887cd2296a7704dbcd10c1cedf0f11cdbd5
commit: 67bae5f28c895f8737a1974c3f31cf12b9170b14 [14515/15002] drm: of: Properly try all possible cases for bridge/panel detection
:::::: branch date: 2 days ago
:::::: commit date: 3 days ago
config: nios2-randconfig-c023-20220403 (https://download.01.org/0day-ci/archive/20220403/202204030210.J2kMG0rF-lkp(a)intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/drm_of.c:297:2-13: ERROR: probable double put.

Please review and possibly fold the followup patch.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

[PATCH] drm: of: fix device_node_continue.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
CC: Maxime Ripard <maxime@cerno.tech>
CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
CC: Thomas Zimmermann <tzimmermann@suse.de>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: dri-devel(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/drm_of.c:297:2-13: ERROR: probable double put.

 Device node iterators put the previous value of the index variable, so an
 explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Fixes: 67bae5f28c89 ("drm: of: Properly try all possible cases for bridge/panel detection")
CC: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e5071887cd2296a7704dbcd10c1cedf0f11cdbd5
commit: 67bae5f28c895f8737a1974c3f31cf12b9170b14 [14515/15002] drm: of: Properly try all possible cases for bridge/panel detection
:::::: branch date: 2 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/gpu/drm/drm_of.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -294,7 +294,6 @@ int drm_of_find_panel_or_bridge(const st
 			continue;
 
 		ret = find_panel_or_bridge(node, panel, bridge);
-		of_node_put(node);
 
 		/* Stop at the first found occurrence. */
 		if (!ret)