All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>, Biwen Li <biwen.li@nxp.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] arm64: dts: ls208xa-rdb: fix errata E-00013
Date: Sun, 10 Apr 2022 09:25:43 +0800	[thread overview]
Message-ID: <20220410012543.GJ129381@dragon> (raw)
In-Reply-To: <20220317190109.3742-5-leoyang.li@nxp.com>

On Thu, Mar 17, 2022 at 02:01:08PM -0500, Li Yang wrote:
> From: Biwen Li <biwen.li@nxp.com>
> 
> Specify a channel zero in idle state to
> avoid enterring tri-stated state for PCA9547.

Please check Documentation/process/submitting-patches.rst for commit log
wrapping requirement.

> About E-00013:
> 	- Description: I2C1 and I2C3 buses

Use space instead of tab for bullet indent.

Shawn

> 	  are missing pull-up.
> 	- Impact: When the PCA954x device is tri-stated, the I2C bus
> 	  will float. This makes the I2C bus and its associated
> 	  downstream devices inaccessible.
> 	- Hardware fix: Populate resistors R189 and R190 for I2C1
> 	  and resistors R228 and R229 for I2C3.
> 	- Software fix: Remove the tri-state option from the PCA954x
> 	  driver(PCA954x always on enable status, specify a
> 	  channel zero in dts to fix the errata E-00013).
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi
> index 4b71c4fcb35f..a752f06a2e74 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi
> @@ -49,6 +49,8 @@ pca9547@75 {
>  		reg = <0x75>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +		idle-state = <0>;
> +
>  		i2c@1 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> -- 
> 2.25.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>, Biwen Li <biwen.li@nxp.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] arm64: dts: ls208xa-rdb: fix errata E-00013
Date: Sun, 10 Apr 2022 09:25:43 +0800	[thread overview]
Message-ID: <20220410012543.GJ129381@dragon> (raw)
In-Reply-To: <20220317190109.3742-5-leoyang.li@nxp.com>

On Thu, Mar 17, 2022 at 02:01:08PM -0500, Li Yang wrote:
> From: Biwen Li <biwen.li@nxp.com>
> 
> Specify a channel zero in idle state to
> avoid enterring tri-stated state for PCA9547.

Please check Documentation/process/submitting-patches.rst for commit log
wrapping requirement.

> About E-00013:
> 	- Description: I2C1 and I2C3 buses

Use space instead of tab for bullet indent.

Shawn

> 	  are missing pull-up.
> 	- Impact: When the PCA954x device is tri-stated, the I2C bus
> 	  will float. This makes the I2C bus and its associated
> 	  downstream devices inaccessible.
> 	- Hardware fix: Populate resistors R189 and R190 for I2C1
> 	  and resistors R228 and R229 for I2C3.
> 	- Software fix: Remove the tri-state option from the PCA954x
> 	  driver(PCA954x always on enable status, specify a
> 	  channel zero in dts to fix the errata E-00013).
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi
> index 4b71c4fcb35f..a752f06a2e74 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa-rdb.dtsi
> @@ -49,6 +49,8 @@ pca9547@75 {
>  		reg = <0x75>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +		idle-state = <0>;
> +
>  		i2c@1 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> -- 
> 2.25.1
> 

  reply	other threads:[~2022-04-10  1:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 19:01 [PATCH 1/6] arm64: dts: ls2080a-qds: add mdio mux nodes from on-board FPGA Li Yang
2022-03-17 19:01 ` Li Yang
2022-03-17 19:01 ` [PATCH 2/6] arm64: dts: ls2088a-qds: " Li Yang
2022-03-17 19:01   ` Li Yang
2022-03-17 19:01 ` [PATCH 3/6] arm64: dts: ls2080a-rdb: add phy nodes Li Yang
2022-03-17 19:01   ` Li Yang
2022-04-10  1:12   ` Shawn Guo
2022-04-10  1:12     ` Shawn Guo
2022-03-17 19:01 ` [PATCH 4/6] arm64: dts: ls2081a-rdb: Add DTS support for NXP LS2081ARDB Li Yang
2022-03-17 19:01   ` Li Yang
2022-04-10  1:19   ` Shawn Guo
2022-04-10  1:19     ` Shawn Guo
2022-03-17 19:01 ` [PATCH 5/6] arm64: dts: ls208xa-rdb: fix errata E-00013 Li Yang
2022-03-17 19:01   ` Li Yang
2022-04-10  1:25   ` Shawn Guo [this message]
2022-04-10  1:25     ` Shawn Guo
2022-03-17 19:01 ` [PATCH 6/6] arm64: dts: ls208x: remove NXP Erratum A008585 from LS2088A Li Yang
2022-03-17 19:01   ` Li Yang
2022-04-10  1:27   ` Shawn Guo
2022-04-10  1:27     ` Shawn Guo
2022-04-10  1:10 ` [PATCH 1/6] arm64: dts: ls2080a-qds: add mdio mux nodes from on-board FPGA Shawn Guo
2022-04-10  1:10   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220410012543.GJ129381@dragon \
    --to=shawnguo@kernel.org \
    --cc=biwen.li@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.