[Buildroot] [PATCH 1/1] package/php-apcu: needs threads

[Buildroot] [PATCH 1/1] package/php-apcu: needs threads

[Fabrice Fontaine]

php-apcu needs threads since its addition in commit
8ddeeffa186d8bce875ac713c1e71483c618842a:

In file included from /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.c:20:
/home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.h:41:11: fatal error: pthread.h: No such file or directory
   41 | # include "pthread.h"
      |           ^~~~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/314405423aeece5ee55d76ec5c4fa1919e7ee853

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/php-apcu/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/php-apcu/Config.in b/package/php-apcu/Config.in
index 6338980222..f8e1eb17bb 100644
--- a/package/php-apcu/Config.in
+++ b/package/php-apcu/Config.in
@@ -1,6 +1,10 @@
 config BR2_PACKAGE_PHP_APCU
 	bool "php-apcu"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  APCu is an in-memory key-value store for PHP.
 
 	  https://pecl.php.net/package/APCu
+
+comment "php-apcu needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads

[Herve Codina via buildroot]

Hi Fabrice,

On Thu, 14 Apr 2022 22:30:59 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> php-apcu needs threads since its addition in commit
> 8ddeeffa186d8bce875ac713c1e71483c618842a:
> 
> In file included from /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.c:20:
> /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.h:41:11: fatal error: pthread.h: No such file or directory
>    41 | # include "pthread.h"
>       |           ^~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/314405423aeece5ee55d76ec5c4fa1919e7ee853
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/php-apcu/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/php-apcu/Config.in b/package/php-apcu/Config.in
> index 6338980222..f8e1eb17bb 100644
> --- a/package/php-apcu/Config.in
> +++ b/package/php-apcu/Config.in
> @@ -1,6 +1,10 @@
>  config BR2_PACKAGE_PHP_APCU
>  	bool "php-apcu"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	help
>  	  APCu is an in-memory key-value store for PHP.
>  
>  	  https://pecl.php.net/package/APCu
> +
> +comment "php-apcu needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS

Acked.

Thanks,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads

[Thomas Petazzoni via buildroot]

Hello Hervé,

On Fri, 15 Apr 2022 08:36:57 +0200
Herve Codina via buildroot <buildroot@buildroot.org> wrote:

> Acked.

If you want your Acked-by to be recorded by patchwork, it needs to be a
full Acked-by:, followed by your name and e-mail.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads

[Herve Codina via buildroot]

Hi Thomas, Fabrice,

On Sun, 17 Apr 2022 21:36:01 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello Hervé,
> 
> On Fri, 15 Apr 2022 08:36:57 +0200
> Herve Codina via buildroot <buildroot@buildroot.org> wrote:
> 
> > Acked.  
> 
> If you want your Acked-by to be recorded by patchwork, it needs to be a
> full Acked-by:, followed by your name and e-mail.
> 
> Thomas

Acked-by: Herve Codina <herve.codina@bootlin.com>

Hervé
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads

[Arnout Vandecappelle]

On 14/04/2022 22:30, Fabrice Fontaine wrote:
> php-apcu needs threads since its addition in commit
> 8ddeeffa186d8bce875ac713c1e71483c618842a:
> 
> In file included from /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.c:20:
> /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.h:41:11: fatal error: pthread.h: No such file or directory
>     41 | # include "pthread.h"
>        |           ^~~~~~~~~~~
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/314405423aeece5ee55d76ec5c4fa1919e7ee853
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/php-apcu/Config.in | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/php-apcu/Config.in b/package/php-apcu/Config.in
> index 6338980222..f8e1eb17bb 100644
> --- a/package/php-apcu/Config.in
> +++ b/package/php-apcu/Config.in
> @@ -1,6 +1,10 @@
>   config BR2_PACKAGE_PHP_APCU
>   	bool "php-apcu"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>   	help
>   	  APCu is an in-memory key-value store for PHP.
>   
>   	  https://pecl.php.net/package/APCu
> +
> +comment "php-apcu needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > php-apcu needs threads since its addition in commit
 > 8ddeeffa186d8bce875ac713c1e71483c618842a:

 > In file included from /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.c:20:
 > /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.h:41:11: fatal error: pthread.h: No such file or directory
 >    41 | # include "pthread.h"
 >       |           ^~~~~~~~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/314405423aeece5ee55d76ec5c4fa1919e7ee853

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot