From: Jakub Kicinski <kuba@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<netdev@vger.kernel.org>, <peppe.cavallaro@st.com>,
<alexandre.torgue@foss.st.com>, <davem@davemloft.net>,
<edumazet@google.com>
Subject: Re: [PATCH] net: stmmac: fix missing pci_disable_device() on error in stmmac_pci_probe()
Date: Mon, 9 May 2022 15:55:25 -0700 [thread overview]
Message-ID: <20220509155525.26e053db@kernel.org> (raw)
In-Reply-To: <20220506094039.3629649-1-yangyingliang@huawei.com>
On Fri, 6 May 2022 17:40:39 +0800 Yang Yingliang wrote:
> Fix the missing pci_disable_device() before return
> from stmmac_pci_probe() in the error handling case.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Here indeed pcim_enable_device() seems like a better fit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<netdev@vger.kernel.org>, <peppe.cavallaro@st.com>,
<alexandre.torgue@foss.st.com>, <davem@davemloft.net>,
<edumazet@google.com>
Subject: Re: [PATCH] net: stmmac: fix missing pci_disable_device() on error in stmmac_pci_probe()
Date: Mon, 9 May 2022 15:55:25 -0700 [thread overview]
Message-ID: <20220509155525.26e053db@kernel.org> (raw)
In-Reply-To: <20220506094039.3629649-1-yangyingliang@huawei.com>
On Fri, 6 May 2022 17:40:39 +0800 Yang Yingliang wrote:
> Fix the missing pci_disable_device() before return
> from stmmac_pci_probe() in the error handling case.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Here indeed pcim_enable_device() seems like a better fit.
next prev parent reply other threads:[~2022-05-09 22:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 9:40 [PATCH] net: stmmac: fix missing pci_disable_device() on error in stmmac_pci_probe() Yang Yingliang
2022-05-06 9:40 ` Yang Yingliang
2022-05-09 22:55 ` Jakub Kicinski [this message]
2022-05-09 22:55 ` Jakub Kicinski
2022-05-10 1:15 ` Yang Yingliang
2022-05-10 1:15 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509155525.26e053db@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.