All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] slimbus: qcom: fix platform_get_irq.cocci warnings
  2022-05-09 23:10 [char-misc:char-misc-linus 1/1] drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error kernel test robot
@ 2022-05-09 23:01 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-05-09 23:01 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Miaoqian Lin <linmq006@gmail.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC: Andy Gross <agross@kernel.org>
CC: Bjorn Andersson <bjorn.andersson@linaro.org>
CC: linux-arm-msm(a)vger.kernel.org
CC: alsa-devel(a)alsa-project.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: fe503887eed6 ("slimbus: qcom: Fix IRQ check in qcom_slim_probe")
CC: Miaoqian Lin <linmq006@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus
head:   fe503887eed6ea528e144ec8dacfa1d47aa701ac
commit: fe503887eed6ea528e144ec8dacfa1d47aa701ac [1/1] slimbus: qcom: Fix IRQ check in qcom_slim_probe
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/slimbus/qcom-ctrl.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/slimbus/qcom-ctrl.c
+++ b/drivers/slimbus/qcom-ctrl.c
@@ -511,7 +511,6 @@ static int qcom_slim_probe(struct platfo
 
 	ctrl->irq = platform_get_irq(pdev, 0);
 	if (ctrl->irq < 0) {
-		dev_err(&pdev->dev, "no slimbus IRQ\n");
 		return ctrl->irq;
 	}
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [char-misc:char-misc-linus 1/1] drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error
@ 2022-05-09 23:10 kernel test robot
  2022-05-09 23:01 ` [PATCH] slimbus: qcom: fix platform_get_irq.cocci warnings kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-05-09 23:10 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Miaoqian Lin <linmq006@gmail.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-linus
head:   fe503887eed6ea528e144ec8dacfa1d47aa701ac
commit: fe503887eed6ea528e144ec8dacfa1d47aa701ac [1/1] slimbus: qcom: Fix IRQ check in qcom_slim_probe
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
config: arc-allmodconfig (https://download.01.org/0day-ci/archive/20220510/202205100730.LEVP50Zt-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-09 23:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-09 23:10 [char-misc:char-misc-linus 1/1] drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error kernel test robot
2022-05-09 23:01 ` [PATCH] slimbus: qcom: fix platform_get_irq.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.