Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support

From: Herve Codina <herve.codina@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@microchip.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support
Date: Fri, 20 May 2022 14:37:26 +0200	[thread overview]
Message-ID: <20220520143726.6dd324fb@bootlin.com> (raw)
In-Reply-To: <2945e445-3453-a45f-7d3d-3b07bf350b47@linaro.org>

Hi Krzysztof, Sergei

On Fri, 13 May 2022 14:54:26 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 13/05/2022 12:58, Herve Codina wrote:
> > Add UDPHS (the USB High Speed Device Port controller) support.
> > The UDPHS IP present in the lan966x SOC is the same as the one
> > present in the SAMA5D3 SOC
> > 
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> > ---
> >  arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> > index 7d2869648050..4c09f3166d27 100644
> > --- a/arch/arm/boot/dts/lan966x.dtsi
> > +++ b/arch/arm/boot/dts/lan966x.dtsi
> > @@ -211,6 +211,17 @@ can0: can@e081c000 {
> >  			status = "disabled";
> >  		};
> >  
> > +		udc: udphs@e0808000 {  
> 
> Generic node names, so it looks like usb. For example HCD schema
> requires it. I am not sure which bindings are used here, but anyway once
> they might require usb...
> 

HCD are related to the Host controller.
Here we are talking about a device.

In existing bindings related to USB device (or OTG as an OTG can be a
host or a device) on several SOCs, we can find:
- usb1: gadget@fffa4000
- usb_otg: usb@1c13000
- usb: usb@47400000
- udc: usb@13040000
- usb_otg_hs: usb_otg_hs@4a0ab000

So I will change to
  udc: usb@e0808000

Is that ok for you ?

Regards,
Herve

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com