From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Mike Snitzer <snitzer@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [dm-devel] [PATCH 4/6] block: cleanup variable naming in get_max_io_size
Date: Wed, 15 Jun 2022 08:27:29 +0200 [thread overview]
Message-ID: <20220615062729.GA22728@lst.de> (raw)
In-Reply-To: <4b846753-bb89-c123-2813-bcb587fdcaaf@acm.org>
On Tue, Jun 14, 2022 at 09:50:00AM -0700, Bart Van Assche wrote:
> On 6/14/22 02:09, Christoph Hellwig wrote:
>> get_max_io_size has a very odd choice of variables names and
>> initialization patterns. Switch to more descriptive names and more
>> clear initialization of them.
>
> Hmm ... what is so odd about the variable names? I have done my best to
> chose clear and descriptive names when I introduced these names.
Major confusion:
- we have a local variable to hold the queue max sectors value,
but it is callled sectors
- while we have a variable the holds the rounded end of the I/O
range that is called max_sectors
Minor confusion:
- a variable that hold that rounded start of the range has a random
_offset suffix despite not really being an offset
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH 4/6] block: cleanup variable naming in get_max_io_size
Date: Wed, 15 Jun 2022 08:27:29 +0200 [thread overview]
Message-ID: <20220615062729.GA22728@lst.de> (raw)
In-Reply-To: <4b846753-bb89-c123-2813-bcb587fdcaaf@acm.org>
On Tue, Jun 14, 2022 at 09:50:00AM -0700, Bart Van Assche wrote:
> On 6/14/22 02:09, Christoph Hellwig wrote:
>> get_max_io_size has a very odd choice of variables names and
>> initialization patterns. Switch to more descriptive names and more
>> clear initialization of them.
>
> Hmm ... what is so odd about the variable names? I have done my best to
> chose clear and descriptive names when I introduced these names.
Major confusion:
- we have a local variable to hold the queue max sectors value,
but it is callled sectors
- while we have a variable the holds the rounded end of the I/O
range that is called max_sectors
Minor confusion:
- a variable that hold that rounded start of the range has a random
_offset suffix despite not really being an offset
next prev parent reply other threads:[~2022-06-15 6:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 9:09 [dm-devel] clean up the chunk_sizehandling helpers a little Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 9:09 ` [dm-devel] [PATCH 1/6] block: factor out a chunk_size_left helper Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:39 ` [dm-devel] " Bart Van Assche
2022-06-14 16:39 ` Bart Van Assche
2022-06-15 10:32 ` [dm-devel] " Pankaj Raghav
2022-06-15 10:32 ` Pankaj Raghav
2022-06-16 23:05 ` [dm-devel] " Mike Snitzer
2022-06-16 23:05 ` Mike Snitzer
2022-06-17 6:22 ` [dm-devel] " Christoph Hellwig
2022-06-17 6:22 ` Christoph Hellwig
2022-06-14 9:09 ` [dm-devel] [PATCH 2/6] dm: open code blk_max_size_offset in max_io_len Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-16 23:21 ` [dm-devel] " Mike Snitzer
2022-06-16 23:21 ` Mike Snitzer
2022-06-14 9:09 ` [dm-devel] [PATCH 3/6] block: open code blk_max_size_offset in blk_rq_get_max_sectors Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:43 ` [dm-devel] " Bart Van Assche
2022-06-14 16:43 ` Bart Van Assche
2022-06-14 16:45 ` [dm-devel] " Bart Van Assche
2022-06-14 16:45 ` Bart Van Assche
2022-06-14 9:09 ` [dm-devel] [PATCH 4/6] block: cleanup variable naming in get_max_io_size Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:50 ` [dm-devel] " Bart Van Assche
2022-06-14 16:50 ` Bart Van Assche
2022-06-15 6:27 ` Christoph Hellwig [this message]
2022-06-15 6:27 ` Christoph Hellwig
2022-06-14 9:09 ` [dm-devel] [PATCH 5/6] block: fold blk_max_size_offset into get_max_io_size Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:51 ` [dm-devel] " Bart Van Assche
2022-06-14 16:51 ` Bart Van Assche
2022-06-15 10:48 ` [dm-devel] " Pankaj Raghav
2022-06-15 10:48 ` Pankaj Raghav
2022-06-14 9:09 ` [dm-devel] [PATCH 6/6] block: move blk_queue_get_max_sectors to blk.h Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:48 ` [dm-devel] " Bart Van Assche
2022-06-14 16:48 ` Bart Van Assche
2022-06-17 12:39 ` [dm-devel] clean up the chunk_sizehandling helpers a little Jens Axboe
2022-06-17 12:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615062729.GA22728@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.