From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Mike Snitzer <snitzer@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [dm-devel] [PATCH 1/6] block: factor out a chunk_size_left helper
Date: Fri, 17 Jun 2022 08:22:33 +0200 [thread overview]
Message-ID: <20220617062233.GA5079@lst.de> (raw)
In-Reply-To: <Yqu3TKf5MUwcnUty@redhat.com>
On Thu, Jun 16, 2022 at 07:05:48PM -0400, Mike Snitzer wrote:
> > + return min(q->limits.max_sectors,
> > + blk_chunk_sectors_left(offset, chunk_sectors));
> > }
>
> While you're at it, any reason not to use queue_max_sectors() here?
I'm not sure if it is a good reason, but this code sniplet goes
away later in the series, and all replacemens do use queue_max_sectors.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/6] block: factor out a chunk_size_left helper
Date: Fri, 17 Jun 2022 08:22:33 +0200 [thread overview]
Message-ID: <20220617062233.GA5079@lst.de> (raw)
In-Reply-To: <Yqu3TKf5MUwcnUty@redhat.com>
On Thu, Jun 16, 2022 at 07:05:48PM -0400, Mike Snitzer wrote:
> > + return min(q->limits.max_sectors,
> > + blk_chunk_sectors_left(offset, chunk_sectors));
> > }
>
> While you're at it, any reason not to use queue_max_sectors() here?
I'm not sure if it is a good reason, but this code sniplet goes
away later in the series, and all replacemens do use queue_max_sectors.
next prev parent reply other threads:[~2022-06-17 6:22 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 9:09 [dm-devel] clean up the chunk_sizehandling helpers a little Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 9:09 ` [dm-devel] [PATCH 1/6] block: factor out a chunk_size_left helper Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:39 ` [dm-devel] " Bart Van Assche
2022-06-14 16:39 ` Bart Van Assche
2022-06-15 10:32 ` [dm-devel] " Pankaj Raghav
2022-06-15 10:32 ` Pankaj Raghav
2022-06-16 23:05 ` [dm-devel] " Mike Snitzer
2022-06-16 23:05 ` Mike Snitzer
2022-06-17 6:22 ` Christoph Hellwig [this message]
2022-06-17 6:22 ` Christoph Hellwig
2022-06-14 9:09 ` [dm-devel] [PATCH 2/6] dm: open code blk_max_size_offset in max_io_len Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-16 23:21 ` [dm-devel] " Mike Snitzer
2022-06-16 23:21 ` Mike Snitzer
2022-06-14 9:09 ` [dm-devel] [PATCH 3/6] block: open code blk_max_size_offset in blk_rq_get_max_sectors Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:43 ` [dm-devel] " Bart Van Assche
2022-06-14 16:43 ` Bart Van Assche
2022-06-14 16:45 ` [dm-devel] " Bart Van Assche
2022-06-14 16:45 ` Bart Van Assche
2022-06-14 9:09 ` [dm-devel] [PATCH 4/6] block: cleanup variable naming in get_max_io_size Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:50 ` [dm-devel] " Bart Van Assche
2022-06-14 16:50 ` Bart Van Assche
2022-06-15 6:27 ` [dm-devel] " Christoph Hellwig
2022-06-15 6:27 ` Christoph Hellwig
2022-06-14 9:09 ` [dm-devel] [PATCH 5/6] block: fold blk_max_size_offset into get_max_io_size Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:51 ` [dm-devel] " Bart Van Assche
2022-06-14 16:51 ` Bart Van Assche
2022-06-15 10:48 ` [dm-devel] " Pankaj Raghav
2022-06-15 10:48 ` Pankaj Raghav
2022-06-14 9:09 ` [dm-devel] [PATCH 6/6] block: move blk_queue_get_max_sectors to blk.h Christoph Hellwig
2022-06-14 9:09 ` Christoph Hellwig
2022-06-14 16:48 ` [dm-devel] " Bart Van Assche
2022-06-14 16:48 ` Bart Van Assche
2022-06-17 12:39 ` [dm-devel] clean up the chunk_sizehandling helpers a little Jens Axboe
2022-06-17 12:39 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-10-13 17:12 [dm-devel] simplify I/O size calculation helpers v2 Christoph Hellwig
2021-10-13 17:12 ` [dm-devel] [PATCH 1/6] block: factor out a chunk_size_left helper Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617062233.GA5079@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.