From: Pavel Machek <pavel@ucw.cz>
To: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Samuel Holland <samuel@sholland.org>, Ondrej Jirman <x@xff.cz>,
Martijn Braam <martijn@brixit.nl>,
Ondrej Jirman <megous@megous.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Date: Wed, 15 Jun 2022 15:28:27 +0200 [thread overview]
Message-ID: <20220615132827.GB1429@bug> (raw)
In-Reply-To: <20220529031705.278631-3-tom@tom-fitzhenry.me.uk>
Hi!
> + // Per "RK 3399 SARADC", page 8.
> + adc-keys {
> + compatible = "adc-keys";
> + io-channels = <&saradc 1>;
> + io-channel-names = "buttons";
> + keyup-threshold-microvolt = <1600000>;
> + poll-interval = <100>;
> +
> + button-up {
> + label = "Volume Up";
> + linux,code = <KEY_VOLUMEUP>;
> + press-threshold-microvolt = <100000>;
> + };
> +
> + button-down {
> + label = "Volume Down";
> + linux,code = <KEY_VOLUMEDOWN>;
> + press-threshold-microvolt = <300000>;
> + };
> + };
Wow. Quite a hack...
> + // Per "RK3399 GPIO", page 11.
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&red_led_pin &green_led_pin &blue_led_pin>;
> + led-standby { + color = <LED_COLOR_ID_RED>; + default-state = "off"; + function =
I wish LED was connected to PWM, not to simple GPIO...
Plus, it is really one RGB LED, right? It should be handled as such.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Samuel Holland <samuel@sholland.org>, Ondrej Jirman <x@xff.cz>,
Martijn Braam <martijn@brixit.nl>,
Ondrej Jirman <megous@megous.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Date: Wed, 15 Jun 2022 15:28:27 +0200 [thread overview]
Message-ID: <20220615132827.GB1429@bug> (raw)
In-Reply-To: <20220529031705.278631-3-tom@tom-fitzhenry.me.uk>
Hi!
> + // Per "RK 3399 SARADC", page 8.
> + adc-keys {
> + compatible = "adc-keys";
> + io-channels = <&saradc 1>;
> + io-channel-names = "buttons";
> + keyup-threshold-microvolt = <1600000>;
> + poll-interval = <100>;
> +
> + button-up {
> + label = "Volume Up";
> + linux,code = <KEY_VOLUMEUP>;
> + press-threshold-microvolt = <100000>;
> + };
> +
> + button-down {
> + label = "Volume Down";
> + linux,code = <KEY_VOLUMEDOWN>;
> + press-threshold-microvolt = <300000>;
> + };
> + };
Wow. Quite a hack...
> + // Per "RK3399 GPIO", page 11.
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&red_led_pin &green_led_pin &blue_led_pin>;
> + led-standby { + color = <LED_COLOR_ID_RED>; + default-state = "off"; + function =
I wish LED was connected to PWM, not to simple GPIO...
Plus, it is really one RGB LED, right? It should be handled as such.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Samuel Holland <samuel@sholland.org>, Ondrej Jirman <x@xff.cz>,
Martijn Braam <martijn@brixit.nl>,
Ondrej Jirman <megous@megous.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Date: Wed, 15 Jun 2022 15:28:27 +0200 [thread overview]
Message-ID: <20220615132827.GB1429@bug> (raw)
In-Reply-To: <20220529031705.278631-3-tom@tom-fitzhenry.me.uk>
Hi!
> + // Per "RK 3399 SARADC", page 8.
> + adc-keys {
> + compatible = "adc-keys";
> + io-channels = <&saradc 1>;
> + io-channel-names = "buttons";
> + keyup-threshold-microvolt = <1600000>;
> + poll-interval = <100>;
> +
> + button-up {
> + label = "Volume Up";
> + linux,code = <KEY_VOLUMEUP>;
> + press-threshold-microvolt = <100000>;
> + };
> +
> + button-down {
> + label = "Volume Down";
> + linux,code = <KEY_VOLUMEDOWN>;
> + press-threshold-microvolt = <300000>;
> + };
> + };
Wow. Quite a hack...
> + // Per "RK3399 GPIO", page 11.
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&red_led_pin &green_led_pin &blue_led_pin>;
> + led-standby { + color = <LED_COLOR_ID_RED>; + default-state = "off"; + function =
I wish LED was connected to PWM, not to simple GPIO...
Plus, it is really one RGB LED, right? It should be handled as such.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2022-06-15 13:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 3:17 [PATCH 0/2] Add support for Pine64 PinePhonePro Linux phone Tom Fitzhenry
2022-05-29 3:17 ` Tom Fitzhenry
2022-05-29 3:17 ` Tom Fitzhenry
2022-05-29 3:17 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add PinePhone Pro bindings Tom Fitzhenry
2022-05-29 3:17 ` Tom Fitzhenry
2022-05-29 3:17 ` Tom Fitzhenry
2022-05-29 14:23 ` Krzysztof Kozlowski
2022-05-29 14:23 ` Krzysztof Kozlowski
2022-05-29 14:23 ` Krzysztof Kozlowski
2022-06-15 13:28 ` Pavel Machek
2022-06-15 13:28 ` Pavel Machek
2022-06-15 13:28 ` Pavel Machek
2022-05-29 3:17 ` [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro Tom Fitzhenry
2022-05-29 3:17 ` Tom Fitzhenry
2022-05-29 3:17 ` Tom Fitzhenry
2022-05-29 3:45 ` Tom Fitzhenry
2022-05-29 3:45 ` Tom Fitzhenry
2022-05-29 3:45 ` Tom Fitzhenry
2022-05-29 11:33 ` Ondřej Jirman
2022-05-29 11:33 ` Ondřej Jirman
2022-05-29 11:33 ` Ondřej Jirman
2022-05-29 11:53 ` Tom Fitzhenry
2022-05-29 11:53 ` Tom Fitzhenry
2022-05-29 11:53 ` Tom Fitzhenry
2022-05-29 14:26 ` Krzysztof Kozlowski
2022-05-29 14:26 ` Krzysztof Kozlowski
2022-05-29 14:26 ` Krzysztof Kozlowski
2022-06-15 13:28 ` Pavel Machek [this message]
2022-06-15 13:28 ` Pavel Machek
2022-06-15 13:28 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615132827.GB1429@bug \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martijn@brixit.nl \
--cc=megous@megous.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=tom@tom-fitzhenry.me.uk \
--cc=x@xff.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.