All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Colton Lewis <coltonlewis@google.com>
Cc: thuth@redhat.com, kvm@vger.kernel.org, maz@kernel.org,
	pbonzini@redhat.com, vkuznets@redhat.com,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 1/4] KVM: selftests: enumerate GUEST_ASSERT arguments
Date: Thu, 16 Jun 2022 14:47:05 +0200	[thread overview]
Message-ID: <20220616124705.wsll33usok4gfhqc@gator> (raw)
In-Reply-To: <20220615193116.806312-2-coltonlewis@google.com>

On Wed, Jun 15, 2022 at 07:31:13PM +0000, Colton Lewis wrote:
> Enumerate GUEST_ASSERT arguments to avoid magic indices to ucall.args.
> 
> Signed-off-by: Colton Lewis <coltonlewis@google.com>
> ---
>  tools/testing/selftests/kvm/include/ucall_common.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/testing/selftests/kvm/include/ucall_common.h b/tools/testing/selftests/kvm/include/ucall_common.h
> index 98562f685151..dbe872870b83 100644
> --- a/tools/testing/selftests/kvm/include/ucall_common.h
> +++ b/tools/testing/selftests/kvm/include/ucall_common.h
> @@ -32,6 +32,14 @@ uint64_t get_ucall(struct kvm_vcpu *vcpu, struct ucall *uc);
>  				ucall(UCALL_SYNC, 6, "hello", stage, arg1, arg2, arg3, arg4)
>  #define GUEST_SYNC(stage)	ucall(UCALL_SYNC, 2, "hello", stage)
>  #define GUEST_DONE()		ucall(UCALL_DONE, 0)
> +
> +enum guest_assert_builtin_args {
> +	GUEST_ERROR_STRING,
> +	GUEST_FILE,
> +	GUEST_LINE,
> +	GUEST_ASSERT_BUILTIN_NARGS
> +};
> +
>  #define __GUEST_ASSERT(_condition, _condstr, _nargs, _args...) do {    \
>  	if (!(_condition))                                              \
>  		ucall(UCALL_ABORT, 2 + _nargs,                          \
> -- 
> 2.36.1.476.g0c4daa206d-goog
>

Reviewed-by: Andrew Jones <drjones@redhat.com>

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <drjones@redhat.com>
To: Colton Lewis <coltonlewis@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com,
	thuth@redhat.com, maz@kernel.org
Subject: Re: [PATCH 1/4] KVM: selftests: enumerate GUEST_ASSERT arguments
Date: Thu, 16 Jun 2022 14:47:05 +0200	[thread overview]
Message-ID: <20220616124705.wsll33usok4gfhqc@gator> (raw)
In-Reply-To: <20220615193116.806312-2-coltonlewis@google.com>

On Wed, Jun 15, 2022 at 07:31:13PM +0000, Colton Lewis wrote:
> Enumerate GUEST_ASSERT arguments to avoid magic indices to ucall.args.
> 
> Signed-off-by: Colton Lewis <coltonlewis@google.com>
> ---
>  tools/testing/selftests/kvm/include/ucall_common.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/testing/selftests/kvm/include/ucall_common.h b/tools/testing/selftests/kvm/include/ucall_common.h
> index 98562f685151..dbe872870b83 100644
> --- a/tools/testing/selftests/kvm/include/ucall_common.h
> +++ b/tools/testing/selftests/kvm/include/ucall_common.h
> @@ -32,6 +32,14 @@ uint64_t get_ucall(struct kvm_vcpu *vcpu, struct ucall *uc);
>  				ucall(UCALL_SYNC, 6, "hello", stage, arg1, arg2, arg3, arg4)
>  #define GUEST_SYNC(stage)	ucall(UCALL_SYNC, 2, "hello", stage)
>  #define GUEST_DONE()		ucall(UCALL_DONE, 0)
> +
> +enum guest_assert_builtin_args {
> +	GUEST_ERROR_STRING,
> +	GUEST_FILE,
> +	GUEST_LINE,
> +	GUEST_ASSERT_BUILTIN_NARGS
> +};
> +
>  #define __GUEST_ASSERT(_condition, _condstr, _nargs, _args...) do {    \
>  	if (!(_condition))                                              \
>  		ucall(UCALL_ABORT, 2 + _nargs,                          \
> -- 
> 2.36.1.476.g0c4daa206d-goog
>

Reviewed-by: Andrew Jones <drjones@redhat.com>


  reply	other threads:[~2022-06-16 12:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 19:31 [PATCH 0/4] Fix filename reporting in guest asserts Colton Lewis
2022-06-15 19:31 ` Colton Lewis
2022-06-15 19:31 ` [PATCH 1/4] KVM: selftests: enumerate GUEST_ASSERT arguments Colton Lewis
2022-06-15 19:31   ` Colton Lewis
2022-06-16 12:47   ` Andrew Jones [this message]
2022-06-16 12:47     ` Andrew Jones
2022-06-15 19:31 ` [PATCH 2/4] KVM: selftests: Increase UCALL_MAX_ARGS to 7 Colton Lewis
2022-06-15 19:31   ` Colton Lewis
2022-06-16 12:10   ` Andrew Jones
2022-06-16 12:10     ` Andrew Jones
2022-06-17 17:05     ` Colton Lewis
2022-06-17 17:05       ` Colton Lewis
2022-06-18  0:09       ` Sean Christopherson
2022-06-18  0:09         ` Sean Christopherson
2022-06-20  7:21         ` Andrew Jones
2022-06-20  7:21           ` Andrew Jones
2022-06-20  8:59           ` Anup Patel
2022-06-20  8:59             ` Anup Patel
2022-06-20 13:20           ` Andrew Jones
2022-06-20 13:20             ` Andrew Jones
2022-06-20 13:21   ` Andrew Jones
2022-06-20 13:21     ` Andrew Jones
2022-06-15 19:31 ` [PATCH 3/4] KVM: selftests: Write REPORT_GUEST_ASSERT macros to pair with GUEST_ASSERT Colton Lewis
2022-06-15 19:31   ` Colton Lewis
2022-06-16 12:46   ` Andrew Jones
2022-06-16 12:46     ` Andrew Jones
2022-06-15 19:31 ` [PATCH 4/4] KVM: selftests: Fix filename reporting in guest asserts Colton Lewis
2022-06-15 19:31   ` Colton Lewis
2022-06-16 12:45   ` Andrew Jones
2022-06-16 12:45     ` Andrew Jones
2022-06-20 12:04     ` Paolo Bonzini
2022-06-20 12:04       ` Paolo Bonzini
2022-07-06 15:29       ` Colton Lewis
2022-07-06 15:29         ` Colton Lewis
2022-07-07  6:39         ` Andrew Jones
2022-07-07  6:39           ` Andrew Jones
2022-07-20 17:42 ` [PATCH 0/4] " Sean Christopherson
2022-07-20 17:42   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220616124705.wsll33usok4gfhqc@gator \
    --to=drjones@redhat.com \
    --cc=coltonlewis@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.