All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colton Lewis <coltonlewis@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: thuth@redhat.com, kvm@vger.kernel.org,
	Andrew Jones <drjones@redhat.com>,
	g@gator, maz@kernel.org, vkuznets@redhat.com,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 4/4] KVM: selftests: Fix filename reporting in guest asserts
Date: Wed, 6 Jul 2022 15:29:30 +0000	[thread overview]
Message-ID: <YsWqWkl8ymLFqxgY@google.com> (raw)
In-Reply-To: <2fc82066-f092-bc19-ae69-6852820f41ef@redhat.com>

On Mon, Jun 20, 2022 at 02:04:43PM +0200, Paolo Bonzini wrote:
> On 6/16/22 14:45, Andrew Jones wrote:
> > > +#define __GUEST_ASSERT(_condition, _condstr, _nargs, _args...) do {	\
> > > +		if (!(_condition))					\
> > > +			ucall(UCALL_ABORT, GUEST_ASSERT_BUILTIN_NARGS + _nargs,	\
> > > +			      "Failed guest assert: " _condstr,		\
> > > +			      __FILE__,					\
> > > +			      __LINE__,					\
> > > +			      ##_args);					\
> > We don't need another level of indentation nor the ## operator on _args.
> > 
> 
> The ## is needed to drop the comma if there are no _args.

I haven't heard anything more about part 4 of this patch in a while,
so I'm checking in that I didn't miss something requiring action on my
part.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Colton Lewis <coltonlewis@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>,
	kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	seanjc@google.com, vkuznets@redhat.com, thuth@redhat.com,
	maz@kernel.org, Ricardo Koller <ricarkol@google.com>,
	g@gator
Subject: Re: [PATCH 4/4] KVM: selftests: Fix filename reporting in guest asserts
Date: Wed, 6 Jul 2022 15:29:30 +0000	[thread overview]
Message-ID: <YsWqWkl8ymLFqxgY@google.com> (raw)
In-Reply-To: <2fc82066-f092-bc19-ae69-6852820f41ef@redhat.com>

On Mon, Jun 20, 2022 at 02:04:43PM +0200, Paolo Bonzini wrote:
> On 6/16/22 14:45, Andrew Jones wrote:
> > > +#define __GUEST_ASSERT(_condition, _condstr, _nargs, _args...) do {	\
> > > +		if (!(_condition))					\
> > > +			ucall(UCALL_ABORT, GUEST_ASSERT_BUILTIN_NARGS + _nargs,	\
> > > +			      "Failed guest assert: " _condstr,		\
> > > +			      __FILE__,					\
> > > +			      __LINE__,					\
> > > +			      ##_args);					\
> > We don't need another level of indentation nor the ## operator on _args.
> > 
> 
> The ## is needed to drop the comma if there are no _args.

I haven't heard anything more about part 4 of this patch in a while,
so I'm checking in that I didn't miss something requiring action on my
part.

  reply	other threads:[~2022-07-06 15:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 19:31 [PATCH 0/4] Fix filename reporting in guest asserts Colton Lewis
2022-06-15 19:31 ` Colton Lewis
2022-06-15 19:31 ` [PATCH 1/4] KVM: selftests: enumerate GUEST_ASSERT arguments Colton Lewis
2022-06-15 19:31   ` Colton Lewis
2022-06-16 12:47   ` Andrew Jones
2022-06-16 12:47     ` Andrew Jones
2022-06-15 19:31 ` [PATCH 2/4] KVM: selftests: Increase UCALL_MAX_ARGS to 7 Colton Lewis
2022-06-15 19:31   ` Colton Lewis
2022-06-16 12:10   ` Andrew Jones
2022-06-16 12:10     ` Andrew Jones
2022-06-17 17:05     ` Colton Lewis
2022-06-17 17:05       ` Colton Lewis
2022-06-18  0:09       ` Sean Christopherson
2022-06-18  0:09         ` Sean Christopherson
2022-06-20  7:21         ` Andrew Jones
2022-06-20  7:21           ` Andrew Jones
2022-06-20  8:59           ` Anup Patel
2022-06-20  8:59             ` Anup Patel
2022-06-20 13:20           ` Andrew Jones
2022-06-20 13:20             ` Andrew Jones
2022-06-20 13:21   ` Andrew Jones
2022-06-20 13:21     ` Andrew Jones
2022-06-15 19:31 ` [PATCH 3/4] KVM: selftests: Write REPORT_GUEST_ASSERT macros to pair with GUEST_ASSERT Colton Lewis
2022-06-15 19:31   ` Colton Lewis
2022-06-16 12:46   ` Andrew Jones
2022-06-16 12:46     ` Andrew Jones
2022-06-15 19:31 ` [PATCH 4/4] KVM: selftests: Fix filename reporting in guest asserts Colton Lewis
2022-06-15 19:31   ` Colton Lewis
2022-06-16 12:45   ` Andrew Jones
2022-06-16 12:45     ` Andrew Jones
2022-06-20 12:04     ` Paolo Bonzini
2022-06-20 12:04       ` Paolo Bonzini
2022-07-06 15:29       ` Colton Lewis [this message]
2022-07-06 15:29         ` Colton Lewis
2022-07-07  6:39         ` Andrew Jones
2022-07-07  6:39           ` Andrew Jones
2022-07-20 17:42 ` [PATCH 0/4] " Sean Christopherson
2022-07-20 17:42   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsWqWkl8ymLFqxgY@google.com \
    --to=coltonlewis@google.com \
    --cc=drjones@redhat.com \
    --cc=g@gator \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.