From: Jakub Kicinski <kuba@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: simon.horman@corigine.com, kurt@linutronix.de, paulb@nvidia.com,
edumazet@google.com, boris.sukholitko@broadcom.com,
jiri@resnulli.us, jesse.brandeburg@intel.com,
intel-wired-lan@lists.osuosl.org, zhangkaiheb@126.com,
pablo@netfilter.org, baowen.zheng@corigine.com,
komachi.yoshiki@gmail.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, pabeni@redhat.com,
netdev@vger.kernel.org, gustavoars@kernel.org,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors
Date: Tue, 28 Jun 2022 21:40:20 -0700 [thread overview]
Message-ID: <20220628214020.0f83fc21@kernel.org> (raw)
In-Reply-To: <20220628112918.11296-2-marcin.szycik@linux.intel.com>
On Tue, 28 Jun 2022 13:29:15 +0200 Marcin Szycik wrote:
> +static bool is_ppp_proto_supported(__be16 proto)
What does supported mean in this context?
> +{
> + switch (ntohs(proto)) {
> + case PPP_AT:
Byte swap on the constant.
> + case PPP_IPX:
> + case PPP_VJC_COMP:
> + case PPP_VJC_UNCOMP:
> + case PPP_MP:
> + case PPP_COMPFRAG:
> + case PPP_COMP:
> + case PPP_MPLS_UC:
> + case PPP_MPLS_MC:
> + case PPP_IPCP:
> + case PPP_ATCP:
> + case PPP_IPXCP:
> + case PPP_IPV6CP:
> + case PPP_CCPFRAG:
> + case PPP_MPLSCP:
> + case PPP_LCP:
> + case PPP_PAP:
> + case PPP_LQR:
> + case PPP_CHAP:
> + case PPP_CBCP:
> + return true;
> + default:
> + return false;
> + }
> +}
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
davem@davemloft.net, xiyou.wangcong@gmail.com,
jesse.brandeburg@intel.com, gustavoars@kernel.org,
baowen.zheng@corigine.com, boris.sukholitko@broadcom.com,
edumazet@google.com, jhs@mojatatu.com, jiri@resnulli.us,
kurt@linutronix.de, pablo@netfilter.org, pabeni@redhat.com,
paulb@nvidia.com, simon.horman@corigine.com,
komachi.yoshiki@gmail.com, zhangkaiheb@126.com,
intel-wired-lan@lists.osuosl.org,
michal.swiatkowski@linux.intel.com, wojciech.drewek@intel.com,
alexandr.lobakin@intel.com
Subject: Re: [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors
Date: Tue, 28 Jun 2022 21:40:20 -0700 [thread overview]
Message-ID: <20220628214020.0f83fc21@kernel.org> (raw)
In-Reply-To: <20220628112918.11296-2-marcin.szycik@linux.intel.com>
On Tue, 28 Jun 2022 13:29:15 +0200 Marcin Szycik wrote:
> +static bool is_ppp_proto_supported(__be16 proto)
What does supported mean in this context?
> +{
> + switch (ntohs(proto)) {
> + case PPP_AT:
Byte swap on the constant.
> + case PPP_IPX:
> + case PPP_VJC_COMP:
> + case PPP_VJC_UNCOMP:
> + case PPP_MP:
> + case PPP_COMPFRAG:
> + case PPP_COMP:
> + case PPP_MPLS_UC:
> + case PPP_MPLS_MC:
> + case PPP_IPCP:
> + case PPP_ATCP:
> + case PPP_IPXCP:
> + case PPP_IPV6CP:
> + case PPP_CCPFRAG:
> + case PPP_MPLSCP:
> + case PPP_LCP:
> + case PPP_PAP:
> + case PPP_LQR:
> + case PPP_CHAP:
> + case PPP_CBCP:
> + return true;
> + default:
> + return false;
> + }
> +}
next prev parent reply other threads:[~2022-06-29 4:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 11:29 [Intel-wired-lan] [RFC PATCH net-next v2 0/4] ice: PPPoE offload support Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-28 11:29 ` [Intel-wired-lan] [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-29 4:40 ` Jakub Kicinski [this message]
2022-06-29 4:40 ` Jakub Kicinski
2022-06-29 7:44 ` [Intel-wired-lan] " Drewek, Wojciech
2022-06-29 7:44 ` Drewek, Wojciech
2022-06-29 15:19 ` [Intel-wired-lan] " Jakub Kicinski
2022-06-29 15:19 ` Jakub Kicinski
2022-07-01 10:58 ` [Intel-wired-lan] " Drewek, Wojciech
2022-07-01 10:58 ` Drewek, Wojciech
2022-06-28 11:29 ` [Intel-wired-lan] [RFC PATCH net-next v2 2/4] net/sched: flower: Add PPPoE filter Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-28 11:29 ` [Intel-wired-lan] [RFC PATCH net-next v2 3/4] flow_offload: Introduce flow_match_pppoe Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-28 11:29 ` [Intel-wired-lan] [RFC PATCH net-next v2 4/4] ice: Add support for PPPoE hardware offload Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-29 4:39 ` [Intel-wired-lan] [RFC PATCH net-next v2 0/4] ice: PPPoE offload support Jakub Kicinski
2022-06-29 4:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628214020.0f83fc21@kernel.org \
--to=kuba@kernel.org \
--cc=baowen.zheng@corigine.com \
--cc=boris.sukholitko@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=komachi.yoshiki@gmail.com \
--cc=kurt@linutronix.de \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paulb@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zhangkaiheb@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.