From: Jakub Kicinski <kuba@kernel.org>
To: "Drewek, Wojciech" <wojciech.drewek@intel.com>
Cc: "simon.horman@corigine.com" <simon.horman@corigine.com>,
"kurt@linutronix.de" <kurt@linutronix.de>,
"paulb@nvidia.com" <paulb@nvidia.com>,
"edumazet@google.com" <edumazet@google.com>,
"boris.sukholitko@broadcom.com" <boris.sukholitko@broadcom.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"zhangkaiheb@126.com" <zhangkaiheb@126.com>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"baowen.zheng@corigine.com" <baowen.zheng@corigine.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"komachi.yoshiki@gmail.com" <komachi.yoshiki@gmail.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gustavoars@kernel.org" <gustavoars@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors
Date: Wed, 29 Jun 2022 08:19:37 -0700 [thread overview]
Message-ID: <20220629081937.7270e7d7@kernel.org> (raw)
In-Reply-To: <MW4PR11MB57761A084A3A556F4070F8CDFDBB9@MW4PR11MB5776.namprd11.prod.outlook.com>
On Wed, 29 Jun 2022 07:44:50 +0000 Drewek, Wojciech wrote:
> > > +static bool is_ppp_proto_supported(__be16 proto)
> >
> > What does supported mean in this context?
>
> It means that only those protocols are going to be dissected.
We only dissect PPP_IP and PPP_IPV6. This looks more like a list of all
known protocols.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: "Drewek, Wojciech" <wojciech.drewek@intel.com>
Cc: Marcin Szycik <marcin.szycik@linux.intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"gustavoars@kernel.org" <gustavoars@kernel.org>,
"baowen.zheng@corigine.com" <baowen.zheng@corigine.com>,
"boris.sukholitko@broadcom.com" <boris.sukholitko@broadcom.com>,
"edumazet@google.com" <edumazet@google.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"kurt@linutronix.de" <kurt@linutronix.de>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"paulb@nvidia.com" <paulb@nvidia.com>,
"simon.horman@corigine.com" <simon.horman@corigine.com>,
"komachi.yoshiki@gmail.com" <komachi.yoshiki@gmail.com>,
"zhangkaiheb@126.com" <zhangkaiheb@126.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"michal.swiatkowski@linux.intel.com"
<michal.swiatkowski@linux.intel.com>,
"Lobakin, Alexandr" <alexandr.lobakin@intel.com>
Subject: Re: [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors
Date: Wed, 29 Jun 2022 08:19:37 -0700 [thread overview]
Message-ID: <20220629081937.7270e7d7@kernel.org> (raw)
In-Reply-To: <MW4PR11MB57761A084A3A556F4070F8CDFDBB9@MW4PR11MB5776.namprd11.prod.outlook.com>
On Wed, 29 Jun 2022 07:44:50 +0000 Drewek, Wojciech wrote:
> > > +static bool is_ppp_proto_supported(__be16 proto)
> >
> > What does supported mean in this context?
>
> It means that only those protocols are going to be dissected.
We only dissect PPP_IP and PPP_IPV6. This looks more like a list of all
known protocols.
next prev parent reply other threads:[~2022-06-29 15:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 11:29 [Intel-wired-lan] [RFC PATCH net-next v2 0/4] ice: PPPoE offload support Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-28 11:29 ` [Intel-wired-lan] [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-29 4:40 ` [Intel-wired-lan] " Jakub Kicinski
2022-06-29 4:40 ` Jakub Kicinski
2022-06-29 7:44 ` [Intel-wired-lan] " Drewek, Wojciech
2022-06-29 7:44 ` Drewek, Wojciech
2022-06-29 15:19 ` Jakub Kicinski [this message]
2022-06-29 15:19 ` Jakub Kicinski
2022-07-01 10:58 ` [Intel-wired-lan] " Drewek, Wojciech
2022-07-01 10:58 ` Drewek, Wojciech
2022-06-28 11:29 ` [Intel-wired-lan] [RFC PATCH net-next v2 2/4] net/sched: flower: Add PPPoE filter Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-28 11:29 ` [Intel-wired-lan] [RFC PATCH net-next v2 3/4] flow_offload: Introduce flow_match_pppoe Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-28 11:29 ` [Intel-wired-lan] [RFC PATCH net-next v2 4/4] ice: Add support for PPPoE hardware offload Marcin Szycik
2022-06-28 11:29 ` Marcin Szycik
2022-06-29 4:39 ` [Intel-wired-lan] [RFC PATCH net-next v2 0/4] ice: PPPoE offload support Jakub Kicinski
2022-06-29 4:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629081937.7270e7d7@kernel.org \
--to=kuba@kernel.org \
--cc=baowen.zheng@corigine.com \
--cc=boris.sukholitko@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=komachi.yoshiki@gmail.com \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paulb@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=wojciech.drewek@intel.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zhangkaiheb@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.