From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
robdclark@gmail.com, quic_abhinavk@quicinc.com,
dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org,
quic_mkrishn@quicinc.com, swboyd@chromium.org,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
Date: Fri, 1 Jul 2022 13:57:00 -0600 [thread overview]
Message-ID: <20220701195700.GA1413048-robh@kernel.org> (raw)
In-Reply-To: <ff3caa0b-a248-d5ee-a3e5-c49fc41b8cff@linaro.org>
On Thu, Jun 30, 2022 at 08:59:03PM +0200, Krzysztof Kozlowski wrote:
> On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> > The driver doesn't care about the name of the phy in DTS. msm8916 has since
> > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
> >
> > There's no reason to have a constraint on the name here, simply to have a
> > name. Remove the redundant const in favour of maxItems: 1.
>
> For single entry the names field could be as well removed. But if it is
> there, let's make it specific, not generic. Therefore instead add
> allOf:if:then restricting it per variants.
If we really don't care, an if/then seems excessive. Just mark as
deprecated and remove it in all the dts files.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: freedreno@lists.freedesktop.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
airlied@linux.ie, linux-arm-msm@vger.kernel.org,
quic_abhinavk@quicinc.com, dri-devel@lists.freedesktop.org,
swboyd@chromium.org, quic_mkrishn@quicinc.com,
dmitry.baryshkov@linaro.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
bjorn.andersson@linaro.org, sean@poorly.run
Subject: Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
Date: Fri, 1 Jul 2022 13:57:00 -0600 [thread overview]
Message-ID: <20220701195700.GA1413048-robh@kernel.org> (raw)
In-Reply-To: <ff3caa0b-a248-d5ee-a3e5-c49fc41b8cff@linaro.org>
On Thu, Jun 30, 2022 at 08:59:03PM +0200, Krzysztof Kozlowski wrote:
> On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> > The driver doesn't care about the name of the phy in DTS. msm8916 has since
> > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
> >
> > There's no reason to have a constraint on the name here, simply to have a
> > name. Remove the redundant const in favour of maxItems: 1.
>
> For single entry the names field could be as well removed. But if it is
> there, let's make it specific, not generic. Therefore instead add
> allOf:if:then restricting it per variants.
If we really don't care, an if/then seems excessive. Just mark as
deprecated and remove it in all the dts files.
Rob
next prev parent reply other threads:[~2022-07-01 19:57 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 12:08 [PATCH 0/7] msm8916/msm8939 DSI controller and DSI PHY bindings fixes Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 12:08 ` [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:06 ` Dmitry Baryshkov
2022-06-30 17:06 ` Dmitry Baryshkov
2022-06-30 18:59 ` Krzysztof Kozlowski
2022-06-30 18:59 ` Krzysztof Kozlowski
2022-07-01 19:57 ` Rob Herring [this message]
2022-07-01 19:57 ` Rob Herring
2022-07-01 20:08 ` Rob Herring
2022-07-01 20:08 ` Rob Herring
2022-06-30 12:08 ` [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:07 ` Dmitry Baryshkov
2022-06-30 17:07 ` Dmitry Baryshkov
2022-06-30 19:00 ` Krzysztof Kozlowski
2022-06-30 19:00 ` Krzysztof Kozlowski
2022-06-30 12:08 ` [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:15 ` Dmitry Baryshkov
2022-06-30 17:15 ` Dmitry Baryshkov
2022-06-30 19:01 ` Krzysztof Kozlowski
2022-06-30 19:01 ` Krzysztof Kozlowski
2022-06-30 19:49 ` Bryan O'Donoghue
2022-06-30 19:49 ` Bryan O'Donoghue
2022-06-30 20:18 ` [Freedreno] " Stephan Gerhold
2022-06-30 20:18 ` Stephan Gerhold
2022-06-30 12:08 ` [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:16 ` Dmitry Baryshkov
2022-06-30 17:16 ` Dmitry Baryshkov
2022-06-30 17:30 ` Bryan O'Donoghue
2022-06-30 17:30 ` Bryan O'Donoghue
2022-06-30 19:03 ` Krzysztof Kozlowski
2022-06-30 19:03 ` Krzysztof Kozlowski
2022-06-30 19:02 ` Krzysztof Kozlowski
2022-06-30 19:02 ` Krzysztof Kozlowski
2022-06-30 12:08 ` [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:21 ` Dmitry Baryshkov
2022-06-30 17:21 ` Dmitry Baryshkov
2022-06-30 19:04 ` Krzysztof Kozlowski
2022-06-30 19:04 ` Krzysztof Kozlowski
2022-06-30 12:08 ` [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:20 ` Dmitry Baryshkov
2022-06-30 17:20 ` Dmitry Baryshkov
2022-06-30 19:05 ` Krzysztof Kozlowski
2022-06-30 19:05 ` Krzysztof Kozlowski
2022-07-06 12:57 ` Dmitry Baryshkov
2022-07-06 12:57 ` Dmitry Baryshkov
2022-06-30 12:08 ` [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode Bryan O'Donoghue
2022-06-30 12:08 ` [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom, dsi-phy-regulator-ldo-mode Bryan O'Donoghue
2022-06-30 17:18 ` [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode Dmitry Baryshkov
2022-06-30 17:18 ` Dmitry Baryshkov
2022-06-30 19:07 ` Krzysztof Kozlowski
2022-06-30 19:07 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701195700.GA1413048-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.