From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com,
dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org,
quic_mkrishn@quicinc.com, swboyd@chromium.org,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
Date: Fri, 1 Jul 2022 14:08:09 -0600 [thread overview]
Message-ID: <20220701200809.GA1433418-robh@kernel.org> (raw)
In-Reply-To: <20220630120845.3356144-2-bryan.odonoghue@linaro.org>
On Thu, Jun 30, 2022 at 01:08:39PM +0100, Bryan O'Donoghue wrote:
> The driver doesn't care about the name of the phy in DTS. msm8916 has since
> 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
Also, for the subject, it's 'phy-names' not 'phy-name'.
> There's no reason to have a constraint on the name here, simply to have a
> name. Remove the redundant const in favour of maxItems: 1.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 880bfe930830c..717a5d255ffe4 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -49,7 +49,7 @@ properties:
> maxItems: 1
>
> phy-names:
> - const: dsi
> + maxItems: 1
>
> "#address-cells": true
>
> --
> 2.36.1
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: freedreno@lists.freedesktop.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
airlied@linux.ie, linux-arm-msm@vger.kernel.org,
quic_abhinavk@quicinc.com, dri-devel@lists.freedesktop.org,
swboyd@chromium.org, quic_mkrishn@quicinc.com,
dmitry.baryshkov@linaro.org, bjorn.andersson@linaro.org,
sean@poorly.run
Subject: Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
Date: Fri, 1 Jul 2022 14:08:09 -0600 [thread overview]
Message-ID: <20220701200809.GA1433418-robh@kernel.org> (raw)
In-Reply-To: <20220630120845.3356144-2-bryan.odonoghue@linaro.org>
On Thu, Jun 30, 2022 at 01:08:39PM +0100, Bryan O'Donoghue wrote:
> The driver doesn't care about the name of the phy in DTS. msm8916 has since
> 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
Also, for the subject, it's 'phy-names' not 'phy-name'.
> There's no reason to have a constraint on the name here, simply to have a
> name. Remove the redundant const in favour of maxItems: 1.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 880bfe930830c..717a5d255ffe4 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -49,7 +49,7 @@ properties:
> maxItems: 1
>
> phy-names:
> - const: dsi
> + maxItems: 1
>
> "#address-cells": true
>
> --
> 2.36.1
>
>
next prev parent reply other threads:[~2022-07-01 20:08 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 12:08 [PATCH 0/7] msm8916/msm8939 DSI controller and DSI PHY bindings fixes Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 12:08 ` [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:06 ` Dmitry Baryshkov
2022-06-30 17:06 ` Dmitry Baryshkov
2022-06-30 18:59 ` Krzysztof Kozlowski
2022-06-30 18:59 ` Krzysztof Kozlowski
2022-07-01 19:57 ` Rob Herring
2022-07-01 19:57 ` Rob Herring
2022-07-01 20:08 ` Rob Herring [this message]
2022-07-01 20:08 ` Rob Herring
2022-06-30 12:08 ` [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:07 ` Dmitry Baryshkov
2022-06-30 17:07 ` Dmitry Baryshkov
2022-06-30 19:00 ` Krzysztof Kozlowski
2022-06-30 19:00 ` Krzysztof Kozlowski
2022-06-30 12:08 ` [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:15 ` Dmitry Baryshkov
2022-06-30 17:15 ` Dmitry Baryshkov
2022-06-30 19:01 ` Krzysztof Kozlowski
2022-06-30 19:01 ` Krzysztof Kozlowski
2022-06-30 19:49 ` Bryan O'Donoghue
2022-06-30 19:49 ` Bryan O'Donoghue
2022-06-30 20:18 ` [Freedreno] " Stephan Gerhold
2022-06-30 20:18 ` Stephan Gerhold
2022-06-30 12:08 ` [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:16 ` Dmitry Baryshkov
2022-06-30 17:16 ` Dmitry Baryshkov
2022-06-30 17:30 ` Bryan O'Donoghue
2022-06-30 17:30 ` Bryan O'Donoghue
2022-06-30 19:03 ` Krzysztof Kozlowski
2022-06-30 19:03 ` Krzysztof Kozlowski
2022-06-30 19:02 ` Krzysztof Kozlowski
2022-06-30 19:02 ` Krzysztof Kozlowski
2022-06-30 12:08 ` [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:21 ` Dmitry Baryshkov
2022-06-30 17:21 ` Dmitry Baryshkov
2022-06-30 19:04 ` Krzysztof Kozlowski
2022-06-30 19:04 ` Krzysztof Kozlowski
2022-06-30 12:08 ` [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML Bryan O'Donoghue
2022-06-30 12:08 ` Bryan O'Donoghue
2022-06-30 17:20 ` Dmitry Baryshkov
2022-06-30 17:20 ` Dmitry Baryshkov
2022-06-30 19:05 ` Krzysztof Kozlowski
2022-06-30 19:05 ` Krzysztof Kozlowski
2022-07-06 12:57 ` Dmitry Baryshkov
2022-07-06 12:57 ` Dmitry Baryshkov
2022-06-30 12:08 ` [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode Bryan O'Donoghue
2022-06-30 12:08 ` [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom, dsi-phy-regulator-ldo-mode Bryan O'Donoghue
2022-06-30 17:18 ` [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode Dmitry Baryshkov
2022-06-30 17:18 ` Dmitry Baryshkov
2022-06-30 19:07 ` Krzysztof Kozlowski
2022-06-30 19:07 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701200809.GA1433418-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.