* [PATCH 0/7] msm8916/msm8939 DSI controller and DSI PHY bindings fixes
@ 2022-06-30 12:08 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
This series fixes up a number of dtbs checks which are being flagged adding
in the msm8939 dtsi.
When converting from .txt to .yaml a number of the parameters for the older
msm8916 silicon were not transmitted into the yaml.
Adding in the msm8939 which is a near 1:1 copy of the msm8916 in terms of
dtsi triggers a rake of dtbs checks as a result.
Bryan O'Donoghue (7):
dt-bindings: msm: dsi: Fix phy-name binding
dt-bindings: msm: dsi: Fix operating-points-v2 constraint
dt-bindings: msm: dsi: Fix power-domains constraint
dt-bindings: msm: dsi: Add vdd* descriptions back in
dt-bindings: msm: dsi: Fix clock declarations
dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML
dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode
.../display/msm/dsi-controller-main.yaml | 39 ++++++++++++++-----
.../bindings/display/msm/dsi-phy-28nm.yaml | 20 ++++++++++
2 files changed, 49 insertions(+), 10 deletions(-)
--
2.36.1
^ permalink raw reply [flat|nested] 58+ messages in thread
* [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 12:08 ` Bryan O'Donoghue
-1 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
The driver doesn't care about the name of the phy in DTS. msm8916 has since
2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
There's no reason to have a constraint on the name here, simply to have a
name. Remove the redundant const in favour of maxItems: 1.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 880bfe930830c..717a5d255ffe4 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -49,7 +49,7 @@ properties:
maxItems: 1
phy-names:
- const: dsi
+ maxItems: 1
"#address-cells": true
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
@ 2022-06-30 12:08 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
The driver doesn't care about the name of the phy in DTS. msm8916 has since
2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
There's no reason to have a constraint on the name here, simply to have a
name. Remove the redundant const in favour of maxItems: 1.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 880bfe930830c..717a5d255ffe4 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -49,7 +49,7 @@ properties:
maxItems: 1
phy-names:
- const: dsi
+ maxItems: 1
"#address-cells": true
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 17:06 ` Dmitry Baryshkov
-1 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:06 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
On 30 June 2022 15:08:39 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>The driver doesn't care about the name of the phy in DTS. msm8916 has since
>2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
>
>There's no reason to have a constraint on the name here, simply to have a
>name. Remove the redundant const in favour of maxItems: 1.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index 880bfe930830c..717a5d255ffe4 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -49,7 +49,7 @@ properties:
> maxItems: 1
>
> phy-names:
>- const: dsi
>+ maxItems: 1
>
> "#address-cells": true
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
@ 2022-06-30 17:06 ` Dmitry Baryshkov
0 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:06 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
On 30 June 2022 15:08:39 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>The driver doesn't care about the name of the phy in DTS. msm8916 has since
>2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
>
>There's no reason to have a constraint on the name here, simply to have a
>name. Remove the redundant const in favour of maxItems: 1.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index 880bfe930830c..717a5d255ffe4 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -49,7 +49,7 @@ properties:
> maxItems: 1
>
> phy-names:
>- const: dsi
>+ maxItems: 1
>
> "#address-cells": true
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 18:59 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 18:59 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> The driver doesn't care about the name of the phy in DTS. msm8916 has since
> 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
>
> There's no reason to have a constraint on the name here, simply to have a
> name. Remove the redundant const in favour of maxItems: 1.
For single entry the names field could be as well removed. But if it is
there, let's make it specific, not generic. Therefore instead add
allOf:if:then restricting it per variants.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
@ 2022-06-30 18:59 ` Krzysztof Kozlowski
0 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 18:59 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> The driver doesn't care about the name of the phy in DTS. msm8916 has since
> 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
>
> There's no reason to have a constraint on the name here, simply to have a
> name. Remove the redundant const in favour of maxItems: 1.
For single entry the names field could be as well removed. But if it is
there, let's make it specific, not generic. Therefore instead add
allOf:if:then restricting it per variants.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
2022-06-30 18:59 ` Krzysztof Kozlowski
@ 2022-07-01 19:57 ` Rob Herring
-1 siblings, 0 replies; 58+ messages in thread
From: Rob Herring @ 2022-07-01 19:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, krzysztof.kozlowski+dt, quic_mkrishn,
swboyd, bjorn.andersson, linux-arm-msm, dri-devel, freedreno,
devicetree
On Thu, Jun 30, 2022 at 08:59:03PM +0200, Krzysztof Kozlowski wrote:
> On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> > The driver doesn't care about the name of the phy in DTS. msm8916 has since
> > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
> >
> > There's no reason to have a constraint on the name here, simply to have a
> > name. Remove the redundant const in favour of maxItems: 1.
>
> For single entry the names field could be as well removed. But if it is
> there, let's make it specific, not generic. Therefore instead add
> allOf:if:then restricting it per variants.
If we really don't care, an if/then seems excessive. Just mark as
deprecated and remove it in all the dts files.
Rob
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
@ 2022-07-01 19:57 ` Rob Herring
0 siblings, 0 replies; 58+ messages in thread
From: Rob Herring @ 2022-07-01 19:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: freedreno, krzysztof.kozlowski+dt, devicetree, airlied,
linux-arm-msm, quic_abhinavk, dri-devel, swboyd, quic_mkrishn,
dmitry.baryshkov, Bryan O'Donoghue, bjorn.andersson, sean
On Thu, Jun 30, 2022 at 08:59:03PM +0200, Krzysztof Kozlowski wrote:
> On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> > The driver doesn't care about the name of the phy in DTS. msm8916 has since
> > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
> >
> > There's no reason to have a constraint on the name here, simply to have a
> > name. Remove the redundant const in favour of maxItems: 1.
>
> For single entry the names field could be as well removed. But if it is
> there, let's make it specific, not generic. Therefore instead add
> allOf:if:then restricting it per variants.
If we really don't care, an if/then seems excessive. Just mark as
deprecated and remove it in all the dts files.
Rob
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-07-01 20:08 ` Rob Herring
-1 siblings, 0 replies; 58+ messages in thread
From: Rob Herring @ 2022-07-01 20:08 UTC (permalink / raw)
To: Bryan O'Donoghue
Cc: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
krzysztof.kozlowski+dt, quic_mkrishn, swboyd, bjorn.andersson,
linux-arm-msm, dri-devel, freedreno, devicetree
On Thu, Jun 30, 2022 at 01:08:39PM +0100, Bryan O'Donoghue wrote:
> The driver doesn't care about the name of the phy in DTS. msm8916 has since
> 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
Also, for the subject, it's 'phy-names' not 'phy-name'.
> There's no reason to have a constraint on the name here, simply to have a
> name. Remove the redundant const in favour of maxItems: 1.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 880bfe930830c..717a5d255ffe4 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -49,7 +49,7 @@ properties:
> maxItems: 1
>
> phy-names:
> - const: dsi
> + maxItems: 1
>
> "#address-cells": true
>
> --
> 2.36.1
>
>
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 1/7] dt-bindings: msm: dsi: Fix phy-name binding
@ 2022-07-01 20:08 ` Rob Herring
0 siblings, 0 replies; 58+ messages in thread
From: Rob Herring @ 2022-07-01 20:08 UTC (permalink / raw)
To: Bryan O'Donoghue
Cc: freedreno, krzysztof.kozlowski+dt, devicetree, airlied,
linux-arm-msm, quic_abhinavk, dri-devel, swboyd, quic_mkrishn,
dmitry.baryshkov, bjorn.andersson, sean
On Thu, Jun 30, 2022 at 01:08:39PM +0100, Bryan O'Donoghue wrote:
> The driver doesn't care about the name of the phy in DTS. msm8916 has since
> 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi".
Also, for the subject, it's 'phy-names' not 'phy-name'.
> There's no reason to have a constraint on the name here, simply to have a
> name. Remove the redundant const in favour of maxItems: 1.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 880bfe930830c..717a5d255ffe4 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -49,7 +49,7 @@ properties:
> maxItems: 1
>
> phy-names:
> - const: dsi
> + maxItems: 1
>
> "#address-cells": true
>
> --
> 2.36.1
>
>
^ permalink raw reply [flat|nested] 58+ messages in thread
* [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 12:08 ` Bryan O'Donoghue
-1 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
The existing msm8916.dtsi does not depend on nor require operating points.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 717a5d255ffe4..101adec8d9152 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -137,7 +137,6 @@ required:
- assigned-clocks
- assigned-clock-parents
- power-domains
- - operating-points-v2
- ports
additionalProperties: false
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint
@ 2022-06-30 12:08 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
The existing msm8916.dtsi does not depend on nor require operating points.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 717a5d255ffe4..101adec8d9152 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -137,7 +137,6 @@ required:
- assigned-clocks
- assigned-clock-parents
- power-domains
- - operating-points-v2
- ports
additionalProperties: false
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* Re: [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 17:07 ` Dmitry Baryshkov
-1 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:07 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
On 30 June 2022 15:08:40 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>The existing msm8916.dtsi does not depend on nor require operating points.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index 717a5d255ffe4..101adec8d9152 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -137,7 +137,6 @@ required:
> - assigned-clocks
> - assigned-clock-parents
> - power-domains
>- - operating-points-v2
> - ports
>
> additionalProperties: false
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint
@ 2022-06-30 17:07 ` Dmitry Baryshkov
0 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:07 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
On 30 June 2022 15:08:40 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>The existing msm8916.dtsi does not depend on nor require operating points.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index 717a5d255ffe4..101adec8d9152 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -137,7 +137,6 @@ required:
> - assigned-clocks
> - assigned-clock-parents
> - power-domains
>- - operating-points-v2
> - ports
>
> additionalProperties: false
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 19:00 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:00 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> The existing msm8916.dtsi does not depend on nor require operating points.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 2/7] dt-bindings: msm: dsi: Fix operating-points-v2 constraint
@ 2022-06-30 19:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:00 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> The existing msm8916.dtsi does not depend on nor require operating points.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread
* [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 12:08 ` Bryan O'Donoghue
-1 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
The existing msm8916.dtsi does not depend on nor require power-domains.
Drop from the list of required.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 101adec8d9152..91324f0828448 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -136,7 +136,6 @@ required:
- phy-names
- assigned-clocks
- assigned-clock-parents
- - power-domains
- ports
additionalProperties: false
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
@ 2022-06-30 12:08 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
The existing msm8916.dtsi does not depend on nor require power-domains.
Drop from the list of required.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 101adec8d9152..91324f0828448 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -136,7 +136,6 @@ required:
- phy-names
- assigned-clocks
- assigned-clock-parents
- - power-domains
- ports
additionalProperties: false
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* Re: [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 17:15 ` Dmitry Baryshkov
-1 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:15 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
On 30 June 2022 15:08:41 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>The existing msm8916.dtsi does not depend on nor require power-domains.
>Drop from the list of required.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index 101adec8d9152..91324f0828448 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -136,7 +136,6 @@ required:
> - phy-names
> - assigned-clocks
> - assigned-clock-parents
>- - power-domains
> - ports
>
> additionalProperties: false
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
@ 2022-06-30 17:15 ` Dmitry Baryshkov
0 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:15 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
On 30 June 2022 15:08:41 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>The existing msm8916.dtsi does not depend on nor require power-domains.
>Drop from the list of required.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index 101adec8d9152..91324f0828448 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -136,7 +136,6 @@ required:
> - phy-names
> - assigned-clocks
> - assigned-clock-parents
>- - power-domains
> - ports
>
> additionalProperties: false
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 19:01 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:01 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> The existing msm8916.dtsi does not depend on nor require power-domains.
> Drop from the list of required.
That's not good reason. The bindings are about hardware so the question
is whether being a part of power domain or toggling power domain on/off
is considered required for the DSI.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 101adec8d9152..91324f0828448 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -136,7 +136,6 @@ required:
> - phy-names
> - assigned-clocks
> - assigned-clock-parents
> - - power-domains
> - ports
>
> additionalProperties: false
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
@ 2022-06-30 19:01 ` Krzysztof Kozlowski
0 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:01 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> The existing msm8916.dtsi does not depend on nor require power-domains.
> Drop from the list of required.
That's not good reason. The bindings are about hardware so the question
is whether being a part of power domain or toggling power domain on/off
is considered required for the DSI.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 101adec8d9152..91324f0828448 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -136,7 +136,6 @@ required:
> - phy-names
> - assigned-clocks
> - assigned-clock-parents
> - - power-domains
> - ports
>
> additionalProperties: false
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
2022-06-30 19:01 ` Krzysztof Kozlowski
@ 2022-06-30 19:49 ` Bryan O'Donoghue
-1 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 19:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 20:01, Krzysztof Kozlowski wrote:
> On 30/06/2022 14:08, Bryan O'Donoghue wrote:
>> The existing msm8916.dtsi does not depend on nor require power-domains.
>> Drop from the list of required.
>
> That's not good reason. The bindings are about hardware so the question
> is whether being a part of power domain or toggling power domain on/off
> is considered required for the DSI.
AFAIK no but, I will check this again and if it is definitely not
required, I'll churn the commit log to describe it better.
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
@ 2022-06-30 19:49 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 19:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 20:01, Krzysztof Kozlowski wrote:
> On 30/06/2022 14:08, Bryan O'Donoghue wrote:
>> The existing msm8916.dtsi does not depend on nor require power-domains.
>> Drop from the list of required.
>
> That's not good reason. The bindings are about hardware so the question
> is whether being a part of power domain or toggling power domain on/off
> is considered required for the DSI.
AFAIK no but, I will check this again and if it is definitely not
required, I'll churn the commit log to describe it better.
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [Freedreno] [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
2022-06-30 19:49 ` Bryan O'Donoghue
@ 2022-06-30 20:18 ` Stephan Gerhold
-1 siblings, 0 replies; 58+ messages in thread
From: Stephan Gerhold @ 2022-06-30 20:18 UTC (permalink / raw)
To: Bryan O'Donoghue
Cc: Krzysztof Kozlowski, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt,
devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On Thu, Jun 30, 2022 at 08:49:03PM +0100, Bryan O'Donoghue wrote:
> On 30/06/2022 20:01, Krzysztof Kozlowski wrote:
> > On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> > > The existing msm8916.dtsi does not depend on nor require power-domains.
> > > Drop from the list of required.
> >
> > That's not good reason. The bindings are about hardware so the question
> > is whether being a part of power domain or toggling power domain on/off
> > is considered required for the DSI.
>
> AFAIK no but, I will check this again and if it is definitely not required,
> I'll churn the commit log to describe it better.
>
The power domain in the DSI node is used together with the OPP table to
vote for performance states depending on the clock frequency of the byte
clock. In the downstream kernel this is part of the clock driver.
In mainline this needs to be done in the consumer driver.
The MSM8916 port was never really optimized for power usage. With
incomplete interconnect support etc the power domains tend to be at
maximum state most of the time, so it does not cause any issues if you
forget to vote for performance states in some places.
In general, the situation on MSM8916/MSM8939 is not really any different
from newer SoCs. The downstream MSM8916 gcc driver contains:
static struct rcg_clk byte0_clk_src = {
/* ... */
.c = {
/* ... */
VDD_DIG_FMAX_MAP2(LOW, 94400000, NOMINAL, 188500000),
},
};
which should be ideally translated into an OPP table with
power-domains = <&rpmpd MSM8916_VDDCX>; similar to newer SoCs.
(I'm not saying that "power-domains" should be required, just that it
could be added for MSM8916/MSM8939 if someone wants to properly
power-optimize them...)
Thanks,
Stephan
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [Freedreno] [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint
@ 2022-06-30 20:18 ` Stephan Gerhold
0 siblings, 0 replies; 58+ messages in thread
From: Stephan Gerhold @ 2022-06-30 20:18 UTC (permalink / raw)
To: Bryan O'Donoghue
Cc: devicetree, krzysztof.kozlowski+dt, airlied, linux-arm-msm,
swboyd, freedreno, dri-devel, quic_abhinavk, Krzysztof Kozlowski,
robh+dt, quic_mkrishn, dmitry.baryshkov, bjorn.andersson, sean
On Thu, Jun 30, 2022 at 08:49:03PM +0100, Bryan O'Donoghue wrote:
> On 30/06/2022 20:01, Krzysztof Kozlowski wrote:
> > On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> > > The existing msm8916.dtsi does not depend on nor require power-domains.
> > > Drop from the list of required.
> >
> > That's not good reason. The bindings are about hardware so the question
> > is whether being a part of power domain or toggling power domain on/off
> > is considered required for the DSI.
>
> AFAIK no but, I will check this again and if it is definitely not required,
> I'll churn the commit log to describe it better.
>
The power domain in the DSI node is used together with the OPP table to
vote for performance states depending on the clock frequency of the byte
clock. In the downstream kernel this is part of the clock driver.
In mainline this needs to be done in the consumer driver.
The MSM8916 port was never really optimized for power usage. With
incomplete interconnect support etc the power domains tend to be at
maximum state most of the time, so it does not cause any issues if you
forget to vote for performance states in some places.
In general, the situation on MSM8916/MSM8939 is not really any different
from newer SoCs. The downstream MSM8916 gcc driver contains:
static struct rcg_clk byte0_clk_src = {
/* ... */
.c = {
/* ... */
VDD_DIG_FMAX_MAP2(LOW, 94400000, NOMINAL, 188500000),
},
};
which should be ideally translated into an OPP table with
power-domains = <&rpmpd MSM8916_VDDCX>; similar to newer SoCs.
(I'm not saying that "power-domains" should be required, just that it
could be added for MSM8916/MSM8939 if someone wants to properly
power-optimize them...)
Thanks,
Stephan
^ permalink raw reply [flat|nested] 58+ messages in thread
* [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 12:08 ` Bryan O'Donoghue
-1 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
When converting from .txt to .yaml we didn't include descriptions for the
existing regulator supplies.
- vdd
- vdda
- vddio
Add those descriptions into the yaml now as they were prior to the
conversion.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/display/msm/dsi-controller-main.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 91324f0828448..fd9d472437853 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -125,6 +125,18 @@ properties:
- port@0
- port@1
+ vdd-supply:
+ description:
+ Phandle to vdd regulator device node
+
+ vddio-supply:
+ description:
+ Phandle to vdd regulator device node
+
+ vdda-supply:
+ description:
+ Phandle to vdd regulator device node
+
required:
- compatible
- reg
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
@ 2022-06-30 12:08 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
When converting from .txt to .yaml we didn't include descriptions for the
existing regulator supplies.
- vdd
- vdda
- vddio
Add those descriptions into the yaml now as they were prior to the
conversion.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/display/msm/dsi-controller-main.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index 91324f0828448..fd9d472437853 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -125,6 +125,18 @@ properties:
- port@0
- port@1
+ vdd-supply:
+ description:
+ Phandle to vdd regulator device node
+
+ vddio-supply:
+ description:
+ Phandle to vdd regulator device node
+
+ vdda-supply:
+ description:
+ Phandle to vdd regulator device node
+
required:
- compatible
- reg
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* Re: [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 17:16 ` Dmitry Baryshkov
-1 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:16 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
On 30 June 2022 15:08:42 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>When converting from .txt to .yaml we didn't include descriptions for the
>existing regulator supplies.
>
>- vdd
>- vdda
>- vddio
>
>Add those descriptions into the yaml now as they were prior to the
>conversion.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>---
> .../bindings/display/msm/dsi-controller-main.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index 91324f0828448..fd9d472437853 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -125,6 +125,18 @@ properties:
> - port@0
> - port@1
>
>+ vdd-supply:
>+ description:
>+ Phandle to vdd regulator device node
>+
>+ vddio-supply:
>+ description:
>+ Phandle to vdd regulator device node
>+
>+ vdda-supply:
>+ description:
>+ Phandle to vdd regulator device node
All three descriptions are the same. This looks like a c&p issue
>+
> required:
> - compatible
> - reg
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
@ 2022-06-30 17:16 ` Dmitry Baryshkov
0 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:16 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
On 30 June 2022 15:08:42 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>When converting from .txt to .yaml we didn't include descriptions for the
>existing regulator supplies.
>
>- vdd
>- vdda
>- vddio
>
>Add those descriptions into the yaml now as they were prior to the
>conversion.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>---
> .../bindings/display/msm/dsi-controller-main.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index 91324f0828448..fd9d472437853 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -125,6 +125,18 @@ properties:
> - port@0
> - port@1
>
>+ vdd-supply:
>+ description:
>+ Phandle to vdd regulator device node
>+
>+ vddio-supply:
>+ description:
>+ Phandle to vdd regulator device node
>+
>+ vdda-supply:
>+ description:
>+ Phandle to vdd regulator device node
All three descriptions are the same. This looks like a c&p issue
>+
> required:
> - compatible
> - reg
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
2022-06-30 17:16 ` Dmitry Baryshkov
@ 2022-06-30 17:30 ` Bryan O'Donoghue
-1 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 17:30 UTC (permalink / raw)
To: Dmitry Baryshkov, robdclark, quic_abhinavk, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 18:16, Dmitry Baryshkov wrote:
>
> All three descriptions are the same. This looks like a c&p issue
Those are what the previous values were.
I'll come up with something less robotic though.
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
@ 2022-06-30 17:30 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 17:30 UTC (permalink / raw)
To: Dmitry Baryshkov, robdclark, quic_abhinavk, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 18:16, Dmitry Baryshkov wrote:
>
> All three descriptions are the same. This looks like a c&p issue
Those are what the previous values were.
I'll come up with something less robotic though.
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
2022-06-30 17:30 ` Bryan O'Donoghue
@ 2022-06-30 19:03 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:03 UTC (permalink / raw)
To: Bryan O'Donoghue, Dmitry Baryshkov, robdclark, quic_abhinavk,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 19:30, Bryan O'Donoghue wrote:
> On 30/06/2022 18:16, Dmitry Baryshkov wrote:
>>
>> All three descriptions are the same. This looks like a c&p issue
>
> Those are what the previous values were.
>
No, original TXT had different descriptions:
-- vdd-supply: phandle to vdd regulator device node
-- vddio-supply: phandle to vdd-io regulator device node
-- vdda-supply: phandle to vdda regulator device node
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
@ 2022-06-30 19:03 ` Krzysztof Kozlowski
0 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:03 UTC (permalink / raw)
To: Bryan O'Donoghue, Dmitry Baryshkov, robdclark, quic_abhinavk,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 19:30, Bryan O'Donoghue wrote:
> On 30/06/2022 18:16, Dmitry Baryshkov wrote:
>>
>> All three descriptions are the same. This looks like a c&p issue
>
> Those are what the previous values were.
>
No, original TXT had different descriptions:
-- vdd-supply: phandle to vdd regulator device node
-- vddio-supply: phandle to vdd-io regulator device node
-- vdda-supply: phandle to vdda regulator device node
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 19:02 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:02 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml we didn't include descriptions for the
> existing regulator supplies.
>
> - vdd
> - vdda
> - vddio
>
> Add those descriptions into the yaml now as they were prior to the
> conversion.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/display/msm/dsi-controller-main.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 91324f0828448..fd9d472437853 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -125,6 +125,18 @@ properties:
> - port@0
> - port@1
>
> + vdd-supply:
> + description:
> + Phandle to vdd regulator device node
> +
> + vddio-supply:
> + description:
> + Phandle to vdd regulator device node
> +
> + vdda-supply:
> + description:
> + Phandle to vdd regulator device node
> +
They should be also added to required fields, because before they were
required.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 4/7] dt-bindings: msm: dsi: Add vdd* descriptions back in
@ 2022-06-30 19:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:02 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml we didn't include descriptions for the
> existing regulator supplies.
>
> - vdd
> - vdda
> - vddio
>
> Add those descriptions into the yaml now as they were prior to the
> conversion.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/display/msm/dsi-controller-main.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 91324f0828448..fd9d472437853 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -125,6 +125,18 @@ properties:
> - port@0
> - port@1
>
> + vdd-supply:
> + description:
> + Phandle to vdd regulator device node
> +
> + vddio-supply:
> + description:
> + Phandle to vdd regulator device node
> +
> + vdda-supply:
> + description:
> + Phandle to vdd regulator device node
> +
They should be also added to required fields, because before they were
required.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread
* [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 12:08 ` Bryan O'Donoghue
-1 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
When converting from .txt to .yaml dt-binding descriptions we appear to
have missed some of the previous detail on the number and names of
permissible clocks.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../display/msm/dsi-controller-main.yaml | 23 +++++++++++++------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index fd9d472437853..b24ba6c346a77 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -28,22 +28,31 @@ properties:
maxItems: 1
clocks:
- items:
- - description: Display byte clock
- - description: Display byte interface clock
- - description: Display pixel clock
- - description: Display escape clock
- - description: Display AHB clock
- - description: Display AXI clock
+ minItems: 6
+ maxItems: 9
clock-names:
items:
- const: byte
+ description: Display byte clock
- const: byte_intf
+ description: Display byte interface clock
- const: pixel
+ description: Display pixel clock
- const: core
+ description: Display escape clock
- const: iface
+ description: Display AHB clock
- const: bus
+ description: Display AXI clock
+ - const: core_mmss
+ description: Core MultiMedia SubSystem clock
+ - const: mdp_core
+ description: MDP Core clock
+ - const: mnoc
+ description: MNOC clock
+ minItems: 6
+ maxItems: 9
phys:
maxItems: 1
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations
@ 2022-06-30 12:08 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
When converting from .txt to .yaml dt-binding descriptions we appear to
have missed some of the previous detail on the number and names of
permissible clocks.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../display/msm/dsi-controller-main.yaml | 23 +++++++++++++------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
index fd9d472437853..b24ba6c346a77 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -28,22 +28,31 @@ properties:
maxItems: 1
clocks:
- items:
- - description: Display byte clock
- - description: Display byte interface clock
- - description: Display pixel clock
- - description: Display escape clock
- - description: Display AHB clock
- - description: Display AXI clock
+ minItems: 6
+ maxItems: 9
clock-names:
items:
- const: byte
+ description: Display byte clock
- const: byte_intf
+ description: Display byte interface clock
- const: pixel
+ description: Display pixel clock
- const: core
+ description: Display escape clock
- const: iface
+ description: Display AHB clock
- const: bus
+ description: Display AXI clock
+ - const: core_mmss
+ description: Core MultiMedia SubSystem clock
+ - const: mdp_core
+ description: MDP Core clock
+ - const: mnoc
+ description: MNOC clock
+ minItems: 6
+ maxItems: 9
phys:
maxItems: 1
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* Re: [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 17:21 ` Dmitry Baryshkov
-1 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:21 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
On 30 June 2022 15:08:43 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>When converting from .txt to .yaml dt-binding descriptions we appear to
>have missed some of the previous detail on the number and names of
>permissible clocks.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>---
> .../display/msm/dsi-controller-main.yaml | 23 +++++++++++++------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index fd9d472437853..b24ba6c346a77 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -28,22 +28,31 @@ properties:
> maxItems: 1
>
> clocks:
>- items:
>- - description: Display byte clock
>- - description: Display byte interface clock
>- - description: Display pixel clock
>- - description: Display escape clock
>- - description: Display AHB clock
>- - description: Display AXI clock
>+ minItems: 6
>+ maxItems: 9
Please leave descriptions here. They are better suited for the clocks rather than clock-names.
With that fixed:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> clock-names:
> items:
> - const: byte
>+ description: Display byte clock
> - const: byte_intf
>+ description: Display byte interface clock
> - const: pixel
>+ description: Display pixel clock
> - const: core
>+ description: Display escape clock
> - const: iface
>+ description: Display AHB clock
> - const: bus
>+ description: Display AXI clock
>+ - const: core_mmss
>+ description: Core MultiMedia SubSystem clock
>+ - const: mdp_core
>+ description: MDP Core clock
>+ - const: mnoc
>+ description: MNOC clock
>+ minItems: 6
>+ maxItems: 9
>
> phys:
> maxItems: 1
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations
@ 2022-06-30 17:21 ` Dmitry Baryshkov
0 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:21 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
On 30 June 2022 15:08:43 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>When converting from .txt to .yaml dt-binding descriptions we appear to
>have missed some of the previous detail on the number and names of
>permissible clocks.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>---
> .../display/msm/dsi-controller-main.yaml | 23 +++++++++++++------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index fd9d472437853..b24ba6c346a77 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -28,22 +28,31 @@ properties:
> maxItems: 1
>
> clocks:
>- items:
>- - description: Display byte clock
>- - description: Display byte interface clock
>- - description: Display pixel clock
>- - description: Display escape clock
>- - description: Display AHB clock
>- - description: Display AXI clock
>+ minItems: 6
>+ maxItems: 9
Please leave descriptions here. They are better suited for the clocks rather than clock-names.
With that fixed:
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> clock-names:
> items:
> - const: byte
>+ description: Display byte clock
> - const: byte_intf
>+ description: Display byte interface clock
> - const: pixel
>+ description: Display pixel clock
> - const: core
>+ description: Display escape clock
> - const: iface
>+ description: Display AHB clock
> - const: bus
>+ description: Display AXI clock
>+ - const: core_mmss
>+ description: Core MultiMedia SubSystem clock
>+ - const: mdp_core
>+ description: MDP Core clock
>+ - const: mnoc
>+ description: MNOC clock
>+ minItems: 6
>+ maxItems: 9
>
> phys:
> maxItems: 1
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 19:04 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:04 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml dt-binding descriptions we appear to
> have missed some of the previous detail on the number and names of
> permissible clocks.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../display/msm/dsi-controller-main.yaml | 23 +++++++++++++------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index fd9d472437853..b24ba6c346a77 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -28,22 +28,31 @@ properties:
> maxItems: 1
>
> clocks:
> - items:
> - - description: Display byte clock
> - - description: Display byte interface clock
> - - description: Display pixel clock
> - - description: Display escape clock
> - - description: Display AHB clock
> - - description: Display AXI clock
> + minItems: 6
> + maxItems: 9
>
> clock-names:
> items:
> - const: byte
> + description: Display byte clock
Descriptions should stay where they were. Just add minItems and new items.
> - const: byte_intf
> + description: Display byte interface clock
> - const: pixel
> + description: Display pixel clock
> - const: core
> + description: Display escape clock
> - const: iface
> + description: Display AHB clock
> - const: bus
> + description: Display AXI clock
> + - const: core_mmss
> + description: Core MultiMedia SubSystem clock
> + - const: mdp_core
> + description: MDP Core clock
> + - const: mnoc
> + description: MNOC clock
> + minItems: 6
> + maxItems: 9
maxItems are not needed.
>
> phys:
> maxItems: 1
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations
@ 2022-06-30 19:04 ` Krzysztof Kozlowski
0 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:04 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml dt-binding descriptions we appear to
> have missed some of the previous detail on the number and names of
> permissible clocks.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../display/msm/dsi-controller-main.yaml | 23 +++++++++++++------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index fd9d472437853..b24ba6c346a77 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -28,22 +28,31 @@ properties:
> maxItems: 1
>
> clocks:
> - items:
> - - description: Display byte clock
> - - description: Display byte interface clock
> - - description: Display pixel clock
> - - description: Display escape clock
> - - description: Display AHB clock
> - - description: Display AXI clock
> + minItems: 6
> + maxItems: 9
>
> clock-names:
> items:
> - const: byte
> + description: Display byte clock
Descriptions should stay where they were. Just add minItems and new items.
> - const: byte_intf
> + description: Display byte interface clock
> - const: pixel
> + description: Display pixel clock
> - const: core
> + description: Display escape clock
> - const: iface
> + description: Display AHB clock
> - const: bus
> + description: Display AXI clock
> + - const: core_mmss
> + description: Core MultiMedia SubSystem clock
> + - const: mdp_core
> + description: MDP Core clock
> + - const: mnoc
> + description: MNOC clock
> + minItems: 6
> + maxItems: 9
maxItems are not needed.
>
> phys:
> maxItems: 1
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread
* [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 12:08 ` Bryan O'Donoghue
-1 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
Add in missing clock and clock-names declarations to the 28nm DSI PHY.
When converting from .txt to .yaml we missed these.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
index 3d8540a06fe22..9ecd513d93661 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
@@ -19,6 +19,21 @@ properties:
- qcom,dsi-phy-28nm-lp
- qcom,dsi-phy-28nm-8960
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: iface
+ description: AHB clock
+ - const: iface_clk
+ description: AHB clock
+ - const: ref
+ description: Block reference clock
+ minItems: 1
+ maxItems: 2
+
reg:
items:
- description: dsi pll register set
@@ -36,6 +51,8 @@ properties:
required:
- compatible
+ - clocks
+ - clock-names
- reg
- reg-names
- vddio-supply
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML
@ 2022-06-30 12:08 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
Add in missing clock and clock-names declarations to the 28nm DSI PHY.
When converting from .txt to .yaml we missed these.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
index 3d8540a06fe22..9ecd513d93661 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
@@ -19,6 +19,21 @@ properties:
- qcom,dsi-phy-28nm-lp
- qcom,dsi-phy-28nm-8960
+ clocks:
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: iface
+ description: AHB clock
+ - const: iface_clk
+ description: AHB clock
+ - const: ref
+ description: Block reference clock
+ minItems: 1
+ maxItems: 2
+
reg:
items:
- description: dsi pll register set
@@ -36,6 +51,8 @@ properties:
required:
- compatible
+ - clocks
+ - clock-names
- reg
- reg-names
- vddio-supply
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* Re: [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 17:20 ` Dmitry Baryshkov
-1 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:20 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
On 30 June 2022 15:08:44 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>Add in missing clock and clock-names declarations to the 28nm DSI PHY.
>When converting from .txt to .yaml we missed these.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>---
> .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>index 3d8540a06fe22..9ecd513d93661 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>@@ -19,6 +19,21 @@ properties:
> - qcom,dsi-phy-28nm-lp
> - qcom,dsi-phy-28nm-8960
>
>+ clocks:
>+ minItems: 1
>+ maxItems: 2
>+
>+ clock-names:
>+ items:
>+ - const: iface
>+ description: AHB clock
>+ - const: iface_clk
>+ description: AHB clock
>+ - const: ref
>+ description: Block reference clock
>+ minItems: 1
>+ maxItems: 2
This looks incorrect. You have 3 items, but maxItems in 2
Also I'd put description to the clocks node. Clock-names are self-descriptive enough.
>+
> reg:
> items:
> - description: dsi pll register set
>@@ -36,6 +51,8 @@ properties:
>
> required:
> - compatible
>+ - clocks
>+ - clock-names
> - reg
> - reg-names
> - vddio-supply
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML
@ 2022-06-30 17:20 ` Dmitry Baryshkov
0 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:20 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
On 30 June 2022 15:08:44 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>Add in missing clock and clock-names declarations to the 28nm DSI PHY.
>When converting from .txt to .yaml we missed these.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>---
> .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>index 3d8540a06fe22..9ecd513d93661 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>@@ -19,6 +19,21 @@ properties:
> - qcom,dsi-phy-28nm-lp
> - qcom,dsi-phy-28nm-8960
>
>+ clocks:
>+ minItems: 1
>+ maxItems: 2
>+
>+ clock-names:
>+ items:
>+ - const: iface
>+ description: AHB clock
>+ - const: iface_clk
>+ description: AHB clock
>+ - const: ref
>+ description: Block reference clock
>+ minItems: 1
>+ maxItems: 2
This looks incorrect. You have 3 items, but maxItems in 2
Also I'd put description to the clocks node. Clock-names are self-descriptive enough.
>+
> reg:
> items:
> - description: dsi pll register set
>@@ -36,6 +51,8 @@ properties:
>
> required:
> - compatible
>+ - clocks
>+ - clock-names
> - reg
> - reg-names
> - vddio-supply
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 19:05 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:05 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> Add in missing clock and clock-names declarations to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed these.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
You need to fix all your subject prefixes. It's confusing to see again
clocks being fixed for the DSI bindings.
dt-bindings: msm: dsi-phy-28nm:
and similarly for other cases.
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> index 3d8540a06fe22..9ecd513d93661 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> @@ -19,6 +19,21 @@ properties:
> - qcom,dsi-phy-28nm-lp
> - qcom,dsi-phy-28nm-8960
>
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: iface
> + description: AHB clock
Descriptions goes to clocks.
> + - const: iface_clk
> + description: AHB clock
> + - const: ref
> + description: Block reference clock
> + minItems: 1
> + maxItems: 2
Did you test it? Three items vs maxItems:2?
> +
> reg:
> items:
> - description: dsi pll register set
> @@ -36,6 +51,8 @@ properties:
>
> required:
> - compatible
> + - clocks
> + - clock-names
> - reg
> - reg-names
> - vddio-supply
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML
@ 2022-06-30 19:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:05 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> Add in missing clock and clock-names declarations to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed these.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
You need to fix all your subject prefixes. It's confusing to see again
clocks being fixed for the DSI bindings.
dt-bindings: msm: dsi-phy-28nm:
and similarly for other cases.
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> index 3d8540a06fe22..9ecd513d93661 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> @@ -19,6 +19,21 @@ properties:
> - qcom,dsi-phy-28nm-lp
> - qcom,dsi-phy-28nm-8960
>
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: iface
> + description: AHB clock
Descriptions goes to clocks.
> + - const: iface_clk
> + description: AHB clock
> + - const: ref
> + description: Block reference clock
> + minItems: 1
> + maxItems: 2
Did you test it? Three items vs maxItems:2?
> +
> reg:
> items:
> - description: dsi pll register set
> @@ -36,6 +51,8 @@ properties:
>
> required:
> - compatible
> + - clocks
> + - clock-names
> - reg
> - reg-names
> - vddio-supply
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-07-06 12:57 ` Dmitry Baryshkov
-1 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-07-06 12:57 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 15:08, Bryan O'Donoghue wrote:
> Add in missing clock and clock-names declarations to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed these.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
I checked the schema. I think you can drop this patch. The issue that
you probably saw with apq8064 should be solved in the dtsi, not in the
schema.
> ---
> .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> index 3d8540a06fe22..9ecd513d93661 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> @@ -19,6 +19,21 @@ properties:
> - qcom,dsi-phy-28nm-lp
> - qcom,dsi-phy-28nm-8960
>
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: iface
> + description: AHB clock
> + - const: iface_clk
> + description: AHB clock
> + - const: ref
> + description: Block reference clock
> + minItems: 1
> + maxItems: 2
> +
> reg:
> items:
> - description: dsi pll register set
> @@ -36,6 +51,8 @@ properties:
>
> required:
> - compatible
> + - clocks
> + - clock-names
> - reg
> - reg-names
> - vddio-supply
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML
@ 2022-07-06 12:57 ` Dmitry Baryshkov
0 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-07-06 12:57 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 15:08, Bryan O'Donoghue wrote:
> Add in missing clock and clock-names declarations to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed these.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
I checked the schema. I think you can drop this patch. The issue that
you probably saw with apq8064 should be solved in the dtsi, not in the
schema.
> ---
> .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> index 3d8540a06fe22..9ecd513d93661 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> @@ -19,6 +19,21 @@ properties:
> - qcom,dsi-phy-28nm-lp
> - qcom,dsi-phy-28nm-8960
>
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: iface
> + description: AHB clock
> + - const: iface_clk
> + description: AHB clock
> + - const: ref
> + description: Block reference clock
> + minItems: 1
> + maxItems: 2
> +
> reg:
> items:
> - description: dsi pll register set
> @@ -36,6 +51,8 @@ properties:
>
> required:
> - compatible
> + - clocks
> + - clock-names
> - reg
> - reg-names
> - vddio-supply
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread
* [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode
2022-06-30 12:08 ` Bryan O'Donoghue
@ 2022-06-30 12:08 ` Bryan O'Donoghue
-1 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
When converting from .txt to .yaml we missed this one.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/display/msm/dsi-phy-28nm.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
index 9ecd513d93661..3551e166db966 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
@@ -40,6 +40,9 @@ properties:
- description: dsi phy register set
- description: dsi phy regulator register set
+ qcom,dsi-phy-regulator-ldo-mode:
+ description: Boolean value indicating if the LDO mode PHY regulator is wanted.
+
reg-names:
items:
- const: dsi_pll
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom, dsi-phy-regulator-ldo-mode
@ 2022-06-30 12:08 ` Bryan O'Donoghue
0 siblings, 0 replies; 58+ messages in thread
From: Bryan O'Donoghue @ 2022-06-30 12:08 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
When converting from .txt to .yaml we missed this one.
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../devicetree/bindings/display/msm/dsi-phy-28nm.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
index 9ecd513d93661..3551e166db966 100644
--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
@@ -40,6 +40,9 @@ properties:
- description: dsi phy register set
- description: dsi phy regulator register set
+ qcom,dsi-phy-regulator-ldo-mode:
+ description: Boolean value indicating if the LDO mode PHY regulator is wanted.
+
reg-names:
items:
- const: dsi_pll
--
2.36.1
^ permalink raw reply related [flat|nested] 58+ messages in thread* Re: [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode
2022-06-30 12:08 ` [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom, dsi-phy-regulator-ldo-mode Bryan O'Donoghue
@ 2022-06-30 17:18 ` Dmitry Baryshkov
-1 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:18 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree, bryan.odonoghue
On 30 June 2022 15:08:45 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
>When converting from .txt to .yaml we missed this one.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>---
> .../devicetree/bindings/display/msm/dsi-phy-28nm.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>index 9ecd513d93661..3551e166db966 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>@@ -40,6 +40,9 @@ properties:
> - description: dsi phy register set
> - description: dsi phy regulator register set
>
>+ qcom,dsi-phy-regulator-ldo-mode:
>+ description: Boolean value indicating if the LDO mode PHY regulator is wanted.
>+
> reg-names:
> items:
> - const: dsi_pll
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode
@ 2022-06-30 17:18 ` Dmitry Baryshkov
0 siblings, 0 replies; 58+ messages in thread
From: Dmitry Baryshkov @ 2022-06-30 17:18 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, sean, airlied,
daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, bryan.odonoghue, swboyd, freedreno
On 30 June 2022 15:08:45 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
>When converting from .txt to .yaml we missed this one.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>---
> .../devicetree/bindings/display/msm/dsi-phy-28nm.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>index 9ecd513d93661..3551e166db966 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
>@@ -40,6 +40,9 @@ properties:
> - description: dsi phy register set
> - description: dsi phy regulator register set
>
>+ qcom,dsi-phy-regulator-ldo-mode:
>+ description: Boolean value indicating if the LDO mode PHY regulator is wanted.
>+
> reg-names:
> items:
> - const: dsi_pll
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 58+ messages in thread
* Re: [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode
2022-06-30 12:08 ` [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom, dsi-phy-regulator-ldo-mode Bryan O'Donoghue
@ 2022-06-30 19:07 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:07 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: quic_mkrishn, swboyd, bjorn.andersson, linux-arm-msm, dri-devel,
freedreno, devicetree
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed this one.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dsi-phy-28nm.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> index 9ecd513d93661..3551e166db966 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> @@ -40,6 +40,9 @@ properties:
> - description: dsi phy register set
> - description: dsi phy regulator register set
>
> + qcom,dsi-phy-regulator-ldo-mode:
> + description: Boolean value indicating if the LDO mode PHY regulator is wanted.
You need type:boolean. Didn't dt_bindings_check complain?
Then description can be shorter "Whether the LDO mode PHY regulator is
wanted."
> +
> reg-names:
> items:
> - const: dsi_pll
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread* Re: [PATCH 7/7] dt-bindings: msm: dsi: Add missing qcom,dsi-phy-regulator-ldo-mode
@ 2022-06-30 19:07 ` Krzysztof Kozlowski
0 siblings, 0 replies; 58+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-30 19:07 UTC (permalink / raw)
To: Bryan O'Donoghue, robdclark, quic_abhinavk, dmitry.baryshkov,
sean, airlied, daniel, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, linux-arm-msm, dri-devel, bjorn.andersson,
quic_mkrishn, swboyd, freedreno
On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> Add in missing qcom,dsi-phy-regulator-ldo-mode to the 28nm DSI PHY.
> When converting from .txt to .yaml we missed this one.
>
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dsi-phy-28nm.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> index 9ecd513d93661..3551e166db966 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml
> @@ -40,6 +40,9 @@ properties:
> - description: dsi phy register set
> - description: dsi phy regulator register set
>
> + qcom,dsi-phy-regulator-ldo-mode:
> + description: Boolean value indicating if the LDO mode PHY regulator is wanted.
You need type:boolean. Didn't dt_bindings_check complain?
Then description can be shorter "Whether the LDO mode PHY regulator is
wanted."
> +
> reg-names:
> items:
> - const: dsi_pll
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 58+ messages in thread