From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] tools/virtio: drop phys_addr_t typedef
Date: Tue, 12 Jul 2022 08:30:27 -0400 [thread overview]
Message-ID: <20220712083021-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <DU0PR04MB94176F8C95FB297B4FCAD4D988869@DU0PR04MB9417.eurprd04.prod.outlook.com>
Will do.
On Tue, Jul 12, 2022 at 04:59:44AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] tools/virtio: drop phys_addr_t typedef
>
> Would anyone pick up this patch? Or any comments?
>
> Thanks,
> Peng.
>
> >
> > On Mon, Apr 11, 2022 at 9:39 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > wrote:
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > With commit 884ee1e585ca ("tools/include: Add phys_addr_t to
> > > types.h"),
> > >
> > > When building virtio tools, there is a type conficting error:
> > >
> > > "
> > > ./linux/kernel.h:32:28: error: conflicting types for ‘phys_addr_t’
> > > 32 | typedef unsigned long long phys_addr_t;
> > > | ^~~~~~~~~~~
> > > In file included from /usr/include/linux/virtio_blk.h:28,
> > > from virtio-ivshmem-block.c:29:
> > > ../include/linux/types.h:69:13: note: previous declaration of ‘phys_addr_t’
> > was here
> > > 69 | typedef u32 phys_addr_t;
> > > | ^~~~~~~~~~~
> > > "
> > >
> > > Let's drop the typedef in tools/virtio/linux/kernel.h
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >
> > Acked-by: Jason Wang <jasowang@redhat.com>
> >
> > > ---
> > > tools/virtio/linux/kernel.h | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> > > index 0b493542e61a..1d3248e3f270 100644
> > > --- a/tools/virtio/linux/kernel.h
> > > +++ b/tools/virtio/linux/kernel.h
> > > @@ -29,7 +29,6 @@
> > > #define READ 0
> > > #define WRITE 1
> > >
> > > -typedef unsigned long long phys_addr_t; typedef unsigned long long
> > > dma_addr_t; typedef size_t __kernel_size_t; typedef unsigned int
> > > __wsum;
> > > --
> > > 2.25.1
> > >
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: Jason Wang <jasowang@redhat.com>,
virtualization <virtualization@lists.linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools/virtio: drop phys_addr_t typedef
Date: Tue, 12 Jul 2022 08:30:27 -0400 [thread overview]
Message-ID: <20220712083021-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <DU0PR04MB94176F8C95FB297B4FCAD4D988869@DU0PR04MB9417.eurprd04.prod.outlook.com>
Will do.
On Tue, Jul 12, 2022 at 04:59:44AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] tools/virtio: drop phys_addr_t typedef
>
> Would anyone pick up this patch? Or any comments?
>
> Thanks,
> Peng.
>
> >
> > On Mon, Apr 11, 2022 at 9:39 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> > wrote:
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > With commit 884ee1e585ca ("tools/include: Add phys_addr_t to
> > > types.h"),
> > >
> > > When building virtio tools, there is a type conficting error:
> > >
> > > "
> > > ./linux/kernel.h:32:28: error: conflicting types for ‘phys_addr_t’
> > > 32 | typedef unsigned long long phys_addr_t;
> > > | ^~~~~~~~~~~
> > > In file included from /usr/include/linux/virtio_blk.h:28,
> > > from virtio-ivshmem-block.c:29:
> > > ../include/linux/types.h:69:13: note: previous declaration of ‘phys_addr_t’
> > was here
> > > 69 | typedef u32 phys_addr_t;
> > > | ^~~~~~~~~~~
> > > "
> > >
> > > Let's drop the typedef in tools/virtio/linux/kernel.h
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >
> > Acked-by: Jason Wang <jasowang@redhat.com>
> >
> > > ---
> > > tools/virtio/linux/kernel.h | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> > > index 0b493542e61a..1d3248e3f270 100644
> > > --- a/tools/virtio/linux/kernel.h
> > > +++ b/tools/virtio/linux/kernel.h
> > > @@ -29,7 +29,6 @@
> > > #define READ 0
> > > #define WRITE 1
> > >
> > > -typedef unsigned long long phys_addr_t; typedef unsigned long long
> > > dma_addr_t; typedef size_t __kernel_size_t; typedef unsigned int
> > > __wsum;
> > > --
> > > 2.25.1
> > >
>
next prev parent reply other threads:[~2022-07-12 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 1:40 [PATCH] tools/virtio: drop phys_addr_t typedef Peng Fan (OSS)
2022-04-11 8:52 ` Jason Wang
2022-04-11 8:52 ` Jason Wang
2022-07-12 4:59 ` Peng Fan
2022-07-12 4:59 ` Peng Fan
2022-07-12 12:30 ` Michael S. Tsirkin [this message]
2022-07-12 12:30 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712083021-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.