From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
Parikshit Pareek <quic_ppareek@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Prasanna Kumar <quic_kprasan@quicinc.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sc8280xp: fix apps_smmu irq
Date: Tue, 12 Jul 2022 23:56:27 +0530 [thread overview]
Message-ID: <20220712182627.GA7766@thinkpad> (raw)
In-Reply-To: <CAA8EJprN-Y2cFR=9TSCw6Db8GAJC8eh08FgFBmxumEKt0iGPBw@mail.gmail.com>
On Tue, Jul 12, 2022 at 07:41:14PM +0300, Dmitry Baryshkov wrote:
> On Tue, 12 Jul 2022 at 19:24, Johan Hovold <johan@kernel.org> wrote:
> >
> > On Tue, Jul 12, 2022 at 08:10:44PM +0530, Manivannan Sadhasivam wrote:
> > > On Tue, Jul 12, 2022 at 07:30:09PM +0530, Parikshit Pareek wrote:
> > > > Wrong values have been introduced for interrupts property. Fix those
> > > > ones, and correct the mapping of context banks to irq number.
> > > >
> > >
> > > And you ignored my comment about sorting the IRQs...
> >
> > Isn't the order significant here? Either way, that would be a separate
> > change that shouldn't be merged with the fix.
>
> I'd tend to agree here. Let's get the fix in first and sort the IRQs
> in a separate commit. The order of them is strange indeed.
>
Yeah, I was expecting a separate patch for the cleanup.
Thanks,
Mani
> --
> With best wishes
> Dmitry
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-07-12 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 14:00 [PATCH v2] arm64: dts: qcom: sc8280xp: fix apps_smmu irq Parikshit Pareek
2022-07-12 14:40 ` Manivannan Sadhasivam
2022-07-12 16:11 ` Parikshit Pareek
2022-07-12 16:24 ` Johan Hovold
2022-07-12 16:41 ` Dmitry Baryshkov
2022-07-12 18:26 ` Manivannan Sadhasivam [this message]
2022-07-14 7:07 ` Sai Prakash Ranjan
2022-07-15 8:20 ` Manivannan Sadhasivam
2022-07-12 16:22 ` Johan Hovold
2022-07-12 16:41 ` Andrew Halaney
2022-07-14 7:17 ` Sai Prakash Ranjan
2022-07-15 8:08 ` Sai Prakash Ranjan
2022-07-15 8:13 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712182627.GA7766@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_kprasan@quicinc.com \
--cc=quic_ppareek@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_saipraka@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.