From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v3 27/30] phy: qcom-qmp-combo: drop pipe clock lane suffix
Date: Thu, 14 Jul 2022 14:43:30 +0200 [thread overview]
Message-ID: <20220714124333.27643-28-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220714124333.27643-1-johan+linaro@kernel.org>
The pipe clock is defined in the "lane" node so there's no need to keep
adding a redundant lane-number suffix to the clock name.
Update driver to support the new binding where the pipe clock name has
been deprecated by instead requesting the clock by index.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index faa50cf2e35e..fcb5c375425b 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -2533,7 +2533,6 @@ int qcom_qmp_phy_combo_create(struct device *dev, struct device_node *np, int id
struct phy *generic_phy;
struct qmp_phy *qphy;
const struct phy_ops *ops;
- char prop_name[MAX_PROP_NAME];
int ret;
qphy = devm_kzalloc(dev, sizeof(*qphy), GFP_KERNEL);
@@ -2599,8 +2598,7 @@ int qcom_qmp_phy_combo_create(struct device *dev, struct device_node *np, int id
* Otherwise, we initialize pipe clock to NULL for
* all phys that don't need this.
*/
- snprintf(prop_name, sizeof(prop_name), "pipe%d", id);
- qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name);
+ qphy->pipe_clk = devm_get_clk_from_child(dev, np, NULL);
if (IS_ERR(qphy->pipe_clk)) {
if (cfg->type == PHY_TYPE_USB3) {
ret = PTR_ERR(qphy->pipe_clk);
--
2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v3 27/30] phy: qcom-qmp-combo: drop pipe clock lane suffix
Date: Thu, 14 Jul 2022 14:43:30 +0200 [thread overview]
Message-ID: <20220714124333.27643-28-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220714124333.27643-1-johan+linaro@kernel.org>
The pipe clock is defined in the "lane" node so there's no need to keep
adding a redundant lane-number suffix to the clock name.
Update driver to support the new binding where the pipe clock name has
been deprecated by instead requesting the clock by index.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index faa50cf2e35e..fcb5c375425b 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -2533,7 +2533,6 @@ int qcom_qmp_phy_combo_create(struct device *dev, struct device_node *np, int id
struct phy *generic_phy;
struct qmp_phy *qphy;
const struct phy_ops *ops;
- char prop_name[MAX_PROP_NAME];
int ret;
qphy = devm_kzalloc(dev, sizeof(*qphy), GFP_KERNEL);
@@ -2599,8 +2598,7 @@ int qcom_qmp_phy_combo_create(struct device *dev, struct device_node *np, int id
* Otherwise, we initialize pipe clock to NULL for
* all phys that don't need this.
*/
- snprintf(prop_name, sizeof(prop_name), "pipe%d", id);
- qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name);
+ qphy->pipe_clk = devm_get_clk_from_child(dev, np, NULL);
if (IS_ERR(qphy->pipe_clk)) {
if (cfg->type == PHY_TYPE_USB3) {
ret = PTR_ERR(qphy->pipe_clk);
--
2.35.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-07-14 12:44 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 12:43 [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 01/30] dt-bindings: phy: qcom,qmp: fix bogus clock-cells property Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 02/30] dt-bindings: phy: qcom,qmp: sort compatible strings Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 03/30] dt-bindings: phy: qcom,qmp: drop redundant descriptions Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 04/30] dt-bindings: phy: qcom,qmp: fix child node description Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 05/30] dt-bindings: phy: qcom,qmp: clean up descriptions Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 06/30] dt-bindings: phy: qcom,qmp: clean up example Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 07/30] dt-bindings: phy: qcom,qmp: drop child-node comment Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 08/30] dt-bindings: phy: add qcom,msm8996-qmp-pcie-phy schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 09/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 10/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock names Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 11/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 12/30] dt-bindings: phy: add QMP PCIe PHY schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 13/30] dt-bindings: phy: qcom,qmp-pcie: add missing child node schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 14/30] dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock name Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 15/30] dt-bindings: phy: add QMP UFS PHY schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 16/30] dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 17/30] dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domain Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 18/30] dt-bindings: phy: qcom,qmp-ufs: add missing child node schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 19/30] dt-bindings: phy: add QMP USB PHY schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 20/30] dt-bindings: phy: qcom,qmp-usb: add missing child node schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-14 12:43 ` [PATCH v3 21/30] dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock name Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 22/30] dt-bindings: phy: qcom,qmp-usb: add missing qcom,sc7180-qmp-usb3-phy schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 23/30] dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells property Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 24/30] dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock name Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 25/30] phy: qcom-qmp-pcie: drop pipe clock lane suffix Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 10:59 ` Dmitry Baryshkov
2022-07-15 10:59 ` Dmitry Baryshkov
2022-07-14 12:43 ` [PATCH v3 26/30] phy: qcom-qmp-combo: drop unused lane reset Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` Johan Hovold [this message]
2022-07-14 12:43 ` [PATCH v3 27/30] phy: qcom-qmp-combo: drop pipe clock lane suffix Johan Hovold
2022-07-15 10:59 ` Dmitry Baryshkov
2022-07-15 10:59 ` Dmitry Baryshkov
2022-07-14 12:43 ` [PATCH v3 28/30] phy: qcom-qmp-pcie-msm8996: " Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 10:57 ` Dmitry Baryshkov
2022-07-15 10:57 ` Dmitry Baryshkov
2022-07-14 12:43 ` [PATCH v3 29/30] phy: qcom-qmp-pcie-msm8996: drop reset " Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 10:58 ` Dmitry Baryshkov
2022-07-15 10:58 ` Dmitry Baryshkov
2022-07-14 12:43 ` [PATCH v3 30/30] phy: qcom-qmp-usb: drop pipe clock " Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 11:00 ` Dmitry Baryshkov
2022-07-15 11:00 ` Dmitry Baryshkov
2022-07-18 12:17 ` [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate " Johan Hovold
2022-07-18 12:17 ` Johan Hovold
2022-08-29 9:13 ` Johan Hovold
2022-08-29 9:13 ` Johan Hovold
2022-08-30 5:05 ` Vinod Koul
2022-08-30 5:05 ` Vinod Koul
2022-08-30 7:02 ` Johan Hovold
2022-08-30 7:02 ` Johan Hovold
2022-08-30 5:06 ` Vinod Koul
2022-08-30 5:06 ` Vinod Koul
2022-08-30 7:01 ` Johan Hovold
2022-08-30 7:01 ` Johan Hovold
2022-08-30 7:28 ` Vinod Koul
2022-08-30 7:28 ` Vinod Koul
2022-08-30 7:43 ` Johan Hovold
2022-08-30 7:43 ` Johan Hovold
2022-08-30 8:27 ` Vinod Koul
2022-08-30 8:27 ` Vinod Koul
2022-08-30 9:32 ` Dmitry Baryshkov
2022-08-30 9:32 ` Dmitry Baryshkov
2022-08-30 11:37 ` Johan Hovold
2022-08-30 11:37 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714124333.27643-28-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.