From: Vinod Koul <vkoul@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix
Date: Tue, 30 Aug 2022 12:58:21 +0530 [thread overview]
Message-ID: <Yw28FdhYSv4x0a6B@matsya> (raw)
In-Reply-To: <Yw21t1SUGjCcUuuw@hovoldconsulting.com>
On 30-08-22, 09:01, Johan Hovold wrote:
> On Tue, Aug 30, 2022 at 10:36:43AM +0530, Vinod Koul wrote:
> > On 14-07-22, 14:43, Johan Hovold wrote:
> > > When adding support for SC8280XP to the QMP PHY driver I noticed that
> > > the PHY provider child node was not described by the current DT schema.
> > >
> > > The SC8280XP PHYs also need a second fixed-divider PIPE clock
> > > ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to
> > > the clock name just to match the current "pipe0" name so I decided to
> > > deprecate the unnecessary suffix in the current binding instead.
> > >
> > > To be able to add the missing child-node schema and handle device
> > > specifics like additional PIPE clocks, it quickly became obvious that
> > > the binding needs to be split up.
> > >
> > > This series clean up and fixes some issue with the current schema before
> > > splitting it up in separate schemas for PCIe, UFS and USB and adding
> > > missing parts like the child PHY provider nodes.
> > >
> > > The MSM8996 PCIe PHY gets its own schema as this is the only non-combo
> > > PHY that actually provides more than one PHY per IP block. Note that the
> > > "lane" suffix is still unnecessary and misleading.
> > >
> > > The final patches add support for the updated binding to the (recently
> > > split up) PHY drivers. Included is also a related combo PHY cleanup.
> >
> > This fails at patch 2 for me on v6.0-rc1, please rebase and resend
>
> Are you sure you haven't applied anything to your local tree that causes
> this?
Pretty sure :-)
>
> I just tried fetching the v3 series from lore and it applies just fine
> on top of 6.0-rc1.
>
> Note that if you've added a new compatible string locally, the second
> patch which sorts the compatible strings is likely to fail to apply.
At that time no, now I think I have patch or so ... Tree should be
pushed in a bit, you can check
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix
Date: Tue, 30 Aug 2022 12:58:21 +0530 [thread overview]
Message-ID: <Yw28FdhYSv4x0a6B@matsya> (raw)
In-Reply-To: <Yw21t1SUGjCcUuuw@hovoldconsulting.com>
On 30-08-22, 09:01, Johan Hovold wrote:
> On Tue, Aug 30, 2022 at 10:36:43AM +0530, Vinod Koul wrote:
> > On 14-07-22, 14:43, Johan Hovold wrote:
> > > When adding support for SC8280XP to the QMP PHY driver I noticed that
> > > the PHY provider child node was not described by the current DT schema.
> > >
> > > The SC8280XP PHYs also need a second fixed-divider PIPE clock
> > > ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to
> > > the clock name just to match the current "pipe0" name so I decided to
> > > deprecate the unnecessary suffix in the current binding instead.
> > >
> > > To be able to add the missing child-node schema and handle device
> > > specifics like additional PIPE clocks, it quickly became obvious that
> > > the binding needs to be split up.
> > >
> > > This series clean up and fixes some issue with the current schema before
> > > splitting it up in separate schemas for PCIe, UFS and USB and adding
> > > missing parts like the child PHY provider nodes.
> > >
> > > The MSM8996 PCIe PHY gets its own schema as this is the only non-combo
> > > PHY that actually provides more than one PHY per IP block. Note that the
> > > "lane" suffix is still unnecessary and misleading.
> > >
> > > The final patches add support for the updated binding to the (recently
> > > split up) PHY drivers. Included is also a related combo PHY cleanup.
> >
> > This fails at patch 2 for me on v6.0-rc1, please rebase and resend
>
> Are you sure you haven't applied anything to your local tree that causes
> this?
Pretty sure :-)
>
> I just tried fetching the v3 series from lore and it applies just fine
> on top of 6.0-rc1.
>
> Note that if you've added a new compatible string locally, the second
> patch which sorts the compatible strings is likely to fail to apply.
At that time no, now I think I have patch or so ... Tree should be
pushed in a bit, you can check
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-08-30 7:28 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 12:43 [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 01/30] dt-bindings: phy: qcom,qmp: fix bogus clock-cells property Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 02/30] dt-bindings: phy: qcom,qmp: sort compatible strings Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 03/30] dt-bindings: phy: qcom,qmp: drop redundant descriptions Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 04/30] dt-bindings: phy: qcom,qmp: fix child node description Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 05/30] dt-bindings: phy: qcom,qmp: clean up descriptions Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 06/30] dt-bindings: phy: qcom,qmp: clean up example Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 07/30] dt-bindings: phy: qcom,qmp: drop child-node comment Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 08/30] dt-bindings: phy: add qcom,msm8996-qmp-pcie-phy schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 09/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 10/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock names Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 11/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 12/30] dt-bindings: phy: add QMP PCIe PHY schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 13/30] dt-bindings: phy: qcom,qmp-pcie: add missing child node schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 14/30] dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock name Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 15/30] dt-bindings: phy: add QMP UFS PHY schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 16/30] dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 17/30] dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domain Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 18/30] dt-bindings: phy: qcom,qmp-ufs: add missing child node schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 19/30] dt-bindings: phy: add QMP USB PHY schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 20/30] dt-bindings: phy: qcom,qmp-usb: add missing child node schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-14 12:43 ` [PATCH v3 21/30] dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock name Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 22/30] dt-bindings: phy: qcom,qmp-usb: add missing qcom,sc7180-qmp-usb3-phy schema Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 23/30] dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells property Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 24/30] dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock name Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 25/30] phy: qcom-qmp-pcie: drop pipe clock lane suffix Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 10:59 ` Dmitry Baryshkov
2022-07-15 10:59 ` Dmitry Baryshkov
2022-07-14 12:43 ` [PATCH v3 26/30] phy: qcom-qmp-combo: drop unused lane reset Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-14 12:43 ` [PATCH v3 27/30] phy: qcom-qmp-combo: drop pipe clock lane suffix Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 10:59 ` Dmitry Baryshkov
2022-07-15 10:59 ` Dmitry Baryshkov
2022-07-14 12:43 ` [PATCH v3 28/30] phy: qcom-qmp-pcie-msm8996: " Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 10:57 ` Dmitry Baryshkov
2022-07-15 10:57 ` Dmitry Baryshkov
2022-07-14 12:43 ` [PATCH v3 29/30] phy: qcom-qmp-pcie-msm8996: drop reset " Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 9:28 ` Krzysztof Kozlowski
2022-07-15 10:58 ` Dmitry Baryshkov
2022-07-15 10:58 ` Dmitry Baryshkov
2022-07-14 12:43 ` [PATCH v3 30/30] phy: qcom-qmp-usb: drop pipe clock " Johan Hovold
2022-07-14 12:43 ` Johan Hovold
2022-07-15 11:00 ` Dmitry Baryshkov
2022-07-15 11:00 ` Dmitry Baryshkov
2022-07-18 12:17 ` [PATCH v3 00/30] phy: qcom,qmp: fix dt-bindings and deprecate " Johan Hovold
2022-07-18 12:17 ` Johan Hovold
2022-08-29 9:13 ` Johan Hovold
2022-08-29 9:13 ` Johan Hovold
2022-08-30 5:05 ` Vinod Koul
2022-08-30 5:05 ` Vinod Koul
2022-08-30 7:02 ` Johan Hovold
2022-08-30 7:02 ` Johan Hovold
2022-08-30 5:06 ` Vinod Koul
2022-08-30 5:06 ` Vinod Koul
2022-08-30 7:01 ` Johan Hovold
2022-08-30 7:01 ` Johan Hovold
2022-08-30 7:28 ` Vinod Koul [this message]
2022-08-30 7:28 ` Vinod Koul
2022-08-30 7:43 ` Johan Hovold
2022-08-30 7:43 ` Johan Hovold
2022-08-30 8:27 ` Vinod Koul
2022-08-30 8:27 ` Vinod Koul
2022-08-30 9:32 ` Dmitry Baryshkov
2022-08-30 9:32 ` Dmitry Baryshkov
2022-08-30 11:37 ` Johan Hovold
2022-08-30 11:37 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw28FdhYSv4x0a6B@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.