Re: [Buildroot] [PATCH 1/4] package/arm-gnu-toolchain: add version selection

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Tue, 26 Jul 2022 11:50:38 -0500
Xuanhao Shi via buildroot <buildroot@buildroot.org> wrote:

> Adds a way to select a custom toolchain link and
> source instead of always using verion 11.2 due

version -> version

> to bugs in the newest version.

Could you give some details on the "bugs" ?

> diff --git a/package/arm-gnu-toolchain/Config.in.host b/package/arm-gnu-toolchain/Config.in.host
> new file mode 100644
> index 0000000000..25d0af1d04
> --- /dev/null
> +++ b/package/arm-gnu-toolchain/Config.in.host
> @@ -0,0 +1,38 @@
> +config BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN
> +	bool "host arm-gnu-toolchain"
> +	help
> +	  Separate ARM32 cross-compilation toolchain 
> +	  for some AArch64 platforms.
> +
> +menu "host arm-gnu-toolchain version"
> +	depends on BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN

The menu is not needed.

Use:

if BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN

...

endif

to enclose the options of this package.

> +choice
> +	bool "host arm-gnu-toolchain version"

Just "version"

> +config BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_DEFAULT
> +	bool "Version 11.2-2022.02"
> +	help
> +	  Use version 11.2.
> +
> +config BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_CUSTOM
> +	bool "Custom archived sources"
> +	help
> +	  Specify custom archive for the toolchain.

Seeing what you end up needing in your defconfig, I think I would
prefer explicit options for 11.x and 10.x, rather than all this
"custom" mess.

So just:

config BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_VERSION_11_X
	...
config BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_VERSION_10_X
	...

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot