Re: [Buildroot] [PATCH 4/4] configs/am64x_sk_defconfig: add new defconfig

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Xuanhao Shi <x-shi@ti.com>
Cc: Suniel Mahesh <sunil@amarulasolutions.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 4/4] configs/am64x_sk_defconfig: add new defconfig
Date: Tue, 26 Jul 2022 21:00:13 +0200	[thread overview]
Message-ID: <20220726210013.45bf33ec@windsurf> (raw)
In-Reply-To: <20220726165041.17584-5-x-shi@ti.com>

Hello,

On Tue, 26 Jul 2022 11:50:41 -0500
Xuanhao Shi <x-shi@ti.com> wrote:

> Adds the new defconfig for TI's AM64X_SK board after patch.
> 
> Signed-off-by: Xuanhao Shi <x-shi@ti.com>
> ---
>  configs/am64x_sk_defconfig | 44 ++++++++++++++++++++++++++++++++++++++

This should be squashed into the previous commit.

Also, please add entries in the DEVELOPERS file for the board/
directory and this new defconfig.

>  1 file changed, 44 insertions(+)
>  create mode 100644 configs/am64x_sk_defconfig
> 
> diff --git a/configs/am64x_sk_defconfig b/configs/am64x_sk_defconfig
> new file mode 100644
> index 0000000000..629bff6519
> --- /dev/null
> +++ b/configs/am64x_sk_defconfig
> @@ -0,0 +1,44 @@
> +BR2_aarch64=y
> +BR2_TOOLCHAIN_EXTERNAL=y
> +BR2_INIT_SYSTEMD=y

We want our defconfigs to be minimal, so keep the default toolchain and
default init system.

> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/am6x/genimage.cfg"
> +BR2_LINUX_KERNEL=y

You must specify an explicit kernel version so that the build is
reproducible.

> +BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="$(TOPDIR)/board/am6x/am64x/linux/ti_sdk_arm64_release_defconfig"

Drop $(TOPDIR)/, it is not needed.

> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="ti/k3-am642-sk"
> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> +BR2_PACKAGE_LINUX_FIRMWARE=y
> +BR2_PACKAGE_LINUX_FIRMWARE_TI_WL18XX=y
> +BR2_PACKAGE_K3_IMAGE_GEN=y
> +BR2_PACKAGE_K3_IMAGE_GEN_UBOOT_SPL_DEFCONFIG="am64x_evm_r5"
> +BR2_PACKAGE_K3_IMAGE_GEN_SOC="am64x"
> +BR2_PACKAGE_K3_IMAGE_GEN_CONFIG="evm"
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y

You must specify an explicit TF-A version so that the build is
reproducible.

> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="k3"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_TARGET_BOARD="lite"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="SPD=opteed"
> +BR2_TARGET_OPTEE_OS=y

You must specify an explicit OP-TEE version so that the build is
reproducible.

> +BR2_TARGET_OPTEE_OS_PLATFORM="k3"
> +BR2_TARGET_OPTEE_OS_CORE_IMAGES="tee-pager_v2.bin"
> +BR2_TARGET_UBOOT=y

You must specify an explicit U-Boot version so that the build is
reproducible.

> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="am64x_evm_a53"
> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
> +# BR2_TARGET_UBOOT_FORMAT_BIN is not set
> +BR2_TARGET_UBOOT_FORMAT_IMG=y
> +BR2_TARGET_UBOOT_SPL=y
> +BR2_TARGET_UBOOT_SPL_NAME="tispl.bin"
> +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="TEE=$(BINARIES_DIR)/tee-pager_v2.bin"
> +BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN=y
> +BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_CUSTOM=y
> +BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_CUSTOM_SITE="https://developer.arm.com/-/media/Files/downloads/gnu-rm/10.3-2021.10"
> +BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_CUSTOM_SOURCE="gcc-arm-none-eabi-10.3-2021.10-x86_64-linux.tar.bz2"
> +BR2_PACKAGE_HOST_ARM_GNU_TOOLCHAIN_CUSTOM_LICENSE="GPL-3.0+"
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot