Re: [Buildroot] [PATCH 3/4] board/am6x: add new board support

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Tue, 26 Jul 2022 11:50:40 -0500
Xuanhao Shi <x-shi@ti.com> wrote:

> Adds the board support for TI's AM6X SoCs after patch,
> Currently just AM64X to start.
> 
> Signed-off-by: Xuanhao Shi <x-shi@ti.com>
> ---
>  .../linux/ti_sdk_arm64_release_defconfig      | 1983 +++++++++++++++++
>  board/am6x/genimage.cfg                       |   27 +
>  board/am6x/readme.txt                         |   41 +
>  3 files changed, 2051 insertions(+)
>  create mode 100644 board/am6x/am64x/linux/ti_sdk_arm64_release_defconfig
>  create mode 100644 board/am6x/genimage.cfg
>  create mode 100644 board/am6x/readme.txt
> 
> diff --git a/board/am6x/am64x/linux/ti_sdk_arm64_release_defconfig b/board/am6x/am64x/linux/ti_sdk_arm64_release_defconfig
> new file mode 100644
> index 0000000000..7000ee1170
> --- /dev/null
> +++ b/board/am6x/am64x/linux/ti_sdk_arm64_release_defconfig

Just board/am6x/am64x/linux.config

Does your board have an actual name? Because am64x is just the name of
the SoC, no?

> @@ -0,0 +1,1983 @@
> +CONFIG_SYSVIPC=y
> +CONFIG_POSIX_MQUEUE=y
> +CONFIG_NO_HZ_IDLE=y
> +CONFIG_HIGH_RES_TIMERS=y
> +CONFIG_PREEMPT=y
> +CONFIG_IRQ_TIME_ACCOUNTING=y

[...]

This is a huge config file, with obviously stuff that isn't needed for
your platform. Could you review it and strip it down to some reasonable
level? It enables zillions of drivers that make absolutely no sense for
a TI platform.


> +##################################################
> +# TI Baseport Config Options
> +##################################################

Please do not manually edit the kernel configuration file.


> diff --git a/board/am6x/readme.txt b/board/am6x/readme.txt
> new file mode 100644
> index 0000000000..b08c385146
> --- /dev/null
> +++ b/board/am6x/readme.txt
> @@ -0,0 +1,41 @@
> +Texas Instuments AM6X Evaluation Modules
> +
> +Description
> +===========
> +
> +These configurations will build a complete image and 
> +device tree blobs for the the TI AM6X boards.

Which "boards" ? Normally, we have one readme.txt per board, as the
details are board-specific, such as where is the UART connector, how to
flash, etc.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot