From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org,
"Steen Hegelund" <Steen.Hegelund@microchip.com>,
UNGLinuxDriver@microchip.com,
"Lars Povlsen" <lars.povlsen@microchip.com>,
kernel@pengutronix.de, "Nuno Sá" <nuno.sa@analog.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] hwmon: Make use of devm_clk_get_enabled()
Date: Mon, 8 Aug 2022 15:30:07 +0100 [thread overview]
Message-ID: <20220808153007.00007208@huawei.com> (raw)
In-Reply-To: <20220808075408.i63dtoe66hm7xwta@pengutronix.de>
On Mon, 8 Aug 2022 09:54:08 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> On Mon, Aug 08, 2022 at 08:06:40AM +0200, Uwe Kleine-König wrote:
> > Several drivers manually register a devm handler to disable their clk.
> > Convert them to devm_clk_get_enabled().
> >
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> > Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Oh, the tags by Nuno Sá and Jonathan Cameron are a fake. I picked them
> by mistake from the (similar) patch for iio. Please take care about that
> before application. (i.e. drop them, or make me resend the patch without
> the tags, or make the two give the tags post-factum :-)
>
> Best regards and sorry for the chaos,
> Uwe
>
Much like the IIO one you may get a request to split it by driver.
I personally prefer per driver patches as Andy suggested, but meh, it is
up to the hmwon maintainer.
I'm feeling particularly unhelpful today. As it's not IIO patches going
through another tree (like the IIO one was when I gave that tag):
+ simple patch to quickly review.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
*evil laugh*
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org,
"Steen Hegelund" <Steen.Hegelund@microchip.com>,
UNGLinuxDriver@microchip.com,
"Lars Povlsen" <lars.povlsen@microchip.com>,
kernel@pengutronix.de, "Nuno Sá" <nuno.sa@analog.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] hwmon: Make use of devm_clk_get_enabled()
Date: Mon, 8 Aug 2022 15:30:07 +0100 [thread overview]
Message-ID: <20220808153007.00007208@huawei.com> (raw)
In-Reply-To: <20220808075408.i63dtoe66hm7xwta@pengutronix.de>
On Mon, 8 Aug 2022 09:54:08 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> On Mon, Aug 08, 2022 at 08:06:40AM +0200, Uwe Kleine-König wrote:
> > Several drivers manually register a devm handler to disable their clk.
> > Convert them to devm_clk_get_enabled().
> >
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> > Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Oh, the tags by Nuno Sá and Jonathan Cameron are a fake. I picked them
> by mistake from the (similar) patch for iio. Please take care about that
> before application. (i.e. drop them, or make me resend the patch without
> the tags, or make the two give the tags post-factum :-)
>
> Best regards and sorry for the chaos,
> Uwe
>
Much like the IIO one you may get a request to split it by driver.
I personally prefer per driver patches as Andy suggested, but meh, it is
up to the hmwon maintainer.
I'm feeling particularly unhelpful today. As it's not IIO patches going
through another tree (like the IIO one was when I gave that tag):
+ simple patch to quickly review.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
*evil laugh*
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-08 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 6:06 [PATCH] hwmon: Make use of devm_clk_get_enabled() Uwe Kleine-König
2022-08-08 6:06 ` Uwe Kleine-König
2022-08-08 7:54 ` Uwe Kleine-König
2022-08-08 7:54 ` Uwe Kleine-König
2022-08-08 14:30 ` Jonathan Cameron [this message]
2022-08-08 14:30 ` Jonathan Cameron
2022-08-08 15:45 ` Guenter Roeck
2022-08-08 15:45 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2022-09-23 0:23 Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808153007.00007208@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=jdelvare@suse.com \
--cc=kernel@pengutronix.de \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.