Re: [PATCH v7 1/4] vdpa: Add suspend operation

From: "Michael S. Tsirkin" <mst@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: tanuj.kamde@amd.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	"Wu Zongyong" <wuzongyong@linux.alibaba.com>,
	pabloc@xilinx.com, "Eli Cohen" <elic@nvidia.com>,
	"Zhang Min" <zhang.min9@zte.com.cn>,
	lulu@redhat.com, "Xie Yongji" <xieyongji@bytedance.com>,
	Piotr.Uminski@intel.com, martinh@xilinx.com,
	"Eugenio Pérez" <eperezma@redhat.com>,
	dinang@xilinx.com, habetsm.xilinx@gmail.com,
	Longpeng <longpeng2@huawei.com>,
	lvivier@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, ecree.xilinx@gmail.com,
	hanand@xilinx.com, martinpo@xilinx.com, gautam.dawar@amd.com,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Zhu Lingshan" <lingshan.zhu@intel.com>
Subject: Re: [PATCH v7 1/4] vdpa: Add suspend operation
Date: Thu, 11 Aug 2022 07:23:44 -0400	[thread overview]
Message-ID: <20220811072125-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220811101507.GU3460@kadam>

On Thu, Aug 11, 2022 at 01:15:08PM +0300, Dan Carpenter wrote:
> On Thu, Aug 11, 2022 at 04:27:32AM -0400, Michael S. Tsirkin wrote:
> > On Wed, Aug 10, 2022 at 07:15:09PM +0200, Eugenio Pérez wrote:
> > > This operation is optional: It it's not implemented, backend feature bit
> > > will not be exposed.
> > > 
> > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > > Message-Id: <20220623160738.632852-2-eperezma@redhat.com>
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > What is this message id doing here?
> > 
> 
> I like the Message-Id tag.  It means you can `b4 mbox <mesg-id>` and get
> the thread.

Yes it makes sense in git. But I don't see what it does in this patch
posted to the list. It seems to refer to the previous version of the
patch here. Which is ok I guess but better called out e.g.

Previous-version: <20220623160738.632852-2-eperezma@redhat.com>

> Linus has complained (rough remembering) that everyone is using the
> Link: tag for links to the patch itself.  It's supposed to be for Links
> to bugzilla or to the spec or whatever.  Extra information, too much to
> put in the commit message.  Now the Link tag is useless because it either
> points to the patch or to a bugzilla.  Depend on what you want it to do,
> it *always* points to the opposite thing.
> 
> But I can't remember what people settled on as the alternative to use
> to link to lore...
> 
> In theory, we should be able to figure out the link to lore automatically
> and there have been a couple projects which tried to do this but they
> can't make it work 100%.  Maintainers massage and reformat the patches
> too much before applying them.
> 
> regards,
> dan carpenter

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization