From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: tanuj.kamde@amd.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"Wu Zongyong" <wuzongyong@linux.alibaba.com>,
pabloc@xilinx.com, "Eli Cohen" <elic@nvidia.com>,
"Zhang Min" <zhang.min9@zte.com.cn>,
lulu@redhat.com, "Xie Yongji" <xieyongji@bytedance.com>,
Piotr.Uminski@intel.com, martinh@xilinx.com,
"Eugenio Pérez" <eperezma@redhat.com>,
dinang@xilinx.com, habetsm.xilinx@gmail.com,
Longpeng <longpeng2@huawei.com>,
lvivier@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ecree.xilinx@gmail.com,
hanand@xilinx.com, martinpo@xilinx.com, gautam.dawar@amd.com,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Zhu Lingshan" <lingshan.zhu@intel.com>
Subject: Re: [PATCH v7 1/4] vdpa: Add suspend operation
Date: Thu, 11 Aug 2022 15:40:21 +0300 [thread overview]
Message-ID: <20220811124021.GW3460@kadam> (raw)
In-Reply-To: <20220811072125-mutt-send-email-mst@kernel.org>
On Thu, Aug 11, 2022 at 07:23:44AM -0400, Michael S. Tsirkin wrote:
> On Thu, Aug 11, 2022 at 01:15:08PM +0300, Dan Carpenter wrote:
> > On Thu, Aug 11, 2022 at 04:27:32AM -0400, Michael S. Tsirkin wrote:
> > > On Wed, Aug 10, 2022 at 07:15:09PM +0200, Eugenio Pérez wrote:
> > > > This operation is optional: It it's not implemented, backend feature bit
> > > > will not be exposed.
> > > >
> > > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > > > Message-Id: <20220623160738.632852-2-eperezma@redhat.com>
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > What is this message id doing here?
> > >
> >
> > I like the Message-Id tag. It means you can `b4 mbox <mesg-id>` and get
> > the thread.
>
> Yes it makes sense in git. But I don't see what it does in this patch
> posted to the list.
Ah. Okay. I misunderstood.
> It seems to refer to the previous version of the
> patch here. Which is ok I guess but better called out e.g.
>
> Previous-version: <20220623160738.632852-2-eperezma@redhat.com>
>
Let's not go over board with storing previous threads. That seems like
a headache...
regards,
dan carpenter
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Eugenio Pérez" <eperezma@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jason Wang" <jasowang@redhat.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, dinang@xilinx.com, martinpo@xilinx.com,
"Wu Zongyong" <wuzongyong@linux.alibaba.com>,
Piotr.Uminski@intel.com, gautam.dawar@amd.com,
ecree.xilinx@gmail.com, martinh@xilinx.com,
"Stefano Garzarella" <sgarzare@redhat.com>,
pabloc@xilinx.com, habetsm.xilinx@gmail.com, lvivier@redhat.com,
"Zhu Lingshan" <lingshan.zhu@intel.com>,
tanuj.kamde@amd.com, Longpeng <longpeng2@huawei.com>,
lulu@redhat.com, hanand@xilinx.com,
"Parav Pandit" <parav@nvidia.com>,
"Si-Wei Liu" <si-wei.liu@oracle.com>,
"Eli Cohen" <elic@nvidia.com>,
"Xie Yongji" <xieyongji@bytedance.com>,
"Zhang Min" <zhang.min9@zte.com.cn>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v7 1/4] vdpa: Add suspend operation
Date: Thu, 11 Aug 2022 15:40:21 +0300 [thread overview]
Message-ID: <20220811124021.GW3460@kadam> (raw)
In-Reply-To: <20220811072125-mutt-send-email-mst@kernel.org>
On Thu, Aug 11, 2022 at 07:23:44AM -0400, Michael S. Tsirkin wrote:
> On Thu, Aug 11, 2022 at 01:15:08PM +0300, Dan Carpenter wrote:
> > On Thu, Aug 11, 2022 at 04:27:32AM -0400, Michael S. Tsirkin wrote:
> > > On Wed, Aug 10, 2022 at 07:15:09PM +0200, Eugenio Pérez wrote:
> > > > This operation is optional: It it's not implemented, backend feature bit
> > > > will not be exposed.
> > > >
> > > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > > > Message-Id: <20220623160738.632852-2-eperezma@redhat.com>
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > What is this message id doing here?
> > >
> >
> > I like the Message-Id tag. It means you can `b4 mbox <mesg-id>` and get
> > the thread.
>
> Yes it makes sense in git. But I don't see what it does in this patch
> posted to the list.
Ah. Okay. I misunderstood.
> It seems to refer to the previous version of the
> patch here. Which is ok I guess but better called out e.g.
>
> Previous-version: <20220623160738.632852-2-eperezma@redhat.com>
>
Let's not go over board with storing previous threads. That seems like
a headache...
regards,
dan carpenter
next prev parent reply other threads:[~2022-08-11 12:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 17:15 [PATCH v7 0/4] Implement vdpasim suspend operation Eugenio Pérez
2022-08-10 17:15 ` [PATCH v7 1/4] vdpa: Add " Eugenio Pérez
2022-08-11 8:27 ` Michael S. Tsirkin
2022-08-11 8:27 ` Michael S. Tsirkin
2022-08-11 10:15 ` Dan Carpenter
2022-08-11 10:15 ` Dan Carpenter
2022-08-11 11:23 ` Michael S. Tsirkin
2022-08-11 11:23 ` Michael S. Tsirkin
2022-08-11 12:40 ` Dan Carpenter [this message]
2022-08-11 12:40 ` Dan Carpenter
2022-08-10 17:15 ` [PATCH v7 2/4] vhost-vdpa: introduce SUSPEND backend feature bit Eugenio Pérez
2022-08-10 17:15 ` [PATCH v7 3/4] vhost-vdpa: uAPI to suspend the device Eugenio Pérez
2022-08-11 8:29 ` Michael S. Tsirkin
2022-08-11 8:29 ` Michael S. Tsirkin
2022-08-11 9:58 ` Eugenio Perez Martin
2022-08-10 17:15 ` [PATCH v7 4/4] vdpa_sim: Implement suspend vdpa op Eugenio Pérez
2022-08-10 19:19 ` [PATCH v7 0/4] Implement vdpasim suspend operation Michael S. Tsirkin
2022-08-10 19:19 ` Michael S. Tsirkin
2022-08-11 5:35 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811124021.GW3460@kadam \
--to=dan.carpenter@oracle.com \
--cc=Piotr.Uminski@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dinang@xilinx.com \
--cc=ecree.xilinx@gmail.com \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gautam.dawar@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hanand@xilinx.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=martinh@xilinx.com \
--cc=martinpo@xilinx.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabloc@xilinx.com \
--cc=tanuj.kamde@amd.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzongyong@linux.alibaba.com \
--cc=xieyongji@bytedance.com \
--cc=zhang.min9@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.