All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bram Vlerick <bram.vlerick@openpixelsystems.org>
Cc: Refik Tuzakli <tuzakli.refik@gmail.com>,
	Gary Bisson <bisson.gary@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/freescale-imx/firmware-imx: allow lpddr4 firmware version override
Date: Thu, 11 Aug 2022 22:41:44 +0200	[thread overview]
Message-ID: <20220811224144.78b1581a@windsurf> (raw)
In-Reply-To: <20220811122011.716045-1-bram.vlerick@openpixelsystems.org>

Hello Blam,

On Thu, 11 Aug 2022 14:20:11 +0200
Bram Vlerick <bram.vlerick@openpixelsystems.org> wrote:

> Add support for selecting a specific version of the LPDDR4 firmware
> version. Variscite's imx8mp-var-dart SOM requires the "_202006" version
> of the lpddr4_pmu_train_* binaries.
> 
> Signed-off-by: Bram Vlerick <bram.vlerick@openpixelsystems.org>

Thanks a lot for your patch. Looks good overall. A few comments below,
though.

>  package/freescale-imx/firmware-imx/Config.in       | 10 ++++++++++
>  package/freescale-imx/firmware-imx/firmware-imx.mk | 12 ++++++++++--
>  2 files changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/package/freescale-imx/firmware-imx/Config.in b/package/freescale-imx/firmware-imx/Config.in
> index 06c4d8036c..f894d87250 100644
> --- a/package/freescale-imx/firmware-imx/Config.in
> +++ b/package/freescale-imx/firmware-imx/Config.in
> @@ -82,6 +82,16 @@ config BR2_PACKAGE_FIRMWARE_IMX_DDR3
>  
>  endchoice # DDR training FW
>  
> +if BR2_PACKAGE_FIRMWARE_IMX_LPDDR4
> +
> +config BR2_PACKAGE_FIRMWARE_IMX_LPDDR4_VERSION
> +	string "LPDDR4 Version"
> +	help
> +	  Use a specific version of the lpddr4_pmu_train_* binaries such
> +	  as "202006".
> +
> +endif # BR2_PACKAGE_FIRMWARE_IMX_LPDDR4

Looking at the list of firmware files:

ddr3_dmem_1d_201810.bin
ddr3_dmem_1d.bin
ddr3_imem_1d_201810.bin
ddr3_imem_1d.bin
ddr4_dmem_1d_201810.bin
ddr4_dmem_1d_202006.bin
ddr4_dmem_1d.bin
ddr4_dmem_2d_201810.bin
ddr4_dmem_2d_202006.bin
ddr4_dmem_2d.bin
ddr4_imem_1d_201810.bin
ddr4_imem_1d_202006.bin
ddr4_imem_1d.bin
ddr4_imem_2d_201810.bin
ddr4_imem_2d_202006.bin
ddr4_imem_2d.bin
lpddr4_pmu_train_1d_dmem_201904.bin
lpddr4_pmu_train_1d_dmem_202006.bin
lpddr4_pmu_train_1d_dmem.bin
lpddr4_pmu_train_1d_imem_201904.bin
lpddr4_pmu_train_1d_imem_202006.bin
lpddr4_pmu_train_1d_imem.bin
lpddr4_pmu_train_2d_dmem_201904.bin
lpddr4_pmu_train_2d_dmem_202006.bin
lpddr4_pmu_train_2d_dmem.bin
lpddr4_pmu_train_2d_imem_201904.bin
lpddr4_pmu_train_2d_imem_202006.bin
lpddr4_pmu_train_2d_imem.bin

it's not only LPDDR4 firmware files that can have versions, but also
DDR3 and DDR4 ones.

So can we instead have:

config BR2_PACKAGE_FIRMWARE_IMX_DDR_VERSION
	string "DDR3/DDR4/LPDDR4 firmware version"
	help
	  ...

In the help text, perhaps state "leave empty for the default version",
or something like that.

> diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk
> index 47c21585aa..40aa84e162 100644
> --- a/package/freescale-imx/firmware-imx/firmware-imx.mk
> +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
> @@ -38,15 +38,23 @@ endef
>  
>  ifeq ($(BR2_PACKAGE_FIRMWARE_IMX_LPDDR4),y)
>  FIRMWARE_IMX_DDRFW_DIR = $(@D)/firmware/ddr/synopsys
> +ifneq ($(BR2_PACKAGE_FIRMWARE_IMX_LPDDR4_VERSION), "")
> +	FIRMWARE_IMX_LPDDR4_FW_VERSION = _$(BR2_PACKAGE_FIRMWARE_IMX_LPDDR4_VERSION)

Use qstrip, and don't indent variables, so:

FIRMWARE_IMX_DDR_VERSION = $(call qstrip,$(BR2_PACKAGE_FIRMWARE_IMX_DDR_VERSION))
ifneq ($(FIRMWARE_IMX_DDR_VERSION),)
FIRMWARE_IMX_DDR_VERSION_SUFFIX = _$(FIRMWARE_IMX_DDR_VERSION)
endif

and use $(FIRMWARE_IMX_DDR_VERSION_SUFFIX)

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-11 20:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 12:20 [Buildroot] [PATCH] package/freescale-imx/firmware-imx: allow lpddr4 firmware version override Bram Vlerick
2022-08-11 20:41 ` Thomas Petazzoni via buildroot [this message]
2022-08-12  8:51   ` Bram Vlerick
2022-08-12 13:27     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811224144.78b1581a@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bisson.gary@gmail.com \
    --cc=bram.vlerick@openpixelsystems.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tuzakli.refik@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.