All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bram Vlerick <bram.vlerick@openpixelsystems.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Refik Tuzakli <tuzakli.refik@gmail.com>,
	Gary Bisson <bisson.gary@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/freescale-imx/firmware-imx: allow lpddr4 firmware version override
Date: Fri, 12 Aug 2022 10:51:24 +0200	[thread overview]
Message-ID: <YvYUjNF8t6h19g4H@nitrogen.local> (raw)
In-Reply-To: <20220811224144.78b1581a@windsurf>

Hi Thomas,

I'm currently adding the suggested changes. With regards to the suggestion below.
The DDR3 and DDR4 already have a "hardcoded" version selected. What would be the
prefered approach, adding a default value in the firmware-imx.mk for both the DDR3
and DDR4 cases. Or would it be better to update the individual defconfig and add
the BR2_PACKAGE_FIRMWARE_IMX_DDR_VERSION variable to the configs?

On Thu, Aug 11, 2022 at 10:41:44PM +0200, Thomas Petazzoni wrote:

> it's not only LPDDR4 firmware files that can have versions, but also
> DDR3 and DDR4 ones.
> 
> So can we instead have:
> 
> config BR2_PACKAGE_FIRMWARE_IMX_DDR_VERSION
> 	string "DDR3/DDR4/LPDDR4 firmware version"
> 	help
> 	  ...
> 
> In the help text, perhaps state "leave empty for the default version",
> or something like that.
> 

Kind regards,
Bram
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-12  8:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 12:20 [Buildroot] [PATCH] package/freescale-imx/firmware-imx: allow lpddr4 firmware version override Bram Vlerick
2022-08-11 20:41 ` Thomas Petazzoni via buildroot
2022-08-12  8:51   ` Bram Vlerick [this message]
2022-08-12 13:27     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvYUjNF8t6h19g4H@nitrogen.local \
    --to=bram.vlerick@openpixelsystems.org \
    --cc=bisson.gary@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tuzakli.refik@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.