All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bram Vlerick <bram.vlerick@openpixelsystems.org>
Cc: Refik Tuzakli <tuzakli.refik@gmail.com>,
	Gary Bisson <bisson.gary@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/freescale-imx/firmware-imx: allow lpddr4 firmware version override
Date: Fri, 12 Aug 2022 15:27:46 +0200	[thread overview]
Message-ID: <20220812152746.73e52009@windsurf> (raw)
In-Reply-To: <YvYUjNF8t6h19g4H@nitrogen.local>

Hello Bram,

On Fri, 12 Aug 2022 10:51:24 +0200
Bram Vlerick <bram.vlerick@openpixelsystems.org> wrote:

> I'm currently adding the suggested changes. With regards to the suggestion below.
> The DDR3 and DDR4 already have a "hardcoded" version selected. What would be the
> prefered approach, adding a default value in the firmware-imx.mk for both the DDR3
> and DDR4 cases. Or would it be better to update the individual defconfig and add
> the BR2_PACKAGE_FIRMWARE_IMX_DDR_VERSION variable to the configs?

Good point. Then in order to preserve backward compatibility, I would suggest:

config BR2_PACKAGE_FIRMWARE_IMX_DDR_VERSION
	string "DDR3/DDR4/LPDDR4 firmware version"
	# Needed for backward compatibility, the package used to
	# unconditionally use HW version 201810 on DDR3/DDR4 before the
	# FW version was made configurable
	default "201810" if BR2_PACKAGE_FIRMWARE_IMX_DDR3 || BR2_PACKAGE_FIRMWARE_IMX_DDR4
	help
	  ...

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-08-12 13:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 12:20 [Buildroot] [PATCH] package/freescale-imx/firmware-imx: allow lpddr4 firmware version override Bram Vlerick
2022-08-11 20:41 ` Thomas Petazzoni via buildroot
2022-08-12  8:51   ` Bram Vlerick
2022-08-12 13:27     ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220812152746.73e52009@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bisson.gary@gmail.com \
    --cc=bram.vlerick@openpixelsystems.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tuzakli.refik@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.