From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "simon.horman@corigine.com" <simon.horman@corigine.com>,
"kurt@linutronix.de" <kurt@linutronix.de>,
"komachi.yoshiki@gmail.com" <komachi.yoshiki@gmail.com>,
"jchapman@katalix.com" <jchapman@katalix.com>,
"edumazet@google.com" <edumazet@google.com>,
"boris.sukholitko@broadcom.com" <boris.sukholitko@broadcom.com>,
"louis.peens@corigine.com" <louis.peens@corigine.com>,
"gnault@redhat.com" <gnault@redhat.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"vladbu@nvidia.com" <vladbu@nvidia.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"baowen.zheng@corigine.com" <baowen.zheng@corigine.com>,
"maksym.glubokiy@plvision.eu" <maksym.glubokiy@plvision.eu>,
"paulb@nvidia.com" <paulb@nvidia.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [RFC PATCH net-next 0/5] ice: L2TPv3 offload support
Date: Fri, 26 Aug 2022 18:01:34 -0700 [thread overview]
Message-ID: <20220826180134.24b3648a@kernel.org> (raw)
In-Reply-To: <YwjZ+h82UrF2MrxO@nanopsycho>
On Fri, 26 Aug 2022 16:34:34 +0200 Jiri Pirko wrote:
> >Sorry, I'll include more precise description in the next version.
> >DDP (Dynamic Device Personalization) is a firmware package that contains definitions
> >protocol's headers and packets. It allows you to add support for the new protocol to the
> >NIC card without rebooting. If the DDP package does not support L2TPv3 then hw offload
> >will not work, however sw offload will still work.
>
> Hmm, so it is some FW part? Why do we care about it here in patchset
> description?
We generally encourage people to put as much context in the commit
messages and cover letters as possible. Nothing wrong with saying
that a specific parser microcode is needed, IMHO.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "Drewek, Wojciech" <wojciech.drewek@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"marcin.szycik@linux.intel.com" <marcin.szycik@linux.intel.com>,
"michal.swiatkowski@linux.intel.com"
<michal.swiatkowski@linux.intel.com>,
"kurt@linutronix.de" <kurt@linutronix.de>,
"boris.sukholitko@broadcom.com" <boris.sukholitko@broadcom.com>,
"vladbu@nvidia.com" <vladbu@nvidia.com>,
"komachi.yoshiki@gmail.com" <komachi.yoshiki@gmail.com>,
"paulb@nvidia.com" <paulb@nvidia.com>,
"baowen.zheng@corigine.com" <baowen.zheng@corigine.com>,
"louis.peens@corigine.com" <louis.peens@corigine.com>,
"simon.horman@corigine.com" <simon.horman@corigine.com>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"maksym.glubokiy@plvision.eu" <maksym.glubokiy@plvision.eu>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"jchapman@katalix.com" <jchapman@katalix.com>,
"gnault@redhat.com" <gnault@redhat.com>
Subject: Re: [RFC PATCH net-next 0/5] ice: L2TPv3 offload support
Date: Fri, 26 Aug 2022 18:01:34 -0700 [thread overview]
Message-ID: <20220826180134.24b3648a@kernel.org> (raw)
In-Reply-To: <YwjZ+h82UrF2MrxO@nanopsycho>
On Fri, 26 Aug 2022 16:34:34 +0200 Jiri Pirko wrote:
> >Sorry, I'll include more precise description in the next version.
> >DDP (Dynamic Device Personalization) is a firmware package that contains definitions
> >protocol's headers and packets. It allows you to add support for the new protocol to the
> >NIC card without rebooting. If the DDP package does not support L2TPv3 then hw offload
> >will not work, however sw offload will still work.
>
> Hmm, so it is some FW part? Why do we care about it here in patchset
> description?
We generally encourage people to put as much context in the commit
messages and cover letters as possible. Nothing wrong with saying
that a specific parser microcode is needed, IMHO.
next prev parent reply other threads:[~2022-08-27 1:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 11:00 [Intel-wired-lan] [RFC PATCH net-next 0/5] ice: L2TPv3 offload support Wojciech Drewek
2022-08-26 11:00 ` Wojciech Drewek
2022-08-26 11:00 ` [Intel-wired-lan] [RFC PATCH net-next 1/5] uapi: move IPPROTO_L2TP to in.h Wojciech Drewek
2022-08-26 11:00 ` Wojciech Drewek
2022-08-26 11:17 ` [Intel-wired-lan] " Jiri Pirko
2022-08-26 11:17 ` Jiri Pirko
2022-08-26 11:22 ` [Intel-wired-lan] " Jiri Pirko
2022-08-26 11:22 ` Jiri Pirko
2022-08-26 11:00 ` [Intel-wired-lan] [RFC PATCH net-next 2/5] flow_dissector: Add L2TPv3 dissectors Wojciech Drewek
2022-08-26 11:00 ` Wojciech Drewek
2022-08-26 11:00 ` [Intel-wired-lan] [RFC PATCH net-next 3/5] net/sched: flower: Add L2TPv3 filter Wojciech Drewek
2022-08-26 11:00 ` Wojciech Drewek
2022-08-26 11:00 ` [Intel-wired-lan] [RFC PATCH net-next 4/5] flow_offload: Introduce flow_match_l2tpv3 Wojciech Drewek
2022-08-26 11:00 ` Wojciech Drewek
2022-08-26 11:00 ` [Intel-wired-lan] [RFC PATCH net-next 5/5] ice: Add L2TPv3 hardware offload support Wojciech Drewek
2022-08-26 11:00 ` Wojciech Drewek
2022-08-26 11:16 ` [Intel-wired-lan] [RFC PATCH net-next 0/5] ice: L2TPv3 " Jiri Pirko
2022-08-26 11:16 ` Jiri Pirko
2022-08-26 11:36 ` [Intel-wired-lan] " Drewek, Wojciech
2022-08-26 11:36 ` Drewek, Wojciech
2022-08-26 11:52 ` [Intel-wired-lan] " Drewek, Wojciech
2022-08-26 11:52 ` Drewek, Wojciech
2022-08-26 14:34 ` [Intel-wired-lan] " Jiri Pirko
2022-08-26 14:34 ` Jiri Pirko
2022-08-27 1:01 ` Jakub Kicinski [this message]
2022-08-27 1:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826180134.24b3648a@kernel.org \
--to=kuba@kernel.org \
--cc=baowen.zheng@corigine.com \
--cc=boris.sukholitko@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jchapman@katalix.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=komachi.yoshiki@gmail.com \
--cc=kurt@linutronix.de \
--cc=louis.peens@corigine.com \
--cc=maksym.glubokiy@plvision.eu \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paulb@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.