From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>,
Alexander Aring <alex.aring@gmail.com>,
Gal Pressman <gal@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled
Date: Thu, 1 Sep 2022 13:23:38 -0700 [thread overview]
Message-ID: <20220901132338.2953518c@kernel.org> (raw)
In-Reply-To: <YxBTaxMmHKiLjcCo@unreal>
On Thu, 1 Sep 2022 09:38:35 +0300 Leon Romanovsky wrote:
> There is no such thing like experimental UAPI. Once you put something
> in UAPI headers and/or allowed users to issue calls from userspace
> to kernel, they can use it. We don't control how users compile their
> kernels.
>
> So it is not break "experimental commands", but break commands that
> maybe shouldn't exist in first place.
>
> nl802154 code suffers from two basic mistakes:
> 1. User visible defines are not part of UAPI headers. For example,
> include/net/nl802154.h should be in include/uapi/net/....
> 2. Used Kconfig option for pseudo-UAPI header.
>
> In this specific case, I checked that Fedora didn't enable this
> CONFIG_IEEE802154_NL802154_EXPERIMENTAL knob, but someone needs
> to check debian and other distros too.
>
> Most likely it is not used at all.
You're right, FWIW. I didn't want to get sidetracked into that before
we fix the immediate build issue. It's not the only family playing uAPI
games :(
next prev parent reply other threads:[~2022-09-01 20:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 10:12 [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled Gal Pressman
2022-08-30 11:52 ` Sudip Mukherjee (Codethink)
2022-08-31 6:13 ` Jakub Kicinski
2022-08-31 6:20 ` Gal Pressman
2022-08-31 6:23 ` Leon Romanovsky
2022-08-31 6:31 ` Jakub Kicinski
2022-08-31 18:21 ` Jakub Kicinski
2022-08-31 19:21 ` Alexander Aring
2022-08-31 20:59 ` Stefan Schmidt
2022-08-31 21:09 ` Jakub Kicinski
2022-08-31 21:13 ` Stefan Schmidt
2022-09-01 6:38 ` Leon Romanovsky
2022-09-01 12:50 ` Alexander Aring
2022-09-01 13:05 ` Leon Romanovsky
2022-09-01 20:23 ` Jakub Kicinski [this message]
2022-09-02 2:48 ` Alexander Aring
2022-09-02 3:00 ` Jakub Kicinski
2022-09-02 10:35 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901132338.2953518c@kernel.org \
--to=kuba@kernel.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.