From: "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled
Date: Tue, 30 Aug 2022 12:52:14 +0100 [thread overview]
Message-ID: <Yw357sE8jmv15gKT@debian> (raw)
In-Reply-To: <20220830101237.22782-1-gal@nvidia.com>
On Tue, Aug 30, 2022 at 01:12:37PM +0300, Gal Pressman wrote:
> When CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled,
> NL802154_CMD_DEL_SEC_LEVEL is undefined and results in a compilation
> error:
> net/ieee802154/nl802154.c:2503:19: error: 'NL802154_CMD_DEL_SEC_LEVEL' undeclared here (not in a function); did you mean 'NL802154_CMD_SET_CCA_ED_LEVEL'?
> 2503 | .resv_start_op = NL802154_CMD_DEL_SEC_LEVEL + 1,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> | NL802154_CMD_SET_CCA_ED_LEVEL
>
> Use __NL802154_CMD_AFTER_LAST instead of
> 'NL802154_CMD_DEL_SEC_LEVEL + 1' to indicate the last command.
>
> Fixes: 9c5d03d36251 ("genetlink: start to validate reserved header bytes")
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
Tested-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
--
Regards
Sudip
next prev parent reply other threads:[~2022-08-30 11:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 10:12 [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled Gal Pressman
2022-08-30 11:52 ` Sudip Mukherjee (Codethink) [this message]
2022-08-31 6:13 ` Jakub Kicinski
2022-08-31 6:20 ` Gal Pressman
2022-08-31 6:23 ` Leon Romanovsky
2022-08-31 6:31 ` Jakub Kicinski
2022-08-31 18:21 ` Jakub Kicinski
2022-08-31 19:21 ` Alexander Aring
2022-08-31 20:59 ` Stefan Schmidt
2022-08-31 21:09 ` Jakub Kicinski
2022-08-31 21:13 ` Stefan Schmidt
2022-09-01 6:38 ` Leon Romanovsky
2022-09-01 12:50 ` Alexander Aring
2022-09-01 13:05 ` Leon Romanovsky
2022-09-01 20:23 ` Jakub Kicinski
2022-09-02 2:48 ` Alexander Aring
2022-09-02 3:00 ` Jakub Kicinski
2022-09-02 10:35 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw357sE8jmv15gKT@debian \
--to=sudipm.mukherjee@gmail.com \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.